Skip to content

spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809

Open
Bug
Open
spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
Bug
Labels
documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3

Description

@huangyiirene
huangyiirene
opened on Aug 31, 2026

Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.

The disagreement

packages/spec/src/automation/approval.zod.ts:

minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),

packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:

if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}

The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.

The key carries no Zod .default(), so nothing materialises a value at parse time and the ?? on each branch is the whole story: the effective default is per behaviour, not a single number.

Why it matters

.describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.

The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.

Suggested shape (not a decision — needs triage)

Two readings, and they are not equivalent:

  1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
  2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.

Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.

Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.

Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3

    Type

    Bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
       blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
      Skip to content
      spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
      Open
      Bug
      Open
      spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
      Bug
      Labels
      documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
      Description
      @huangyiirene
      huangyiirene
      opened on Aug 31, 2026
      Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
      The disagreement
      packages/spec/src/automation/approval.zod.ts:
      minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
      packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
      if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
      The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
      The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
      Why it matters
      .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
      The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
      Suggested shape (not a decision — needs triage)
      Two readings, and they are not equivalent:
      1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
      2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
      Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
      Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
      Generated by Claude Code
      Metadata
      Metadata
      Assignees
      No one assigned
        Labels
        documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
        Type
        Bug
        Projects
        No projects
          Milestone
          No milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
          Skip to content
          spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
          Open
          Bug
          Open
          spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
          Bug
          Labels
          documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
          Description
          @huangyiirene
          huangyiirene
          opened on Aug 31, 2026
          Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
          The disagreement
          packages/spec/src/automation/approval.zod.ts:
          minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
          packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
          if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
          The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
          The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
          Why it matters
          .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
          The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
          Suggested shape (not a decision — needs triage)
          Two readings, and they are not equivalent:
          1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
          2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
          Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
          Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
          Generated by Claude Code
          Metadata
          Metadata
          Assignees
          No one assigned
            Labels
            documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
            Type
            Bug
            Projects
            No projects
              Milestone
              No milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
              Skip to content
              spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
              Open
              Bug
              Open
              spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
              Bug
              Labels
              documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
              Description
              @huangyiirene
              huangyiirene
              opened on Aug 31, 2026
              Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
              The disagreement
              packages/spec/src/automation/approval.zod.ts:
              minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
              packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
              if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
              The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
              The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
              Why it matters
              .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
              The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
              Suggested shape (not a decision — needs triage)
              Two readings, and they are not equivalent:
              1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
              2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
              Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
              Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
              Generated by Claude Code
              Metadata
              Metadata
              Assignees
              No one assigned
                Labels
                documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                Type
                Bug
                Projects
                No projects
                  Milestone
                  No milestone
                  Relationships
                  None yet
                  Development
                  No branches or pull requests
                  Issue actions
                  
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
                  Skip to content
                  spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
                  Open
                  Bug
                  Open
                  spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
                  Bug
                  Labels
                  documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                  Description
                  @huangyiirene
                  huangyiirene
                  opened on Aug 31, 2026
                  Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
                  The disagreement
                  packages/spec/src/automation/approval.zod.ts:
                  minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
                  packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
                  if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
                  The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
                  The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
                  Why it matters
                  .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
                  The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
                  Suggested shape (not a decision — needs triage)
                  Two readings, and they are not equivalent:
                  1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
                  2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
                  Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
                  Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
                  Generated by Claude Code
                  Metadata
                  Metadata
                  Assignees
                  No one assigned
                    Labels
                    documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                    Type
                    Bug
                    Projects
                    No projects
                      Milestone
                      No milestone
                      Relationships
                      None yet
                      Development
                      No branches or pull requests
                      Issue actions
                      
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
                      Skip to content
                      spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
                      Open
                      Bug
                      Open
                      spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
                      Bug
                      Labels
                      documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                      Description
                      @huangyiirene
                      huangyiirene
                      opened on Aug 31, 2026
                      Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
                      The disagreement
                      packages/spec/src/automation/approval.zod.ts:
                      minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
                      packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
                      if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
                      The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
                      The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
                      Why it matters
                      .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
                      The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
                      Suggested shape (not a decision — needs triage)
                      Two readings, and they are not equivalent:
                      1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
                      2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
                      Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
                      Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
                      Generated by Claude Code
                      Metadata
                      Metadata
                      Assignees
                      No one assigned
                        Labels
                        documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                        Type
                        Bug
                        Projects
                        No projects
                          Milestone
                          No milestone
                          Relationships
                          None yet
                          Development
                          No branches or pull requests
                          Issue actions
                          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
                          Skip to content
                          spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
                          Open
                          Bug
                          Open
                          spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
                          Bug
                          Labels
                          documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                          Description
                          @huangyiirene
                          huangyiirene
                          opened on Aug 31, 2026
                          Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
                          The disagreement
                          packages/spec/src/automation/approval.zod.ts:
                          minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
                          packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
                          if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
                          The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
                          The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
                          Why it matters
                          .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
                          The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
                          Suggested shape (not a decision — needs triage)
                          Two readings, and they are not equivalent:
                          1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
                          2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
                          Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
                          Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
                          Generated by Claude Code
                          Metadata
                          Metadata
                          Assignees
                          No one assigned
                            Labels
                            documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                            Type
                            Bug
                            Projects
                            No projects
                              Milestone
                              No milestone
                              Relationships
                              None yet
                              Development
                              No branches or pull requests
                              Issue actions
                              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
spec: `ApprovalNodeConfigSchema.minApprovals` describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers · Issue #13809 · objectstack-ai/objectstack · GitHub
                              Skip to content
                              spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers #13809
                              Open
                              Bug
                              Open
                              spec: ApprovalNodeConfigSchema.minApprovals describes "Default 1", but the quorum runtime defaults to ALL resolvable approvers#13809
                              Bug
                              Labels
                              documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                              Description
                              @huangyiirene
                              huangyiirene
                              opened on Aug 31, 2026
                              Filed unassigned by the flight-6 skills sweep (PR #13808, card #13793). Out of that PR's scope — the defect is in packages/spec, not in skills/** — so it is recorded here instead of ridden along.
                              The disagreement
                              packages/spec/src/automation/approval.zod.ts:
                              minApprovals: z.number().int().min(1).optional().describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
                              packages/plugins/plugin-approvals/src/approval-service.ts, isApprovalSatisfied:
                              if(behavior==='quorum'){constn=original.length||1;constneed=Math.min(Math.max(1,config.minApprovals??n),n);// omitted => n, not 1returnapproved.size>=need;}if(behavior==='per_group'){constperGroupNeed=Math.max(1,config.minApprovals??1);// omitted => 1
...
}
                              The same method's own doc comment states the runtime behaviour correctly — "quorum — at least minApprovals distinct approvals (default = all)" — so the two readings sit four lines apart in one file, and the schema's .describe() is the one that disagrees with them both.
                              The key carries no Zod .default(), so nothing materialises a value at parse time and the ??  on each branch is the whole story: the effective default is per behaviour, not a single number.
                              Why it matters
                              .describe() on this surface is not a comment — it lands in the generated reference docs and in the JSON schema published on the Approval action descriptor's configSchema, which is what the Studio property form and registerFlow() config validation are built from. So an author (or an AI author) reading the reference for behavior: 'quorum' is told that omitting minApprovals means one approval, when it actually means every resolvable approver must sign off.
                              The failure is quiet and in the unsafe direction: the node does not error, it simply waits for N approvals instead of 1, and the request looks "stuck" rather than misconfigured. quorum is also the one behaviour minApprovals exists for, so this is the default an author is most likely to lean on.
                              Suggested shape (not a decision — needs triage)
                              Two readings, and they are not equivalent:
                              1. The text is wrong — correct the .describe() to state the per-behaviour default ("omitted: all resolvable approvers under quorum, 1 per group"). Cheapest, changes no behaviour, and makes declared match enforced.
                              2. The runtime is wrong — give the key a real .default(1) so declared and enforced converge on the documented number. This CHANGES approval behaviour for every stored flow that omits the key under quorum (from unanimous-in-effect to first-approval), so it is a semantic migration, not a text fix.
                              Reading 1 is the one this filing recommends: the runtime's ?? n is deliberate (its doc comment names it, and the clamp beside it exists to stop a mis-set value deadlocking a request), so the text is the half that drifted. Reading 2 should not be taken without a maintainer ruling.
                              Related, already handled: the same wrong default had propagated into the published skill and is corrected in PR #13808 (skills/objectstack-automation/SKILL.md, the minApprovals node-config row). That correction is text-only and independent of whichever reading wins here.
                              Generated by Claude Code
                              Metadata
                              Metadata
                              Assignees
                              No one assigned
                                Labels
                                documentationImprovements or additions to documentationdomain:specpm:queuepriority:p2Medium: important, M3
                                Type
                                Bug
                                Projects
                                No projects
                                  Milestone
                                  No milestone
                                  Relationships
                                  None yet
                                  Development
                                  No branches or pull requests
                                  Issue actions