Skip to content

lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

Description

@huangyiirene

Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

What is missing

packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

Section headers in the rule, in order:

711: // ── objects.<name>.…
830: // ── globalActions.<name>
865: // ── apps.<name>[.navigation.<id>]
895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]

and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

Why that is a hole and not a scoping choice

_tabs is a fully live authorable surface, not a planned one:

  • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
  • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
  • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

Suggested fix

Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
      Skip to content

      lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

      Description

      @huangyiirene

      Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

      What is missing

      packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

      Section headers in the rule, in order:

      711: // ── objects.<name>.…
      830: // ── globalActions.<name>
      865: // ── apps.<name>[.navigation.<id>]
      895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
      938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
      

      and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

      Why that is a hole and not a scoping choice

      _tabs is a fully live authorable surface, not a planned one:

      • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
      • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
      • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

      That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

      The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

      Suggested fix

      Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

      Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

      Generated by Claude Code

      Metadata

      Metadata

      Assignees

      No one assigned

        Type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
          Skip to content

          lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

          Description

          @huangyiirene

          Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

          What is missing

          packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

          Section headers in the rule, in order:

          711: // ── objects.<name>.…
          830: // ── globalActions.<name>
          865: // ── apps.<name>[.navigation.<id>]
          895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
          938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
          

          and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

          Why that is a hole and not a scoping choice

          _tabs is a fully live authorable surface, not a planned one:

          • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
          • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
          • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

          That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

          The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

          Suggested fix

          Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

          Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

          Generated by Claude Code

          Metadata

          Metadata

          Assignees

          No one assigned

            Type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
              Skip to content

              lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

              Description

              @huangyiirene

              Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

              What is missing

              packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

              Section headers in the rule, in order:

              711: // ── objects.<name>.…
              830: // ── globalActions.<name>
              865: // ── apps.<name>[.navigation.<id>]
              895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
              938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
              

              and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

              Why that is a hole and not a scoping choice

              _tabs is a fully live authorable surface, not a planned one:

              • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
              • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
              • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

              That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

              The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

              Suggested fix

              Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

              Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

              Generated by Claude Code

              Metadata

              Metadata

              Assignees

              No one assigned

                Type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
                  Skip to content

                  lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

                  Description

                  @huangyiirene

                  Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

                  What is missing

                  packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

                  Section headers in the rule, in order:

                  711: // ── objects.<name>.…
                  830: // ── globalActions.<name>
                  865: // ── apps.<name>[.navigation.<id>]
                  895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
                  938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
                  

                  and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

                  Why that is a hole and not a scoping choice

                  _tabs is a fully live authorable surface, not a planned one:

                  • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
                  • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
                  • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

                  That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

                  The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

                  Suggested fix

                  Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

                  Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

                  Generated by Claude Code

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
                      Skip to content

                      lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

                      Description

                      @huangyiirene

                      Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

                      What is missing

                      packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

                      Section headers in the rule, in order:

                      711: // ── objects.<name>.…
                      830: // ── globalActions.<name>
                      865: // ── apps.<name>[.navigation.<id>]
                      895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
                      938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
                      

                      and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

                      Why that is a hole and not a scoping choice

                      _tabs is a fully live authorable surface, not a planned one:

                      • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
                      • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
                      • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

                      That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

                      The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

                      Suggested fix

                      Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

                      Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

                      Generated by Claude Code

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
                          Skip to content

                          lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

                          Description

                          @huangyiirene

                          Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

                          What is missing

                          packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

                          Section headers in the rule, in order:

                          711: // ── objects.<name>.…
                          830: // ── globalActions.<name>
                          865: // ── apps.<name>[.navigation.<id>]
                          895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
                          938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
                          

                          and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

                          Why that is a hole and not a scoping choice

                          _tabs is a fully live authorable surface, not a planned one:

                          • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
                          • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
                          • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

                          That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

                          The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

                          Suggested fix

                          Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

                          Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

                          Generated by Claude Code

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); lint: `validate-translation-references` has no `_tabs` leg — an authored key naming a filter-preset tab that does not exist warns nobody · Issue #13835 · objectstack-ai/objectstack · GitHub
                              Skip to content

                              lint: validate-translation-references has no _tabs leg — an authored key naming a filter-preset tab that does not exist warns nobody #13835

                              Description

                              @huangyiirene

                              Filed out-of-scope by the flight-⑧ sweep of skills/objectstack-i18n/** (#13815 / #13658) while establishing what translation-target-unknown actually reports. Not fixed there — that PR (#13833) is a documentation-only diff.

                              What is missing

                              packages/lint/src/validate-translation-references.ts walks the object branch of every bundle and reports an orphan key for fields, fields.*.options, _views, _sections, and _actions (plus params). It does not walk _tabs.

                              Section headers in the rule, in order:

                              711: // ── objects.<name>.…
                              830: // ── globalActions.<name>
                              865: // ── apps.<name>[.navigation.<id>]
                              895: // ── dashboards.<name>[.widgets.<id> | .actions.<url>]
                              938: // ── flows.<name>[.screens.<node_id>[.fields.<field_name>]]
                              

                              and inside the object branch the sub-walks are fields / options / _views / _sections / _actions. _tabs appears nowhere in the file.

                              Why that is a hole and not a scoping choice

                              _tabs is a fully live authorable surface, not a planned one:

                              • ObjectTranslationDataSchema declares it (packages/spec/src/system/translation.zod.ts), keyed by ViewTabSchema.name, resolved by resolveTabLabel;
                              • collectExpectedEntries harvests it — measured on a small fixture, objects.task._tabs.urgent.label is emitted (with source: 'view');
                              • so os i18n check already demands a translation for a tab key, while nothing tells an author that a _tabs key they wrote names a tab that no longer exists.

                              That is exactly the asymmetry #11608 identified for flows — "an authored key naming a flow, screen node or field that does not exist warns nobody" — which was accepted and closed by adding the flows leg. _tabs is the same shape, one group over, and was missed because it arrived after the object branch was written.

                              The failure is the quiet one this rule family exists to prevent: rename a filter preset, the bundle keeps its old _tabs key, the tab bar renders in the source locale above a fully localized grid, and every gate stays green.

                              Suggested fix

                              Add a _tabs sub-walk beside _sections in the object branch, reporting translation-target-unknown against the tab names the stack actually declares (page.interfaceConfig.userFilters.tabs[].name, de-duplicated per object the way walkObjectTabs in packages/cli/src/utils/i18n-extract.ts already does). The universe builder that the object branch consumes needs the tab names added alongside views and sections.

                              Also worth checking in the same pass: whether the rule's own coverage of the object branch should be pinned against ObjectTranslationDataSchema's key set, so the next group added to the shape cannot land without a leg here.

                              Generated by Claude Code

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions