skills-sweep ⑨: objectstack-upgrade (696 lines, 1 file) — behavioral-claim verification, content-class execution-first

[huangyiirene]

Member card of program #13658 (published-skills factual sweep). Flight ⑨ target: skills/objectstack-upgrade/** — a single file at origin/main this hour: SKILL.md (696).

Scope: verify every behavioral claim against the implementation per the program method as BOUND by #13658 comments 5474435934 / 5474464789 / 5475032239 + calibrations 5476328676 / 5476875577 / 5477729758 / 5479170359 / 5479891720 (content-class first; both error directions; enumeration-vs-schema-member-set as a standing probe class; "silently / ignored / dropped" seed; spec-.describe()/CLI-help twin rule). Likely implementation homes: packages/spec/src/conversions/** (the ADR-0087 conversion registry — version-to-version migrations are this package's core subject), packages/spec/src/migrations/**, packages/cli upgrade/codemod commands, changesets/release conventions the skill describes. Upgrade docs age fastest by construction — every retired key this program has confirmed (protocol-17 strict-unknown-keys, tombstones, renames) is this skill's raw material, so verify the skill's version claims against the conversion registry's actual entries.

Constraints: published governed surface — draft PR, human merge; ceilings unchanged; net line budget ≤ 0; NOT MEASURABLE recorded. Clause ② CONTENT limb (批 #12): needs:contract-review to PR AND this card same-stroke.

Part of #13658; closes with the flight's PR (Fixes).

Generated by Claude Code

[huangyiirene]

Claim: PM loop round 1
Session: session_01EnE7G31tqbxN1rqpQmzurT
Branch: claude/issue-13840-skills-sweep-upgrade
Worktree: objectstack-issue-13840
Domain: domain:skills
File surface: skills/objectstack-upgrade/** (stop on breach; explain in the report)
Container & model: M, mode:subagent, model: opus — no path-derived mandate on skills/** per this morning's dispatch-gates.mjs --tier posture.
Clause-②: yes — 批 #12 CONTENT-limb criterion; both carriers same-stroke at PR creation; this seat reviews at CONTRACT_REVIEW_TIER at ACCEPT.
Serial constraints cleared: zero open PRs touch skills/objectstack-upgrade/** (listings read this hour); sibling flight ⑩ (#13841, skills/objectstack-ai/**) runs this same wave — disjoint, no read-coupling.

---

Generated by Claude Code

[huangyiirene]

os-dev-report
{
"issue": 13840,
"status": "done",
"branch": "claude/issue-13840-skills-sweep-upgrade",
"pr": "#13861",
"premise_still_valid": true,
"summary": "Flight 9 of the published-skills factual sweep. PM premise re-derived from the fetched tree and HOLDS: skills/objectstack-upgrade is exactly one file, SKILL.md, exactly 696 lines at origin/main. ~150 behavioral claims inventoried, 5 FALSE distinct facts across 5 landing sites (3.3% / 3.3%, inside the 1.5-10% working range, near its floor), ~40 NOT MEASURABLE recorded with reasons. Corrections: (1) manifest.protocol was a phantom with ZERO repo-wide hits outside the skill line and ManifestSchema is not strict, so an author writing it would have it silently dropped; replaced with manifest.engines.protocol, which is declared on PluginEnginesSchema and really is checked at boot by the ADR-0087 D1 handshake (OS_PROTOCOL_INCOMPATIBLE). (2) 'the lower one is the safe --from, the chain is idempotent' is false for the default-flip class and contradicted the file's own 3.3: field-required-notnull-explicit fires on any required:true field with no storage block, which is exactly a protocol-17-authored field, so an understated --from stamps NOT NULL DDL a customer deliberately omitted. (3) mapping.fieldMapping[].transform was presented as a 6-member enum executed row by row; TransformType has SEVEN members - javascript is live and the REST import path rejects it with 400 UNSUPPORTED_TRANSFORM, and lookup is copied through to reference resolution rather than executed. (4) the sharpest: a protocol-17 upgrade skill offered 'an ETL transformation step' as a v17 home for a surface RETIRED IN 17 (#6414 retired the whole L2 ETL layer as executor-less; zero ETL* exports today; all nine defs in RETIRED_DEFS_BY_MAJOR[17]); replaced with the CHANGELOG's own FROM-TO answer, and the prescription names ONE live target, not two. (5) the 3.5 worked rejection quoted the WITHDRAWN 'rewrite it automatically' sentence - matched verbatim by the spec's own WITHDRAWN_CLAIM pin regex, which never fired because that pin's markdown corpus is one hard-coded internal path; it also contradicted the file's own 1 headline. Two trims inside the same 2.3 passage pay for the additions. Governed surface: PR is DRAFT for human merge, never armed or queued. needs:contract-review attached to the PR AND to card #13840 same-stroke, not self-cleared; skip-changeset verified (single skills/** markdown file, publishes nothing). Net -3 lines, token-neutral at a ceiling whose headroom was 0. Zero out-of-list changes; diff is 15 insertions / 18 deletions in one file.",
"tests": "All measurements at final commit 414cbd3, clean tree; exit codes captured BEFORE any pipe. BUILD: 'pnpm --filter @objectstack/spec^... build && pnpm --filter @objectstack/spec build' via scripts/pm/os-verify-lock.sh -> 'VERDICT command-exit 0 - held the lock 114s'; probes import the built dist/, not src. GATES: 14 families derived from the REAL diff by 'node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack' (script read its own change set from the merge base). 13 runnable families re-run at 414cbd3, ALL exit 0: check:agent-test-spelling 0, check:corpus-claim-drift 0, check:cross-package-test-inputs 0, check:doc-authoring 0, check:doc-formula-expressions 0, check:pm-governed-merges 0, check:role-word 0, check:skill-compatibility 0, check:skill-frame-sync 0, check-ci-filter-parity 0, check-cross-package-test-inputs 0, check-shard-attestation 0, check-skills-token-ratchet 0; plus check-nul-bytes 0 (standing rule) and a self-scan for control bytes over the edited file = clean. Ratchet judgment line: 'skills/objectstack-upgrade/SKILL.md is 8333 tokens (ceiling 8333; headroom 0)' - token-neutral, ceiling untouched. TWO NOT-MEASURED, read from each gate's own text, not from a bare exit code: check-test-completeness exits 3 printing 'the local reading for this gate is NOT MEASURED ... It is not a red' (it grades a saved turbo test log the derived family gives it no argument for); check:doc-formula-expressions first exited 1 with 'PREREQUISITE NOT MET ... Nothing was measured ... It is NOT a finding' because @objectstack/formula and @objectstack/lint were unbuilt in a fresh worktree - both built under the lock, then it ran and passed, and that pass is the 0 above. NON-VACUITY CONTROL (executed, not read): PROBE 3 settled the file's headline 3.3 claim by PARSING rather than grepping - of 58 major-17 conversions, 46 are retiredFromLoadPath, and driving each entry's own fixture.before through ObjectStackDefinitionSchema.safeParse leaves EXACTLY ONE whose old shape still parses green: field-required-notnull-explicit. The claim is true, and true for the right reason. PROBE 4 executed that same conversion: applyMetaMigrations(16,17) emitted {conversionId: field-required-notnull-explicit, from: 'required: true (implied NOT NULL)', to: 'storage.notNull: true', path: objects[0].fields.name.storage.notNull}, the field became {type:text,label:Name,required:true,storage:{notNull:true}}, and the PRE-migration source parsed green - confirming both halves of 3.3 (validate green while the chain still has work) and demonstrating correction 2's hazard in one run. PROBE 5 parsed a connector carrying the retired transform: code invalid_type, expected 'never', path connectors.0.fieldMappings.0.transform, message = the real tombstone ending '...to list the mechanical edits for existing sources; apply them by hand' - confirming the sample's SHAPE as VERIFIED and its ending as FALSE. PROBE 6: TransformType options are exactly [none, constant, lookup, split, join, javascript, map] (7, not 6). The skill's own refresh command was run VERBATIM and works unmodified: '17.0.0 floor 10 | 16->17: 58 converted, 77 semantic'. The chain was also executed end to end on a protocol-16 source, confirming the two renames the os:check block teaches (conditionalRequired -> requiredWhen value-unchanged; agent.tools dropped in favour of skills). PIN SECTION: the 'as of 17.0.0-rc.5' readings were re-measured at 17.2.0 (45->58 conversions, 29->77 semantic, 113/32 files -> 179/44 tombstones, 96->145 distinct [REMOVED]; floor still 10, PROTOCOL_VERSION still 17.0.0) and deliberately LEFT UNEDITED - the section is a bounded snapshot with a stated 'the install wins' tie-break, so growth is its design, not a falsehood; re-pinning is a maintainer call. One nuance recorded there rather than corrected: RETIRED_KEYS_BY_MAJOR[17] no longer holds data/ExternalFieldMapping:transform (#8075 subsumed it into a def retirement) - a REMOVAL, the one direction the pin's contract does not describe, but correct at rc.5 since that landed in 17.0.0 GA. CHANNEL: repo-scoped REST is 403 for this seat ('GitHub access is not enabled for this session') and gh is absent, so card and program reads went through the zero-quota payload channel and all writes through MCP; the #13658 comment tail (the binding method comments) needed one MCP get_comments, as the dispatch anticipated. Dedupe ran a positive control FIRST (returned #13658 as expected) before the one targeted search. Both label carriers were union-written and compare-read-back: card #13840 reads all five labels including needs:contract-review, PR #13861 reads size/s + skip-changeset + needs:contract-review + documentation (the auto-labeler's later addition; nothing of mine stripped). PR body was fully re-read from the rendered page and survived intact end to end, footer and session URL included.",
"mcp_calls": "9 - issue_read get_comments (the #13658 tail), search_issues x2 (positive control, then one targeted dedupe), issue_write create x2 (#13859, #13860), create_pull_request, issue_write update x2 (PR labels, card labels). This report comment is the 9th. All single-card and program reads went through the zero-quota payload channel.",
"open_questions": [],
"out_of_scope_findings": [
"filed as #13859: the retired-key migrate-sentence pin scans ONE hard-coded markdown file (.claude/skills/spec-property-retirement/SKILL.md), so the withdrawn 'rewrite it automatically' claim reached the PUBLISHED catalog with every gate green - proposes widening the corpus to skills/**; sibling of #13678, same 'the corpus grew, the gate's population did not' shape",
"filed as #13860: 'which protocol major was this authored against?' has no declared home - validate, doctor and compile all advise off manifest.specVersion, which the stack ManifestSchema does not declare (it lives only on the cloud template manifest), so the advisory is unreachable for stack configs; carries a four-axis analysis and recommends retiring the read in favour of the already-declared, already-enforced engines.protocol. NEEDS A MAINTAINER DECISION - distinct from #9264, which paid down the template side"
]
}

---

Generated by Claude Code