Skip to content

[finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

Description

@claude

Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

The dead premise

The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

SiteQuote (verbatim)Note
packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

Deliberately NOT on this list

Two sites already read correctly and must not be "fixed":

  • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
  • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

Why it is worth a card

The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

Suggested shape

One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


Generated by Claude Code

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
     blocks
    (function() {
    function addCopyButtons() {
    document.querySelectorAll('pre code').forEach(function(codeBlock) {
    if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
    codeBlock.parentElement.setAttribute('data-copy-added', 'true');
    var btn = document.createElement('button');
    btn.textContent = 'Copy';
    btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
    btn.onmouseover = function() { this.style.opacity = '1'; };
    btn.onmouseout = function() { this.style.opacity = '0.7'; };
    btn.onclick = function() {
    navigator.clipboard.writeText(codeBlock.textContent).then(function() {
    btn.textContent = 'Copied!';
    setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
    });
    };
    codeBlock.parentElement.style.position = 'relative';
    codeBlock.parentElement.appendChild(btn);
    });
    }
    addCopyButtons();
    // Re-run on dynamic content
    var observer = new MutationObserver(addCopyButtons);
    observer.observe(document.body, { childList: true, subtree: true });
    })();
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
    Skip to content

    [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

    Description

    @claude

    Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

    The dead premise

    The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

    Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

    SiteQuote (verbatim)Note
    packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
    packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
    packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
    packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
    packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
    packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
    packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

    Deliberately NOT on this list

    Two sites already read correctly and must not be "fixed":

    • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
    • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

    That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

    Why it is worth a card

    The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

    Suggested shape

    One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

    Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


    Generated by Claude Code

    Metadata

    Metadata

    Assignees

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
      Skip to content

      [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

      Description

      @claude

      Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

      The dead premise

      The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

      Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

      SiteQuote (verbatim)Note
      packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
      packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
      packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
      packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
      packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
      packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
      packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

      Deliberately NOT on this list

      Two sites already read correctly and must not be "fixed":

      • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
      • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

      That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

      Why it is worth a card

      The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

      Suggested shape

      One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

      Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


      Generated by Claude Code

      Metadata

      Metadata

      Assignees

      Type

      No type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
        Skip to content

        [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

        Description

        @claude

        Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

        The dead premise

        The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

        Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

        SiteQuote (verbatim)Note
        packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
        packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
        packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
        packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
        packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
        packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
        packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

        Deliberately NOT on this list

        Two sites already read correctly and must not be "fixed":

        • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
        • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

        That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

        Why it is worth a card

        The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

        Suggested shape

        One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

        Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


        Generated by Claude Code

        Metadata

        Metadata

        Assignees

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
          Skip to content

          [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

          Description

          @claude

          Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

          The dead premise

          The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

          Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

          SiteQuote (verbatim)Note
          packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
          packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
          packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
          packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
          packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
          packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
          packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

          Deliberately NOT on this list

          Two sites already read correctly and must not be "fixed":

          • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
          • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

          That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

          Why it is worth a card

          The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

          Suggested shape

          One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

          Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


          Generated by Claude Code

          Metadata

          Metadata

          Assignees

          Type

          No type

          Projects

          No projects

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
            Skip to content

            [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

            Description

            @claude

            Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

            The dead premise

            The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

            Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

            SiteQuote (verbatim)Note
            packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
            packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
            packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
            packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
            packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
            packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
            packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

            Deliberately NOT on this list

            Two sites already read correctly and must not be "fixed":

            • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
            • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

            That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

            Why it is worth a card

            The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

            Suggested shape

            One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

            Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


            Generated by Claude Code

            Metadata

            Metadata

            Assignees

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
              Skip to content

              [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

              Description

              @claude

              Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

              The dead premise

              The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

              Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

              SiteQuote (verbatim)Note
              packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
              packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
              packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
              packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
              packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
              packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
              packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

              Deliberately NOT on this list

              Two sites already read correctly and must not be "fixed":

              • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
              • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

              That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

              Why it is worth a card

              The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

              Suggested shape

              One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

              Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


              Generated by Claude Code

              Metadata

              Metadata

              Assignees

              Type

              No type

              Projects

              No projects

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations · Issue #13903 · objectstack-ai/objectstack · GitHub
                Skip to content

                [finding] The retired platform-admin elevation gate is still named in the present tense at ~6 more comment sites — one ships in the @objectstack/types declarations #13903

                Description

                @claude

                Found while implementing #13661 (which corrects four sites in two files). Comment-only drift, no runtime defect — but the same dead premise survives at roughly six more sites the card did not scope, and one of them ships in a package's type declarations.

                The dead premise

                The #11663 platform-admin re-anchor (legs L2 and L4, both landed) retired the walled platform-admin elevation gate. Under a walled posture bootstrapPlatformAdmin writes no grant row and elevates nobody — it reports. Standing is derived per request at resolve-authz-context.ts §6b-config, from a config-anchored verified email or the legacy unscoped grant row.

                Comments that still name "the elevation gate" in the present tense therefore point a reader at a mechanism that no longer exists. Measured on origin/main at 46b53a25b:

                SiteQuote (verbatim)Note
                packages/types/src/env.ts:169"the walled boot guard in plugin-auth, the elevation refusal in plugin-security's bootstrapPlatformAdmin"Docblock over the exportedPLATFORM_OWNER_EMAIL_ENV, so it ships in @objectstack/types.d.ts — the same reason #13661 singled out email-verified.ts
                packages/core/src/security/platform-admin.ts:117"the elevation gate's by-email sys_user lookup queries the verbatim spelling alongside the normalized one"The two-spelling lookup is real, but it now lives in resolvePlatformAdminStanding; the referent moved, the name did not
                packages/core/src/security/platform-admin.ts:287"the elevation gate (plugin-security/bootstrap-platform-admin.ts) must keep the two halves SEPARATE"⚠️ Only the NAME is stale here. bootstrap-platform-admin.ts still emits walled_owner_not_registered / walled_owner_not_verified as separate answers, so the reasoning is correct and must survive the rename
                packages/plugins/plugin-security/src/platform-owner-wall-bypass.ts:37-39"walled-owner-operator-stamp.ts (plugin-auth) and the elevation gate ask the same parser for the same reason. The sites MUST agree — an account the stamp verifies is one the gate must elevate and the wall must recognise.""the gate must elevate" describes an action nothing performs any more
                packages/plugins/plugin-security/src/security-plugin.ts:5822"the canonical declared-owner email match (the elevation gate's twin, platform-owner-wall-bypass.ts)""the twin" of a retired thing
                packages/plugins/plugin-auth/src/last-admin-guard.test.ts:1613"deleting it — or calling it something else — un-makes every platform admin in one write"The same sentence #13661 corrects in the source file, restated in the test file's section header. False for a config-anchored administrator
                packages/plugins/plugin-auth/src/walled-owner-operator-stamp.test.ts (lines 11, 15, 23, 24, 91, 257, 395, 443)e.g. "a green here IS 'the elevation gate would accept this'"One test docblock family; the assertions are unaffected, the stated justification is not

                Deliberately NOT on this list

                Two sites already read correctly and must not be "fixed":

                • packages/plugins/plugin-security/src/platform-admin-service.ts:21 — "The standing answer mirrors the DERIVATION, not the retired elevation gate".
                • packages/plugins/plugin-security/src/platform-admin-service.ts:99 — "the same two-spelling discipline the elevation gate used" (past tense).

                That split is the point of filing this rather than a blanket search-and-replace: some of these comments are wrong about the mechanism, some are only wrong about the name, and two are already right.

                Why it is worth a card

                The env.ts site ships in the types package declarations, which is the argument #13661 accepted for email-verified.ts. The rest steer the next author of the platform-admin surface, and #13661 has already demonstrated that a stale reason is the thing a reader reaches for when deciding whether a guard key can be dropped.

                Suggested shape

                One comment-only PR, no behaviour, verified the same way #13661 was: a non-comment diff that is empty, and a throw census identical before and after. Not urgent; a good rider for whichever leg next edits platform-admin.ts or plugin-security.

                Same dead premise as #13661. Context: #11663 (design), #11970 (L2), #11974 (L4).


                Generated by Claude Code

                Metadata

                Metadata

                Assignees

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions