Skip to content

[finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

Description

@claude

Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

The reading

.github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

But none of its 73 assertions read the guidance prose. They read:

  • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
  • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

Why it is worth a card

Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

Shape of a remedy (not a decision, just the cheap end)

A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

Evidence

  • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
  • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
  • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
      Skip to content

      [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

      Description

      @claude

      Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

      The reading

      .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

      scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

      But none of its 73 assertions read the guidance prose. They read:

      • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
      • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

      Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

      Why it is worth a card

      Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

      That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

      Shape of a remedy (not a decision, just the cheap end)

      A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

      ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

      Evidence

      • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
      • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
      • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

      Generated by Claude Code

      Metadata

      Metadata

      Assignees

      No one assigned

        Type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
          Skip to content

          [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

          Description

          @claude

          Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

          The reading

          .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

          scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

          But none of its 73 assertions read the guidance prose. They read:

          • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
          • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

          Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

          Why it is worth a card

          Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

          That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

          Shape of a remedy (not a decision, just the cheap end)

          A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

          ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

          Evidence

          • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
          • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
          • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

          Generated by Claude Code

          Metadata

          Metadata

          Assignees

          No one assigned

            Type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
              Skip to content

              [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

              Description

              @claude

              Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

              The reading

              .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

              scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

              But none of its 73 assertions read the guidance prose. They read:

              • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
              • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

              Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

              Why it is worth a card

              Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

              That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

              Shape of a remedy (not a decision, just the cheap end)

              A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

              ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

              Evidence

              • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
              • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
              • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

              Generated by Claude Code

              Metadata

              Metadata

              Assignees

              No one assigned

                Type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
                  Skip to content

                  [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

                  Description

                  @claude

                  Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

                  The reading

                  .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

                  scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

                  But none of its 73 assertions read the guidance prose. They read:

                  • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
                  • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

                  Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

                  Why it is worth a card

                  Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

                  That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

                  Shape of a remedy (not a decision, just the cheap end)

                  A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

                  ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

                  Evidence

                  • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
                  • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
                  • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

                  Generated by Claude Code

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
                      Skip to content

                      [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

                      Description

                      @claude

                      Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

                      The reading

                      .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

                      scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

                      But none of its 73 assertions read the guidance prose. They read:

                      • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
                      • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

                      Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

                      Why it is worth a card

                      Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

                      That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

                      Shape of a remedy (not a decision, just the cheap end)

                      A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

                      ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

                      Evidence

                      • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
                      • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
                      • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

                      Generated by Claude Code

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
                          Skip to content

                          [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

                          Description

                          @claude

                          Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

                          The reading

                          .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

                          scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

                          But none of its 73 assertions read the guidance prose. They read:

                          • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
                          • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

                          Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

                          Why it is worth a card

                          Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

                          That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

                          Shape of a remedy (not a decision, just the cheap end)

                          A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

                          ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

                          Evidence

                          • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
                          • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
                          • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

                          Generated by Claude Code

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation · Issue #13967 · objectstack-ai/objectstack · GitHub
                              Skip to content

                              [finding] The merge-queue triage comment's operative guidance prose is unpinned — its own gate suite reads only the excerpt and the aggregation #13967

                              Description

                              @claude

                              Found while adding a paragraph to the merge-queue triage guidance (PR #13966, card #13830). Not that card's defect class, so it was left alone and recorded here.

                              The reading

                              .github/workflows/merge-queue-triage.yml composes the triage comment it posts on every red merge_group build. Two of the lines in that body array are the operative guidance — the timeout-vs-assertion heuristic the triage checklist turns on, and (as of PR #13966) the named exception beside it.

                              scripts/check-merge-queue-triage-outcome.mjs is a serious pin suite for this workflow: it extracts the shipped script with a real YAML parser, drives it against real captured vitest logs under doubles, and its --self-test mutates that shipped script 17 ways and requires the battery to go red for each. It is not decoration.

                              But none of its 73 assertions read the guidance prose. They read:

                              • the fenced excerpt lines, via a helper (excerptLines) that is deliberately scoped to code-fence content — its own docblock says why: "the comment's own explanatory prose names both FAIL and AssertionError, so a grep would let the static text satisfy assertions about the EXTRACTION." That scoping is correct for what it protects; the side effect is that no assertion can see the prose at all.
                              • the anchor notes, the sighting markers, the anti-no-op announcements, the delivery/summary limbs.

                              Grepping the gate for the guidance text (判读的关键, 负载/时序, 行为改变) returns nothing.

                              Why it is worth a card

                              Delete both guidance lines from the body array and every gate in the derived family stays green — measured on the union for a change to this file: 19 families, all green, and the pin suite's own verdict line reports only assertion and scenario counts over extraction and aggregation.

                              That is the shape the repo already treats as a defect elsewhere: a surface whose correctness is asserted in prose that nothing reads back. The prose here is not commentary — the triage checklist is the whole point of the workflow (its header calls the comment "the machine-readable signal the PM dispatch loop can key on"), and the heuristic is the line that decides whether an author investigates or re-queues.

                              Shape of a remedy (not a decision, just the cheap end)

                              A prose assertion in the pin suite would have to read the whole posted body, not excerptLines — which is exactly the coupling that helper exists to prevent, so it needs its own accessor and a comment saying which question it answers. One assertion per operative claim (the rule; the named exception; the boundary sentence that the re-queue allowance is governed elsewhere) is probably the right granularity: enough that a silent deletion goes red, few enough that a rewording does not.

                              ⚠️ Worth weighing against the opposite failure: a prose pin that quotes too much turns every wording improvement into a two-file edit, and that is how pins rot into copy-paste. The judgment call is which claims are load-bearing, and that is why this is a finding rather than a patch.

                              Evidence

                              • .github/workflows/merge-queue-triage.yml — the guidance lines in the body array.
                              • scripts/check-merge-queue-triage-outcome.mjsexcerptLines and its docblock; no assertion over postedBody prose.
                              • .github/workflows/lint.yml — the Merge-queue triage outcome contract step, whose own comment enumerates what the suite holds: the excerpt naming the failure reason, and the cross-PR aggregation. Guidance prose is not on that list, so this is a gap in coverage rather than a claim the suite makes and misses.

                              Generated by Claude Code

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions