Follow-up disclosed in #14042 (the #13330 fix), filed as promised there. This is a coverage gap the author disclosed, not a defect: the at-tier contract review on #14042 judged it non-blocking on merits, but required the promised follow-up to exist as an issue.
What is untested
No test boots serve and asserts the four cluster-driver diagnosis branches added by #14042 (packages/cli/src/commands/serve.ts, the cluster block in the boot method):
- registered — driver loaded and visible in the registry: silent (no diagnosis printed);
- loaded-but-invisible — the driver evaluated without error but the registry this boot reads does not hold it (a physical-copy split): warns, naming the split and the one-line config remedy;
- not-resolvable — prints the
undeclared / declared-unresolvable classification from createHostImporter that the old silent catch swallowed; - resolved-then-crashed — the driver package's own evaluation error is printed instead of being reported as "not registered".
There is also a fifth, deliberately silent case — an app on an older @objectstack/service-cluster with no listClusterDrivers accessor prints nothing (declines to claim either answer) — which is equally unasserted at boot level.
Why it is untested
The reading sits inline in a very long boot method, so there is no seam to drive the branches through without booting the whole of serve.
Compensating coverage (why this is p3, not a defect)
The risk the gap leaves open is the one the review named: silent-print branches are the exact shape that regresses invisibly.
Done means
A test (or tests) that boots serve (or extracts the reading into a testable seam first) and asserts each diagnosis branch fires on its condition — including that the registered case and the older-service-cluster case stay silent.
Refs: #14042, #13330.
Follow-up disclosed in #14042 (the #13330 fix), filed as promised there. This is a coverage gap the author disclosed, not a defect: the at-tier contract review on #14042 judged it non-blocking on merits, but required the promised follow-up to exist as an issue.
What is untested
No test boots
serveand asserts the four cluster-driver diagnosis branches added by #14042 (packages/cli/src/commands/serve.ts, the cluster block in the boot method):undeclared/declared-unresolvableclassification fromcreateHostImporterthat the old silentcatchswallowed;There is also a fifth, deliberately silent case — an app on an older
@objectstack/service-clusterwith nolistClusterDriversaccessor prints nothing (declines to claim either answer) — which is equally unasserted at boot level.Why it is untested
The reading sits inline in a very long boot method, so there is no seam to drive the branches through without booting the whole of
serve.Compensating coverage (why this is p3, not a defect)
serve-cluster-host-resolutionsource scan pins the shape of the block (32 tests);listClusterDrivers()agreeing withdefineCluster()— is pinned in both directions inpackages/services/service-cluster/src/cluster-driver-registry.test.ts(suite 70/70 at fix(types,cli): resolve host-declared packages through theimportcondition, and read the cluster registry instead of assuming it #14042 head);importcondition, and read the cluster registry instead of assuming it #14042 review (an absent driver still reachesdefineCluster()'s documented error).The risk the gap leaves open is the one the review named: silent-print branches are the exact shape that regresses invisibly.
Done means
A test (or tests) that boots
serve(or extracts the reading into a testable seam first) and asserts each diagnosis branch fires on its condition — including that the registered case and the older-service-clustercase stay silent.Refs: #14042, #13330.