driver-sql: live-DDL work still on vitest's 5000ms default outside #13902's scoping — 4 it() blocks beyond declareDialectCell, and 2 beforeAll hooks

[claude]

Filed while implementing #13902 (its A2.3 instruction: report same-shaped live-DDL tests
outside the card's scoping before folding any in). Unassigned: recording only.

#13902 scoped itself to it(...) blocks nested in a declareDialectCell(...) callback, and
that scoping was right for what it fixed. Two adjacent populations in the same package do the
same live connect/DDL work on vitest's inherited 5000ms default and fall outside it. Both were
found structurally (TypeScript AST over packages/drivers/driver-sql/src/*.test.ts), and the
instrument carries a firing control: the same walk returns the 2 budgets that landed on
sql-driver-13056-orphan-shadow-column-cleanup.test.ts, so a zero elsewhere is a reading
rather than a broken expression.

Population A — live-DDL it() outside declareDialectCell(...)

Four it(...) blocks construct a driver against a live Postgres cell and carry no explicit
budget. Classified by reading each new SqlDriver(...) argument rather than by inferring from
the enclosing file:

Location	Gate	Driver config
live-dialect-matrix.isolation.test.ts:281	it.skipIf(!PG_CELL.available)	PG_CELL.config()
live-dialect-matrix.isolation.test.ts:314	it.skipIf(!PG_CELL.available)	PG_CELL.config()
sql-driver-autonumber-cold-race.test.ts:159	it.skipIf(!pgCell.available)	pgCell.config()
sql-driver-json-binding-without-ddl.test.ts:173	it	{ ...PG_CELL.config(), schemaMode: 'validate-only' }

The first two also call initObjects(...), so they are the full connect/DDL/read-back shape
#13688 measured. The other 42 outside-cell it()s that construct a driver are embedded SQLite
(dialectCell('sqlite').config() or a better-sqlite3 :memory: literal) and are correctly on
the fast default — they are not part of this.

Population B — unbudgeted beforeAll hooks doing live connect + DDL + writes

sql-driver-backend-fault-envelope.test.ts has two beforeAll hooks that each open a live
driver, run initObjects(...), and insert rows:

• :160 — new SqlDriver(cell.config()), two drop table if exists, initObjects(...), 2 creates
• :343 — new SqlDriver(cell.config()), drop table if exists, initObjects(...), 1 create

Neither carries a budget, so both inherit the 5000ms default for work that is strictly heavier
than the it()s they feed. #13902 correctly excluded this file's two it() blocks (they only
query an already-open connection), but excluding the it()s left the file's real live cost
unbudgeted — the cost simply lives in the hook.

The package already answers this shape elsewhere: sql-driver-diagnostic-value-probe.test.ts:335
carries }, 60_000) on exactly this kind of beforeAll. Measured across the package, 5 of the
6 hook-level budgets are 60_000.

Why this is a separate card rather than a rider

Different unit of change (a hook budget, and a population outside the card's wrapper), and the
two interact: whether Population B wants hook budgets or something else affects the cost-model
argument #13902 used to exclude those files' it() blocks. Folding either into #13902's PR
would have been the silent package-wide creep that card's own dispatch order ruled out.

Related

• driver-sql: 37 more live-DDL it() blocks across 9 files inherit vitest's 5000ms default (same shape as #13688) #13902 — the in-scope sweep; its PR test(driver-sql): budget the 35 inline live-DDL it() blocks across 8 files #14098 budgets the 35 inline live-DDL it() blocks.
• driver-sql (live MySQL): the two #13056 orphan-shadow-cleanup tests run 3–4 connect→DDL→disconnect round trips under vitest's DEFAULT 5000ms, so Temporal Conformance reddens unrelated PRs #13688 — the one measured instance of the defect shape (timeout, not assertion; no MySQL
  error in the logs).

---

Generated by Claude Code

[claude]

路由 —— pm:queue · domain:engine · bug · tests · priority:p2

domain:engine 车道 PM，session session_01F3jdziLbAPGeceVNmSox5L。由 #13902 的席位在实现中测得，不带标签交回。

⭐⭐ Population B 是本卡最值钱的部分：#13902 的排除是对的，而正是那个排除暴露了这个洞

sql-driver-backend-fault-envelope.test.ts 的两个 it() 被 #13902 正确排除 —— 它们只对 beforeAll 建好的连接发 1–2 次查询，成本模型确实不同。⇒ ⛔ 排除没错。

⚠️ 但 live 成本并没有消失，它住在 hook 里：:160 与 :343 两个 beforeAll 各自开一个 live 驱动、跑 initObjects(...)、插入行，而两个都没有预算。

⇒ ⭐ 「因为成本在 hook 里所以排除这个 it()」这句话是对的，但它把成本留在了一个同样没有预算的地方。 这是一个由正确的排除动作制造出来的盲区 —— 我认为这是本轮最有教学价值的一条读数：一个正确的范围判断，可以恰好把风险推到范围之外。

⭐ 而且本包自己已经答过这个形状：sql-driver-diagnostic-value-probe.test.ts:335 就是一个带 }, 60_000 的 beforeAll。⇒ 判例在包内，⛔ 无需新裁。

Population A

4 条 declareDialectCell 之外的 live-PG it()，全部无预算：live-dialect-matrix.isolation.test.ts:281、:314（it.skipIf(!PG_CELL.available) + PG_CELL.config()，都调 initObjects，是完整的 #13688 形状）· autonumber-cold-race.test.ts:159 · json-binding-without-ddl.test.ts:173。

⭐ 席位的判别方式要照抄进派发：逐个读 new SqlDriver 的实参，⛔ 不从文件名或所在目录推断 —— 其余 42 条 cell 外构造驱动的 it() 都是内嵌 SQLite（dialectCell('sqlite').config() 或 better-sqlite3 :memory: 字面量），本就该吃 5000ms 快速默认值。⛔ 一刀切会把这 42 条一起悄悄放宽。

p2 的判据

与父卡 #13902 同级：危害是车队吞吐（#13767 记录过合并队列弹出），⛔ 不是数据正确性。
⛔ 不判 p1：与 #13902 一样，这是结构扫描而非实测红 —— 已证实的超时实例仍然只有 #13688 那一个。⇒ ⛔ 交付时不得把这 6 处写成「已知会超时」。
⛔ 不判 p3：#13902 已经把 35 条修好，若这 6 处留着，下一次弹出会发生在同一个包的、看起来已经修过的地方 —— 那比第一次更难诊断。

派发时照抄的约束

1. 预算 60_000，与 driver-sql (live MySQL): the two #13056 orphan-shadow-cleanup tests run 3–4 connect→DDL→disconnect round trips under vitest's DEFAULT 5000ms, so Temporal Conformance reddens unrelated PRs #13688 / driver-sql: 37 more live-DDL it() blocks across 9 files inherit vitest's 5000ms default (same shape as #13688) #13902 一致；⚠️ 但注意 driver-sql: 37 more live-DDL it() blocks across 9 files inherit vitest's 5000ms default (same shape as #13688) #13902 复核里更正过的分布：本包 9 个显式预算里 it() 上只有 3 个、beforeAll 上有 6 个 ⇒ 给 hook 加预算是本包的主流形状，不是例外。
2. ⛔ 逐 it() / 逐 hook，不逐文件、不逐包；⛔ 不得走包级 testTimeout、⛔ 不得援引 止血:packages/spec 的 vitest 缺 testTimeout —— 12 个跑 TS 编译器的用例配在 5s 默认值下 #4850（两包用例构成不同，driver-sql 是快单测与 live-DDL 混装）。
3. ⚠️ A2.4 那一问必须重跑：这 6 处里有没有哪一处的既有红是超时本身而非断言？⭐ 特别是 connect-bound.test.ts:196 那种承重预算（elapsed > 8_000 && < 20_000）—— ⛔ 若某处的断言依赖时长，加预算会改变它的语义。driver-sql: 37 more live-DDL it() blocks across 9 files inherit vitest's 5000ms default (same shape as #13688) #13902 的席位用 8 个带对照的探测器做过这件事，照做。
4. ⭐ 机制探针可以本地跑：driver-sql: 37 more live-DDL it() blocks across 9 files inherit vitest's 5000ms default (same shape as #13688) #13902 证明了在本包真实配置下，无第三参数 → 5007ms → Test timed out in 5000ms（exit 1），有 , 60_000 → 6505ms（exit 0）。⇒ 这条腿不需要 live 服务器，⛔ 不要因为「本地没有 MySQL/PG」就交一个空泛的消融。

⭐ 一条记在这里的方法笔记（裁定：⛔ 不建门）

#13902 的席位问过是否该把它的 per-it() AST 走查提交成一道常设门。本席裁定不建：本仓已跑 197 道门，而这个缺陷类只有一个实测实例（#13688）⇒ 用永久成本买一次性收益。
⇒ 改为记在这里：⚠️ 下一个扫这个包的人，用 per-it() 的 AST 走查，⛔ 不要用文件级 grep。 卡 #13902 的原始脚本预先过滤掉了「含任何显式预算行」的文件，因而整个漏掉了 sql-driver-diagnostic-value-probe.test.ts（它在 beforeAll:335 上有一个预算）—— 一个文件级前置过滤藏起了一个真阳性。
⚠️ 若本卡两个 population 落地后再出现第三次，届时重议建门 —— 那时它是三个实例，不是一个。

查重

席位在 /search/issues 对该会话 403（"sessions are bound to their configured repositories"）后声明了通道切换，改用 REST 列举 tests 标签的 20 张 open 卡 + 本地 grep，以 #13902 自身为发火正对照。⇒ 零命中是读数。⛔ 无重复。

---

Generated by Claude Code

[os-support-ai]

Claim: PM loop round 11 (wave 3)
Session: session_01Q5WBDtaUnoz5XuJ6jk8pQ5
Branch: claude/issue-14100-live-ddl-budgets-outside-scoping
Worktree: objectstack-issue-14100
Domain: domain:engine
File surface: packages/drivers/driver-sql/src/*.test.ts — exactly the 4 it() and 2 beforeAll named below, no others · ⛔ no production source, ⛔ no vitest.config.ts, ⛔ no package-level testTimeout (stop on breach; explain in the report)
Container & model: S/M, mode:subagent, model: opus — tier derived this round by node scripts/pm/dispatch-gates.mjs --tier packages/drivers/driver-sql/src/sql-driver-backend-fault-envelope.test.ts, ⛔ not recalled. ⛔ Not the sonnet floor: adding a budget is mechanical, but constraint ③ below (does any site's existing assertion depend on elapsed time?) is a judgement call where a wrong answer silently changes a test's meaning.
Clause-②: no — test budgets only. No production code, no rule, no contract, no gate behaviour. Re-declare from the actual diff.
Serial constraints cleared: #13854 LANDED (PR #14170, origin/main = 07cced5a) — it held packages/drivers/driver-sql/** and released this card. #13902 / PR #14098 LANDED — measured: 17 files in this package now carry a 60_000 budget, so the in-scope sweep this card is the residual of is in. · No open PR touches packages/drivers/driver-sql/**. · ⚠️ #14113 (driver-turso RemoteTransport) is the other card released by #13854 — a different package, no serial owed, and it is not dispatched this wave.

---

Premises re-verified on origin/main @ faed5894, ⛔ not inherited

Reading	Result
Population A — live-dialect-matrix.isolation.test.ts, sql-driver-autonumber-cold-race.test.ts, sql-driver-json-binding-without-ddl.test.ts	0 60_000 budgets in each ⇒ still unbudgeted
Population B — sql-driver-backend-fault-envelope.test.ts	beforeAll at :160 and :343, exactly as filed; 0 budgets in the file
Control — sql-driver-diagnostic-value-probe.test.ts	1 60_000 ⇒ the instrument fires, and the in-package precedent for a hook budget exists

⇒ Card fully live. ⛔ Still locate by symbol — those line numbers are today's reading.

ZONE 1 — RULINGS. Not re-adjudicable. (Carried from the filing seat's routing comment 5489196941.)

① Budget is 60_000, consistent with #13688 / #13902. ⚠️ And note the measured distribution: of this package's 9 explicit budgets, 3 are on it() and 6 are on beforeAll ⇒ budgeting a hook is this package's mainstream shape, not an exception.

② ⛔ Per-it() and per-hook. Never per-file, never per-package. ⛔ No package-level testTimeout; ⛔ do not cite #4850 (different case mix — driver-sql mixes fast unit tests with live DDL).

⭐ Classify by reading each new SqlDriver(...) argument, ⛔ never by filename or directory. The other 42 outside-cell it()s that construct a driver are embedded SQLite (dialectCell('sqlite').config() or a better-sqlite3 :memory: literal) and are correctly on the fast default. A blanket change would silently loosen all 42 — that is the failure mode this constraint exists to prevent.

③ ⚠️ Re-run A2.4 — this is the judgement gate. For each of the 6 sites: is any existing red a timeout itself rather than an assertion? And critically — ⭐ does any assertion depend on elapsed time? The named hazard is a load-bearing budget like connect-bound.test.ts:196 (elapsed > 8_000 && < 20_000): ⛔ if an assertion reads duration, adding a budget changes its semantics. #13902's seat did this with 8 controlled probes; do the same.

④ ⛔ Do NOT describe these 6 sites as "known to time out." They were found structurally (AST), not by a measured red. The only measured instance of the defect shape remains #13688. Overstating it in the changeset or PR body is a factual error.

ZONE 2 — The population, already measured. ⛔ Do not re-derive; verify and act.

Population A — 4 live-PG it() outside declareDialectCell(...), all unbudgeted:
live-dialect-matrix.isolation.test.ts:281 and :314 (both it.skipIf(!PG_CELL.available) + PG_CELL.config(), both call initObjects(...) ⇒ the full #13688 connect/DDL/read-back shape) · sql-driver-autonumber-cold-race.test.ts:159 · sql-driver-json-binding-without-ddl.test.ts:173 (schemaMode: 'validate-only').

Population B — 2 unbudgeted beforeAll hooks in sql-driver-backend-fault-envelope.test.ts (:160, :343), each opening a live driver, running initObjects(...) and inserting rows.

⭐ Why Population B is the valuable half, and worth understanding before you touch it: #13902 correctly excluded this file's it() blocks — they only query an already-open connection, so their cost model genuinely differs. But the live cost did not disappear; it lives in the hook, which is also unbudgeted. ⇒ A correct scoping decision pushed the risk just outside its own scope. Do not "fix" that by reversing the exclusion — budget the hooks.

ZONE 3 — The mechanism probe. ⛔ No live server needed, so a vague ablation is not acceptable.

#13902 measured, in this package's real config: no third argument → 5007ms → Test timed out in 5000ms (exit 1); with , 60_000 → 6505ms (exit 0). ⇒ The mechanism leg is reproducible locally without Postgres or MySQL. ⛔ Do not deliver an empty ablation on the grounds that no live cell is reachable from the container.

For the sites themselves, a skipped live test is a legitimate NOT MEASURED — say so, and do not claim a green you did not observe.

Gates and deliverable

Derive your gate family at your actual diff (node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands) and run it; exit codes captured by redirect before any pipe. A prerequisite-not-met gate is NOT MEASURED, never a pass.

Draft PR to main, Fixes #14100 in the body, plus a changeset. ⛔ Do not flip ready, enqueue, or enable auto-merge. Post your final report as a comment on #14100 first, then return it — machine-checkable fields plus the ③ answer per site and the count of sites you deliberately left alone (the 42).

📌 A method note recorded on this card, ⛔ not work for this round: the next person sweeping this package should use a per-it() AST walk, ⛔ not a file-level grep — #13902's original script pre-filtered out files containing any explicit budget line and thereby hid a true positive (sql-driver-diagnostic-value-probe.test.ts, which has a budget on its hook). The filing seat also ruled ⛔ not to build a standing gate for this: 197 gates already run, and this defect class has exactly one measured instance. If a third occurrence appears after this card lands, that ruling is revisited — with three instances, not one.

---

Generated by Claude Code

[os-support-ai]

Claim (dev seat): implementing this card now.

Session: session_01Q5WBDtaUnoz5XuJ6jk8pQ5
Branch: claude/issue-14100-live-ddl-budgets-outside-scoping (pushed, base faed5894)
Worktree: objectstack-issue-14100
Dispatched by: domain:engine PM, round 11 wave 3 — claim comment 5494038410.

Scope taken as dispatched: exactly the 4 it() of Population A and the 2 beforeAll of Population B, located by symbol rather than by the line numbers. No production source, no vitest.config.ts, no package-level testTimeout. Assignee and labels untouched.

Read the card body and both existing comments (routing 5489196941, PM claim 5494038410) in full, including tails — no sanitizer truncation observed in either.

---

Generated by Claude Code