You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
packages/rest package read routes claim to SHADOW their dispatcher twins, but the dispatcher answers /packages and /packages/:id on a stock showcase boot #14503
packages/rest/src/package-routes.ts documents its service-gated block as:
The service-gated half — mounted only when a package service is reachable, because each of these three SHADOWS a live dispatcher twin at the same pattern and a degraded shadow is worse than no shadow.
On a stock showcase boot (objectstack dev --seed-admin, which mounts PackageServicePlugin, so the service IS reachable), the dispatcher twin answers instead. Two independent probes, same boot:
404 wording.GET /api/v1/packages/no.such.package returns Package 'no.such.package' not found — the spelling in packages/runtime/src/domains/packages.ts. The REST route's own spelling is Package "no.such.package" was not found.
Response shape.GET /api/v1/packages/com.objectstack.setup returns the installed-package record directly under data (deps.success(pkg) in the runtime domain). The REST route wraps it as data.package and stamps source: 'registry', neither of which appeared.
Why it matters
The comment states an intended precedence that the composition does not deliver, so a reader reasoning about which body serves /packages gets the wrong answer — which is exactly what happened on #14309, whose root-cause section attributed the 500 to the REST body. Two consequences worth separating:
If the shadowing is intended, the mount order is wrong and the REST routes are dead in every composition that also mounts the dispatcher domain — including the reference app. The source field and the version query-multiplicity refusal are then unreachable there.
If the dispatcher twin is meant to win, the comment is stale and should say so, because it is currently the only written statement of the precedence.
Either way, the two doors have diverged behaviour (source stamp, 404 wording, data.package vs data envelope) while claiming to be one door with a shadow, so a client cannot depend on which it gets.
That card's fix is at the producer (SchemaRegistry.installPackage) and applies the read-door projection to both twins, so it is unaffected by which one answers. The precedence question is untouched and deliberately out of its scope.
Found while verifying #14309 on a live showcase boot.
Triage — graded
Both spellings confirmed at origin/main4a37870, which is what makes the probe conclusive rather than suggestive:
packages/rest/src/package-routes.ts:652-654 — the SHADOWS sentence, verbatim as quoted.
packages/rest/src/package-routes.ts:890 — sendError(res, 404, 'RESOURCE_NOT_FOUND', `Package "${packageId}" was not found.`) — double quotes, "was not found."
packages/runtime/src/domains/packages.ts:359, :378, :822, :885 — deps.error(`Package '${id}' not found`, 404) — single quotes, "not found".
The two doors are lexically distinguishable in their 404 text, so "which door answered" is directly observable rather than inferred. The reported observation is the dispatcher's spelling. The finding stands.
Graded as a decision rather than a queued fix: whichever way it goes, the response body on a published endpoint (GET /api/v1/packages/:id) changes shape for somebody — data.package + source: 'registry' versus a bare data — and that is a published-contract call, not a mount-order tidy-up.
<!-- os-decision-facets -->
① 项目长远合理性(权重 ≥50%,领起推荐) —— 同一个网址有两套实现,而且它们的行为已经不一样了:404 的措辞、响应外面包不包一层、有没有那个 source 戳。注释写着「这一套遮蔽那一套」,实际是另一套在答话。一个门两套实现、而且没人说得准哪套在服务,是最坏的一种增生 —— 它不增加任何能力,只制造分歧。长远终态只有一种:一个网址一套实现。①指向删掉其中一套,而不是修好优先级让两套继续并存。
What was measured
packages/rest/src/package-routes.tsdocuments its service-gated block as:On a stock showcase boot (
objectstack dev --seed-admin, which mountsPackageServicePlugin, so the service IS reachable), the dispatcher twin answers instead. Two independent probes, same boot:GET /api/v1/packages/no.such.packagereturnsPackage 'no.such.package' not found— the spelling inpackages/runtime/src/domains/packages.ts. The REST route's own spelling isPackage "no.such.package" was not found.GET /api/v1/packages/com.objectstack.setupreturns the installed-package record directly underdata(deps.success(pkg)in the runtime domain). The REST route wraps it asdata.packageand stampssource: 'registry', neither of which appeared.Why it matters
The comment states an intended precedence that the composition does not deliver, so a reader reasoning about which body serves
/packagesgets the wrong answer — which is exactly what happened on #14309, whose root-cause section attributed the 500 to the REST body. Two consequences worth separating:sourcefield and theversionquery-multiplicity refusal are then unreachable there.Either way, the two doors have diverged behaviour (
sourcestamp, 404 wording,data.packagevsdataenvelope) while claiming to be one door with a shadow, so a client cannot depend on which it gets.Not addressed by #14309
That card's fix is at the producer (
SchemaRegistry.installPackage) and applies the read-door projection to both twins, so it is unaffected by which one answers. The precedence question is untouched and deliberately out of its scope.Found while verifying #14309 on a live showcase boot.
Triage — graded
Both spellings confirmed at
origin/main4a37870, which is what makes the probe conclusive rather than suggestive:packages/rest/src/package-routes.ts:652-654— the SHADOWS sentence, verbatim as quoted.packages/rest/src/package-routes.ts:890—sendError(res, 404, 'RESOURCE_NOT_FOUND', `Package "${packageId}" was not found.`)— double quotes, "was not found."packages/runtime/src/domains/packages.ts:359, :378, :822, :885—deps.error(`Package '${id}' not found`, 404)— single quotes, "not found".The two doors are lexically distinguishable in their 404 text, so "which door answered" is directly observable rather than inferred. The reported observation is the dispatcher's spelling. The finding stands.
Graded as a decision rather than a queued fix: whichever way it goes, the response body on a published endpoint (
GET /api/v1/packages/:id) changes shape for somebody —data.package+source: 'registry'versus a baredata— and that is a published-contract call, not a mount-order tidy-up.<!-- os-decision-facets -->
source戳。注释写着「这一套遮蔽那一套」,实际是另一套在答话。一个门两套实现、而且没人说得准哪套在服务,是最坏的一种增生 —— 它不增加任何能力,只制造分歧。长远终态只有一种:一个网址一套实现。①指向删掉其中一套,而不是修好优先级让两套继续并存。推荐:A —— 删掉 REST 的那三条重复路由,让 dispatcher 成为唯一实现。 执行顺序写死:先量 REST 独有的两项行为(
source戳、version查询多值拒绝)有没有真实消费者,该保的挪进 dispatcher,不该保的在 changeset 里记为有意去掉而不是顺手丢掉。①领起(删一套而不是修优先级),③④同向。回退:B —— 若
source与 version 多值拒绝确实是对外承诺过的,则反过来修挂载顺序让 REST 真的遮蔽,并把 dispatcher 那三条摘掉。同样是「一个网址一套实现」,只是留下的那一套换成 REST。⛔ 不接受「只改注释」。 那是把两套实现的问题降级成一个文字问题:两套代码继续并存、继续各自演化、下一个人继续踩。③④都反对,而且它恰好是最省事因而最容易被选中的那条路。
置信缺口(本分析看不见什么): 没有量
source字段和version多值拒绝有没有真实消费者(Console、CLI、外部客户端)。这决定 A 里「该保的挪进去」的范围,也正是 A 与 B 之间唯一的实质分歧点 —— 先量这个,再选方向,否则两条路看起来会一样便宜。Generated by Claude Code