[finding] packages/runtime type-checks none of its 208 test files — tsconfig excludes **/*.test.ts and no test-typecheck wiring exists

[hotlong]

What was measured

packages/runtime type-checks none of its own test files, and nothing reports the gap.

• packages/runtime/package.json -> "typecheck": "tsc --noEmit".
• packages/runtime/tsconfig.json -> "exclude": ["node_modules", "dist", "**/*.spec.ts", "**/*.test.ts"].
• There is no tsconfig.test.json, no check:test-typecheck script, and no test-typecheck-debt.json in the package.

So pnpm --filter @objectstack/runtime typecheck exits 0 over source only. Confirmed by measurement rather than by reading the config: tsc --noEmit --listFiles in that package reports 0 hits for a test file that exists in src/domains/.

The population is not small — the package's suite is 208 test files / 3066 tests.

Why this is the shape AGENTS.md warns about

AGENTS.md states the rule directly: never exclude *.test.ts from a package's tsconfig.json, because tsc --noEmit reads that config, so the exclusion hides the tests from the very check the typecheck script advertises — a green gate over source nothing read. It also names the remedy: a sibling tsconfig.test.json named in the typecheck script, which is what packages/objectql and packages/rest both do (each pairing it with scripts/check-test-typecheck.mts --package ... --project tsconfig.test.json and a shrink-only test-typecheck-debt.json).

A @ts-expect-error written in any packages/runtime test today is therefore a phantom check: it evaluates never, and deleting it leaves every gate just as green.

Suggested shape

Onboard packages/runtime by wiring the shared gate the way its two siblings are wired — never by copying their implementation — and seed the per-file, shrink-only ledger with whatever the first measurement reports. Expect a non-trivial initial count; the ratchet only has to shrink from there.

Observed while landing #14309, which added a test file to packages/runtime/src/domains/ and had to type-check it standalone to know it was sound.

Generated by Claude Code

[huangyiirene]

Triage — graded, finding cleared. Re-measured at origin/main ed44512.

Confirmed

• packages/runtime/tsconfig.json — "exclude": ["node_modules", "dist", "**/*.spec.ts", "**/*.test.ts"].
• packages/runtime/package.json:24 — "typecheck": "tsc --noEmit", nothing else on the line.
• No tsconfig.test.json, no check:test-typecheck, no test-typecheck-debt.json in the package.
• git ls-tree -r origin/main packages/runtime/src | grep -c '\.test\.ts$' → 208. The card's count is exact.

Both named siblings do the wired pattern:

• packages/objectql/package.json:23-25 — "typecheck": "tsc --noEmit && tsc --noEmit -p tsconfig.scripts.json && pnpm check:test-typecheck", with check:test-typecheck and gen:test-typecheck-debt beside it.
• packages/rest/package.json:25-27 — same shape.

One thing the card understates: the pattern is already repo-wide, so this is onboarding, not design

tsconfig.test.json / test-typecheck-debt.json pairs exist across packages/client, packages/metadata-core, packages/metadata-fs, packages/objectql, packages/rest, packages/plugins/embedder-openai, packages/plugins/knowledge-memory, packages/plugins/knowledge-ragflow and more. There is a shared runner (scripts/check-test-typecheck.mts) with its own --self-test, and a settled invocation convention.

So nothing here needs a ruling: the mechanism exists, AGENTS.md mandates it in as many words, and packages/runtime is a package that never got wired. Dispatchable as-is.

Scope ruled

Wire packages/runtime the way its siblings are wired — drop **/*.test.ts / **/*.spec.ts from the package tsconfig.json's exclude only if that is how the sibling pattern does it, otherwise add the sibling tsconfig.test.json, name check:test-typecheck in the typecheck script, and seed test-typecheck-debt.json from the first real measurement.

⛔ Do not copy the siblings' implementation — call the shared scripts/check-test-typecheck.mts with --package packages/runtime --project tsconfig.test.json, exactly as objectql and rest do. A second copy of the runner is the dialect split those gates exist to prevent.

⛔ Do not fix the type errors the first measurement finds. Seed the ledger with them and let the ratchet shrink. A 208-file package will report a non-trivial initial count and turning this card into a type-error cleanup is how it stops landing at all.

Routing

domain:cli — runtime is in that lane per the lane table, and the whole change lands inside packages/runtime plus a shared script it only calls.

priority:p2, one step above the prose cards graded alongside it this round. This is a gate that reports green over 208 files nothing read, in a core package, against a rule AGENTS.md states explicitly. The card's sharpest line is the right one: a @ts-expect-error written in any packages/runtime test today evaluates never, so deleting it leaves every gate just as green — the check is not weak, it is absent while advertising itself. Not p1: no shipped behaviour is wrong because of it.

pm:queue.

---

Generated by Claude Code

[os-trump]

Interim — implementation pushed, verification in progress. Container has been restarting mid-run today, so this records the state now rather than at the end.

Branch claude/issue-14504-runtime-test-typecheck, head 4c82b1caff, base 224f8ea4a0. Session session_016yfqQh2dBgPAymYd7xipza. No PR open yet.

Re-measured on current main, not taken from the card: the package now has 214 test files (the card and the triage both read 208 at ed44512; four packages/runtime PRs landed since). The premise holds exactly: tsc --noEmit --listFiles -p packages/runtime/tsconfig.json, closure built first, puts 899 files in the program and 0 of the 214 test files among them, while 79 non-test src/** files ARE there — so the zero is the exclude line, not a probe that sees nothing. Directional control packages/drivers/driver-memory (no test exclusion): 40 of 40. Under the new tsconfig.test.json: 214 of 214.

Scope taken: wire + ledger, no repair — the ruling in the triage comment above ("⛔ Do not fix the type errors the first measurement finds"), not a silent narrowing. The count that justifies it: 191 errors across 27 files.

Diff: new packages/runtime/tsconfig.test.json, new packages/runtime/test-typecheck-debt.json (191 errors / 27 files / 69 signatures), packages/runtime/package.json typecheck chain, the @objectstack/runtime TEST_DEBT graduation in scripts/check-type-check-coverage.mjs, a scripts/regen-artifacts.mjs row, and a changeset. No test file is edited, so no file held by another open PR is touched.

One correction to the card, measured: this layer holds zero @ts-expect-error directives, so no pin was silently dead here — the cost of the gap was the 191 unreported errors, not a phantom pin.

Generated by Claude Code

---

Generated by Claude Code