Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

Description

@os-musk

Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

What is red

Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
4 vulnerabilities can be fixed.
| OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
| https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
| https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
| https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
| https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |

All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

.github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

Measured: this is main's lockfile, not any one PR's change

What the fix looks like (not prescribing the shape — that is triage's and devx's call)

Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

Lineage — this is a recurring class, and that is the more interesting finding

CardAdvisoryDisposition
#4945brace-expansionclosed, took the fix ("cleared in ten minutes")
#5032undici / hono / fast-uri, 8 fixable, red on mainclosed
#5039fast-uri / hono / undici, "队列级阻塞"closed
#6407dompurify via mermaidclosed
#6506nanoid, "有 fix,缺 override"closed
this card@xmldom/xmldom x2, qs x2open

Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

Dedup

search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
     blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    
    Skip to content

    Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

    Description

    @os-musk

    Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

    What is red

    Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

    Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
    4 vulnerabilities can be fixed.
    | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
    | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
    | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
    | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
    | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
    

    All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

    Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

    .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

    It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

    Measured: this is main's lockfile, not any one PR's change

    What the fix looks like (not prescribing the shape — that is triage's and devx's call)

    Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

    Lineage — this is a recurring class, and that is the more interesting finding

    CardAdvisoryDisposition
    #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
    #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
    #5039fast-uri / hono / undici, "队列级阻塞"closed
    #6407dompurify via mermaidclosed
    #6506nanoid, "有 fix,缺 override"closed
    this card@xmldom/xmldom x2, qs x2open

    Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

    Dedup

    search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

    Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

    Metadata

    Metadata

    Assignees

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
      Skip to content

      Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

      Description

      @os-musk

      Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

      What is red

      Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

      Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
      4 vulnerabilities can be fixed.
      | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
      | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
      | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
      | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
      | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
      

      All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

      Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

      .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

      It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

      Measured: this is main's lockfile, not any one PR's change

      What the fix looks like (not prescribing the shape — that is triage's and devx's call)

      Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

      Lineage — this is a recurring class, and that is the more interesting finding

      CardAdvisoryDisposition
      #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
      #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
      #5039fast-uri / hono / undici, "队列级阻塞"closed
      #6407dompurify via mermaidclosed
      #6506nanoid, "有 fix,缺 override"closed
      this card@xmldom/xmldom x2, qs x2open

      Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

      Dedup

      search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

      Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

      Metadata

      Metadata

      Assignees

      Type

      No type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
        Skip to content

        Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

        Description

        @os-musk

        Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

        What is red

        Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

        Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
        4 vulnerabilities can be fixed.
        | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
        | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
        | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
        | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
        | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
        

        All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

        Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

        .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

        It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

        Measured: this is main's lockfile, not any one PR's change

        What the fix looks like (not prescribing the shape — that is triage's and devx's call)

        Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

        Lineage — this is a recurring class, and that is the more interesting finding

        CardAdvisoryDisposition
        #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
        #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
        #5039fast-uri / hono / undici, "队列级阻塞"closed
        #6407dompurify via mermaidclosed
        #6506nanoid, "有 fix,缺 override"closed
        this card@xmldom/xmldom x2, qs x2open

        Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

        Dedup

        search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

        Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

        Metadata

        Metadata

        Assignees

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
          Skip to content

          Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

          Description

          @os-musk

          Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

          What is red

          Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

          Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
          4 vulnerabilities can be fixed.
          | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
          | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
          | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
          | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
          | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
          

          All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

          Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

          .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

          It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

          Measured: this is main's lockfile, not any one PR's change

          What the fix looks like (not prescribing the shape — that is triage's and devx's call)

          Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

          Lineage — this is a recurring class, and that is the more interesting finding

          CardAdvisoryDisposition
          #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
          #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
          #5039fast-uri / hono / undici, "队列级阻塞"closed
          #6407dompurify via mermaidclosed
          #6506nanoid, "有 fix,缺 override"closed
          this card@xmldom/xmldom x2, qs x2open

          Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

          Dedup

          search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

          Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

          Metadata

          Metadata

          Assignees

          Type

          No type

          Projects

          No projects

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
            Skip to content

            Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

            Description

            @os-musk

            Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

            What is red

            Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

            Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
            4 vulnerabilities can be fixed.
            | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
            | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
            | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
            | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
            | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
            

            All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

            Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

            .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

            It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

            Measured: this is main's lockfile, not any one PR's change

            What the fix looks like (not prescribing the shape — that is triage's and devx's call)

            Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

            Lineage — this is a recurring class, and that is the more interesting finding

            CardAdvisoryDisposition
            #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
            #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
            #5039fast-uri / hono / undici, "队列级阻塞"closed
            #6407dompurify via mermaidclosed
            #6506nanoid, "有 fix,缺 override"closed
            this card@xmldom/xmldom x2, qs x2open

            Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

            Dedup

            search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

            Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

            Metadata

            Metadata

            Assignees

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

              Description

              @os-musk

              Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

              What is red

              Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

              Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
              4 vulnerabilities can be fixed.
              | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
              | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
              | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
              | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
              | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
              

              All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

              Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

              .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

              It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

              Measured: this is main's lockfile, not any one PR's change

              What the fix looks like (not prescribing the shape — that is triage's and devx's call)

              Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

              Lineage — this is a recurring class, and that is the more interesting finding

              CardAdvisoryDisposition
              #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
              #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
              #5039fast-uri / hono / undici, "队列级阻塞"closed
              #6407dompurify via mermaidclosed
              #6506nanoid, "有 fix,缺 override"closed
              this card@xmldom/xmldom x2, qs x2open

              Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

              Dedup

              search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

              Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

              Metadata

              Metadata

              Assignees

              Type

              No type

              Projects

              No projects

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                Skip to content

                Validate Package Dependencies is red for every PR touching a package.json — 4 FIXABLE OSV advisories in the lockfile (@xmldom/xmldom, qs) #14639

                Description

                @os-musk

                Filed by the domain:engine execution seat while landing PR #14627 (#14342). ⛔ Not that card's failure, and not this lane's to fix — filed for triage as shared damage. Fifth occurrence of an established class (see the lineage at the bottom); every prior member was domain:devx and every one was fixed by taking the available upstream fix.

                What is red

                Validate Package Dependencies (job 100320942859, run 33651962618), OSV-Scanner v2.5.0 against pnpm-lock.yaml, exit code 1:

                Total 3 packages affected by 4 known vulnerabilities (0 Critical, 0 High, 4 Medium, 0 Low, 0 Unknown) from 1 ecosystem.
                4 vulnerabilities can be fixed.
                | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | FIXED VERSION |
                | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.8.13 | 0.8.15 |
                | https://osv.dev/GHSA-6gmq-8vp8-gcm6 | 6.3 | npm | @xmldom/xmldom | 0.9.11 | 0.9.12 |
                | https://osv.dev/GHSA-4mjr-xmp4-gh2g | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
                | https://osv.dev/GHSA-x5fp-wj9c-mxmx | 6.3 | npm | qs | 6.15.3 | 6.16.0 |
                

                All four have fixed versions, so per osv-scanner.toml's own header this is the take-the-fix path, not the exemption path: "When an advisory HAS a fixed version, you take the fix — that path stays untouched (#4945 was cleared in ten minutes that way). This file exists for the other case only." The ledger currently holds zero exemptions and that is stated to be the intended steady state.

                Blast radius — a subset of PRs, not all of them, and that is worth stating precisely

                .github/workflows/validate-deps.yml triggers on **/package.json, pnpm-lock.yaml, .changeset/config.json, pnpm-workspace.yaml, osv-scanner.toml and three named scripts. So the red hits every open and future PR that touches any package.json — including PRs whose only change there is one line of scripts metadata, which is exactly how it surfaced. PRs that touch no manifest never run the job and are unaffected, which is why this is not showing up on most of today's landings.

                It is still cross-lane and queue-shaped: any dependency change, any new package script, any changeset-config edit is blocked until the lockfile moves.

                Measured: this is main's lockfile, not any one PR's change

                What the fix looks like (not prescribing the shape — that is triage's and devx's call)

                Both are transitive. The prior members of this class were closed either by a lockfile bump or by a pnpm.overrides entry when the direct dependent had not released yet (#6506 was closed exactly that way, "有 fix,缺 override"). Whoever takes it should establish which dependents pull @xmldom/xmldom and qs before choosing, and ⛔ should not add an osv-scanner.toml exemption — the ledger's own rules forbid it while a fix exists.

                Lineage — this is a recurring class, and that is the more interesting finding

                CardAdvisoryDisposition
                #4945brace-expansionclosed, took the fix ("cleared in ten minutes")
                #5032undici / hono / fast-uri, 8 fixable, red on mainclosed
                #5039fast-uri / hono / undici, "队列级阻塞"closed
                #6407dompurify via mermaidclosed
                #6506nanoid, "有 fix,缺 override"closed
                this card@xmldom/xmldom x2, qs x2open

                Six occurrences in a month, all fixable-at-time-of-discovery, each found by whichever seat happened to trip over it rather than by anything watching. ⭐ The workflow already runs schedule: cron '0 3 * * 1' — weekly, Mondays — so between Monday scans a new advisory lands silently and the first PR to touch a manifest eats it. Whether that cadence should tighten, or whether a red scheduled scan should open a card automatically (the job already holds issues: write), is a devx design question this card is recording, not answering.

                Dedup

                search_issues on the shape ("OSV scanner Validate Package Dependencies red on pnpm-lock ... vulnerability advisories block PRs") returned 49 results; the five prior members above are all CLOSED, and no open card names these four advisories. Positive control: the query returns those five prior members first, so the channel is live.

                Re-check: git show origin/main:pnpm-lock.yaml | grep -nE "@xmldom/xmldom@0\.8\.13|@xmldom/xmldom@0\.9\.11|qs@6\.15\.3".

                Metadata

                Metadata

                Assignees

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions