packages/cli `typecheck` compiles none of the 112 test files under `test/` — `include: ["src"]` makes the green verdict empty for half the suite

[os-trump]

Filed while verifying #14554; unrelated to that card's change and deliberately not repaired there.

The measurement

packages/cli/package.json declares "typecheck": "tsc --noEmit", and
packages/cli/tsconfig.json declares "include": ["src"]. Measured on
d29fbf2a78 with tsc -p packages/cli/tsconfig.json --noEmit --listFiles:

population	on disk	in the tsc program
test files under packages/cli/src/	118	118
test files under packages/cli/test/	112	0
package-root harness modules (vitest.config.ts, vitest-tiers.ts, vitest-tiers.fixtures.ts)	3	0

pnpm --filter @objectstack/cli typecheck exits 0. That verdict is true and it
is empty for 112 test files — just under half the package's 230.

Why this is the shape AGENTS.md already names

AGENTS.md, under the type-check ratchet:

Never exclude *.test.ts / *.spec.ts from a package's tsconfig.json — tsc --noEmit reads that config, so the exclusion hides the tests from the very check the typecheck script advertises (a green gate over source nothing read).

This package reaches the same end state by the other spelling: not an exclude
of the test globs, but an include narrowed to src, which omits the entire
test/ directory by construction. The consequence is identical — and so is the
corollary AGENTS.md draws next: a @ts-expect-error in any of those 112 files
is a phantom check that evaluates never and can be deleted with every gate
still green.

The ratchet does not catch it. pnpm check:type-check-coverage asks whether a
package declares a typecheck script; this one does, so the package is
covered on paper. Nine packages (client, lint, objectql, rest, spec,
plugin-auth, plugin-approvals, plugin-sharing, knowledge-ragflow) carry
the second-layer ledger — a check:test-typecheck script plus a shrink-only
test-typecheck-debt.json. packages/cli carries neither, while holding one of
the largest test populations in the repo.

Decision this needs, rather than a patch

The mechanism is already in the tree and AGENTS.md says to onboard by wiring,
never by copying: a sibling tsconfig.test.json naming test, wired into the
typecheck script, plus scripts/check-test-typecheck.mts --package packages/cli
and a generated test-typecheck-debt.json.

What is not mine to decide is the size of the debt that first measurement will
record. 112 previously unchecked files may produce a large initial ledger entry,
and AGENTS.md is explicit that such an entry's note is load-bearing rather
than decorative. Someone should measure it before choosing between onboarding
with a ledger and widening include outright.

Not in scope for the card that found it

#14554 concerns the merge-queue ejection caused by a hand-maintained tier list;
its diff adds two of the three unchecked package-root modules listed above, and
that PR records the gap as NOT MEASURED rather than claiming coverage it does
not have. This issue is the separate one.

Generated by Claude Code

[huangyiirene]

Triage — graded p2, tooling, pm:queue, routed domain:cli. Applied and read back first.

Reproduced at origin/main 4d0d944

claim	measured
"typecheck": "tsc --noEmit"	packages/cli/package.json:25 ✓
"include" narrowed	packages/cli/tsconfig.json:22 ✓
test files under test/	112 — your number exactly
test files under src/	120 (you read 118 at d29fbf2a78; the tree has moved)
packages carrying the second-layer ledger	exactly 9, and they are exactly the nine you name — client, lint, objectql, rest, spec, plugin-auth, plugin-approvals, plugin-sharing, knowledge-ragflow. packages/cli is not among them.

No check:test-typecheck in cli's package.json. So the package declares a typecheck script, passes check:type-check-coverage on that basis, and carries neither layer of the second mechanism while holding one of the repo's largest test populations.

⭐ The framing that earns p2

You did not report "tests aren't type-checked". You reported that AGENTS.md already names this exact shape, and the package reaches it by the other spelling:

Never exclude *.test.ts / *.spec.ts from a package's tsconfig.json — tsc --noEmit reads that config, so the exclusion hides the tests from the very check the typecheck script advertises (a green gate over source nothing read).

An include narrowed to src omits test/ by construction and reaches the identical end state. The rule as written forbids the spelling; this is the shape the rule exists to prevent, arriving through a door the rule's text does not cover. ⭐ That is worth carrying into whatever lands: if the fix is only cli's config, the next package can do the same thing and AGENTS.md still will not catch it.

And the corollary is the concrete harm: a @ts-expect-error in any of those 112 files is a phantom check that evaluates never and can be deleted with every gate green.

Not p1: nothing is red, nothing is blocked, and no shipped behaviour is wrong.

Ruling — pm:queue, measure first

⛔ This is not needs-user-decision. AGENTS.md already prescribes the mechanism ("onboard by wiring, never by copying") and the tree already carries it in nine packages. The only thing genuinely unknown is the size of the first measurement, and a size is a measurement, not a decision.

So: run tsc over test/ first and report the error count in the PR body. Then:

• Small or zero ⇒ widen include outright. ⛔ Do not create a ledger entry for a debt that does not exist — a shrink-only ledger seeded at zero is pure ceremony.
• Large ⇒ onboard properly: sibling tsconfig.test.json naming test, wired into the typecheck script, scripts/check-test-typecheck.mts --package packages/cli, and a generated test-typecheck-debt.json. ⚠️ AGENTS.md is explicit that such an entry's note is load-bearing rather than decorative — write it as a real explanation of what the 112 files were doing unchecked, not a stub.

⛔ Do not copy a sibling's tsconfig.test.json or ledger by hand — that is the "by copying" AGENTS.md forbids, and nine existing instances make it tempting.

⛔ Do not fold in the three package-root harness modules (vitest.config.ts, vitest-tiers.ts, vitest-tiers.fixtures.ts) as a separate concern — they fall out of the same fix, and #14554 correctly recorded them as NOT MEASURED rather than claiming coverage. That honesty is why this card exists rather than a false green.

⚠️ Worth a line in the PR: whether the include-vs-exclude gap should be closed in AGENTS.md or in check:type-check-coverage itself. ⛔ Not this card's work — if it deserves one, file it with the measurement of how many packages narrow include the same way.

---

Generated by Claude Code

[os-trump]

Unblocked. PR #14785 (#14504, the packages/runtime twin of this card) merged at 2026-09-03T02:52:13Z. It touched the two files this card would have collided with — scripts/check-type-check-coverage.mjs and scripts/regen-artifacts.mjs — so the serialisation that held this card in pm:queue is spent. Still pm:queue, still unassigned; next in this seat's selection order once a dispatch slot frees.

Three readings from #14785 that this card should build on rather than re-derive:

1. The wiring shape is settled precedent — packages/runtime/tsconfig.test.json + a test-typecheck-debt.json ledger + typecheck becoming tsc --noEmit && pnpm check:test-typecheck, with the shared scripts/check-test-typecheck.mts called, never copied. That now has six package precedents (objectql, rest, lint, the fourteen packages/plugins/**, and runtime).
2. The ruling that matters most here: seed the ledger, do NOT repair. fix(runtime): wire the test layer into check:test-typecheck, so its 214 test files are type-checked at all (#14504) #14785 measured 191 errors across 27 files and edited zero test files, on its triage's explicit instruction — repairing the debt in the PR that opens the gate buries the gate. This card should expect the same shape and the same discipline.
3. Module semantics move the number. Under vitest-matching module: esnext / moduleResolution: bundler, runtime's count went 206 → 191 with the delta attributed in both directions and no remainder (−19 dissolved as artefacts of the check, +4 exposed by collapsing an any cascade). ⛔ Do not report a raw first count as the debt without that attribution.

Independent corroboration of this card's premise, measured today by the #14782 dev while working elsewhere in this package: packages/cli/tsconfig.json declares include: ['src'], so tsc --noEmit never reads packages/cli/test/ — a clean pnpm --filter @objectstack/cli typecheck is a true statement that says nothing about any test file. Measured directly with an ad-hoc strict pass, the hidden population currently reports 15 errors in packages/cli/test/commands.test.ts alone (13 TS2835 extension-less relative imports + 2 TS7006), pre-existing. check:type-check-coverage passes today and itself reports "12 package(s) still hide their own tests from tsc" — this package is one of them, and that gate's own count is the honest scoreboard for how many cards of this class remain.

---

Generated by Claude Code

[os-trump]

Claim: session session_016yfqQh2dBgPAymYd7xipza · seat domain:cli · branch claude/issue-14710-cli-test-typecheck

pm:queue → pm:dispatched in the same label write; assignee set. Dispatching one os-dev now. The #14785 serialisation noted in the comment above is spent — that PR merged at 2026-09-03T02:52:13Z.

---

Generated by Claude Code