The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956

Open
Open
The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
Labels
pm:queue

Description

@os-sales
os-sales
opened on Sep 3, 2026

Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.

Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.

The measurement

In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):

if(run.nodeId!==parkedAt.nodeId)return'lost';

leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.

For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.

The pin file says the opposite

concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."

That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.

Why the gap is load-bearing, not theoretical

The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:

a row persisted with no correlation has nothing to compare, and the node condition still holds

On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.

The pin already exists — the auditor wrote and verified it

A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.

Suggested shape (for triage and whoever takes it, not a ruling):

  1. Add that pin.
  2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.

⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.

Also owed, and NOT VERIFIED as filed

The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.

Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pm:queue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

      Skip to content
      The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
      Open
      Open
      The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
      Labels
      pm:queue
      Description
      @os-sales
      os-sales
      opened on Sep 3, 2026
      Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
      Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
      The measurement
      In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
      if(run.nodeId!==parkedAt.nodeId)return'lost';
      leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
      For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
      The pin file says the opposite
      concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
      That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
      Why the gap is load-bearing, not theoretical
      The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
      a row persisted with no correlation has nothing to compare, and the node condition still holds
      On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
      The pin already exists — the auditor wrote and verified it
      A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
      Suggested shape (for triage and whoever takes it, not a ruling):
      1. Add that pin.
      2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
      ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
      Also owed, and NOT VERIFIED as filed
      The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
      Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
      Activity
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Metadata
      Metadata
      Assignees
      No one assigned
        Labels
        pm:queue
        Type
        No type
        Projects
        No projects
          Milestone
          No milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

          Skip to content
          The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
          Open
          Open
          The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
          Labels
          pm:queue
          Description
          @os-sales
          os-sales
          opened on Sep 3, 2026
          Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
          Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
          The measurement
          In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
          if(run.nodeId!==parkedAt.nodeId)return'lost';
          leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
          For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
          The pin file says the opposite
          concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
          That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
          Why the gap is load-bearing, not theoretical
          The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
          a row persisted with no correlation has nothing to compare, and the node condition still holds
          On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
          The pin already exists — the auditor wrote and verified it
          A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
          Suggested shape (for triage and whoever takes it, not a ruling):
          1. Add that pin.
          2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
          ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
          Also owed, and NOT VERIFIED as filed
          The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
          Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
          Activity
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Metadata
          Metadata
          Assignees
          No one assigned
            Labels
            pm:queue
            Type
            No type
            Projects
            No projects
              Milestone
              No milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

              Skip to content
              The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
              Open
              Open
              The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
              Labels
              pm:queue
              Description
              @os-sales
              os-sales
              opened on Sep 3, 2026
              Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
              Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
              The measurement
              In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
              if(run.nodeId!==parkedAt.nodeId)return'lost';
              leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
              For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
              The pin file says the opposite
              concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
              That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
              Why the gap is load-bearing, not theoretical
              The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
              a row persisted with no correlation has nothing to compare, and the node condition still holds
              On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
              The pin already exists — the auditor wrote and verified it
              A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
              Suggested shape (for triage and whoever takes it, not a ruling):
              1. Add that pin.
              2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
              ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
              Also owed, and NOT VERIFIED as filed
              The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
              Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
              Activity
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Metadata
              Metadata
              Assignees
              No one assigned
                Labels
                pm:queue
                Type
                No type
                Projects
                No projects
                  Milestone
                  No milestone
                  Relationships
                  None yet
                  Development
                  No branches or pull requests
                  Issue actions
                  
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

                  Skip to content
                  The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
                  Open
                  Open
                  The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
                  Labels
                  pm:queue
                  Description
                  @os-sales
                  os-sales
                  opened on Sep 3, 2026
                  Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
                  Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
                  The measurement
                  In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
                  if(run.nodeId!==parkedAt.nodeId)return'lost';
                  leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
                  For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
                  The pin file says the opposite
                  concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
                  That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
                  Why the gap is load-bearing, not theoretical
                  The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
                  a row persisted with no correlation has nothing to compare, and the node condition still holds
                  On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
                  The pin already exists — the auditor wrote and verified it
                  A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
                  Suggested shape (for triage and whoever takes it, not a ruling):
                  1. Add that pin.
                  2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
                  ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
                  Also owed, and NOT VERIFIED as filed
                  The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
                  Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
                  Activity
                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                  Metadata
                  Metadata
                  Assignees
                  No one assigned
                    Labels
                    pm:queue
                    Type
                    No type
                    Projects
                    No projects
                      Milestone
                      No milestone
                      Relationships
                      None yet
                      Development
                      No branches or pull requests
                      Issue actions
                      
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                      Skip to content
                      The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
                      Open
                      Open
                      The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
                      Labels
                      pm:queue
                      Description
                      @os-sales
                      os-sales
                      opened on Sep 3, 2026
                      Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
                      Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
                      The measurement
                      In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
                      if(run.nodeId!==parkedAt.nodeId)return'lost';
                      leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
                      For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
                      The pin file says the opposite
                      concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
                      That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
                      Why the gap is load-bearing, not theoretical
                      The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
                      a row persisted with no correlation has nothing to compare, and the node condition still holds
                      On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
                      The pin already exists — the auditor wrote and verified it
                      A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
                      Suggested shape (for triage and whoever takes it, not a ruling):
                      1. Add that pin.
                      2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
                      ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
                      Also owed, and NOT VERIFIED as filed
                      The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
                      Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
                      Activity
                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                      Metadata
                      Metadata
                      Assignees
                      No one assigned
                        Labels
                        pm:queue
                        Type
                        No type
                        Projects
                        No projects
                          Milestone
                          No milestone
                          Relationships
                          None yet
                          Development
                          No branches or pull requests
                          Issue actions
                          
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                          Skip to content
                          The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
                          Open
                          Open
                          The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
                          Labels
                          pm:queue
                          Description
                          @os-sales
                          os-sales
                          opened on Sep 3, 2026
                          Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
                          Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
                          The measurement
                          In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
                          if(run.nodeId!==parkedAt.nodeId)return'lost';
                          leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
                          For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
                          The pin file says the opposite
                          concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
                          That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
                          Why the gap is load-bearing, not theoretical
                          The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
                          a row persisted with no correlation has nothing to compare, and the node condition still holds
                          On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
                          The pin already exists — the auditor wrote and verified it
                          A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
                          Suggested shape (for triage and whoever takes it, not a ruling):
                          1. Add that pin.
                          2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
                          ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
                          Also owed, and NOT VERIFIED as filed
                          The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
                          Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
                          Activity
                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                          Metadata
                          Metadata
                          Assignees
                          No one assigned
                            Labels
                            pm:queue
                            Type
                            No type
                            Projects
                            No projects
                              Milestone
                              No milestone
                              Relationships
                              None yet
                              Development
                              No branches or pull requests
                              Issue actions
                              
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

                              Skip to content
                              The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit) #14956
                              Open
                              Open
                              The node comparison in InMemorySuspendedRunStore.claimSuspension is unpinned — deleting it alone leaves 61/61 green, and the pin file's comment claims the opposite (#14333 post-merge audit)#14956
                              Labels
                              pm:queue
                              Description
                              @os-sales
                              os-sales
                              opened on Sep 3, 2026
                              Filed by the domain:services execution seat from a post-merge tier audit of PR #14712 (#14333, merged 436841131 at 2026-09-03T01:16:55Z). Unassigned; domain:*, type and priority are triage's.
                              Lands in packages/services/service-automation — this lane. A follow-up PR against main; ⛔ #14712 is merged and must not be reopened or reused.
                              The measurement
                              In a detached worktree at feb213d42 (the merged head), deleting only this line from InMemorySuspendedRunStore.claimSuspension (around :147):
                              if(run.nodeId!==parkedAt.nodeId)return'lost';
                              leaves the three-file population at 61 passed (61). Blob 0ad54b28… → 862753d5…, restore proven equal to HEAD.
                              For contrast, from the same bench: deleting both comparisons → 2 red; deleting the correlation comparison alone → 1 red; deleting the node comparison alone → 0 red.
                              The pin file says the opposite
                              concurrent-replica-resume-race.test.ts, the CONDITION block's lead comment, states the guarantee as "one per comparison, so a mutation that deletes only one of them still reddens."
                              That is false for the node half, and the reason is specific: both CONDITION cases re-park with a new correlation (req_lv1→req_lv2, map:item_1→map:item_2), so the correlation comparison rejects the stale claim first and masks the node comparison entirely. A comment describing a red that does not exist is worse than no comment — the next reader trusts it and will not re-derive it.
                              Why the gap is load-bearing, not theoretical
                              The maintainer's ruling is literally "delete only if still parked at node N", and SuspendedRunStore.claimSuspension's docblock explicitly allows a correlation-less parking:
                              a row persisted with no correlation has nothing to compare, and the node condition still holds
                              On that shape the node comparison is the only guard there is. Unpinned, a future refactor can delete it and every test stays green — on the exact code path whose whole purpose is stopping two replicas from resuming one run twice.
                              The pin already exists — the auditor wrote and verified it
                              A pausing executor that mints no correlation, with replica B's claim held until replica A has advanced and re-parked at the next node. It passes at HEAD and goes red under the node-only mutation (expected true to be false — B's stale claim granted, the action fires twice). Written in the PR's own harness idiom.
                              Suggested shape (for triage and whoever takes it, not a ruling):
                              1. Add that pin.
                              2. Rewrite the "one per comparison" sentence to the measured truth: both-deleted → 2 red; correlation-only → 1 red; node-only → 0 red until this pin exists.
                              ⚠️ The ObjectStore side does not need it — dropping node_id from its where is caught by that suite's exact-shape assertions (measured: 6 red). This gap is specific to the in-memory store.
                              Also owed, and NOT VERIFIED as filed
                              The audit could not find the grouped follow-up this seat promised for the prior review's §5 notes 1 (the loser's hot-cache entry is not evicted on 'lost') and 5 (the non-count 'unsupported' branch re-deletes). A search found nothing. Whoever takes this card should check whether that finding exists and file it if not, rather than assuming either way.
                              Refs: PR #14712 / #14333 (merged; the audit's verdict comment carries the full bench) · the auditor's worktree convention scratchpad/review-14712-r2
                              Activity
                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                              Metadata
                              Metadata
                              Assignees
                              No one assigned
                                Labels
                                pm:queue
                                Type
                                No type
                                Projects
                                No projects
                                  Milestone
                                  No milestone
                                  Relationships
                                  None yet
                                  Development
                                  No branches or pull requests
                                  Issue actions