You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
check-driver-conformance.mjs FILTER_TEXT requirement-3 calls driver-mongodb's arm "the last place a bare new Error escaped the ADR-0112 envelope" — it was not, and after #7047 the sentence names the wrong site #7159
Flagged from #7047 rather than folded into its PR, per that card's fence (a conformance-script edit riding on a behaviour fix). Recording it so the sentence is corrected deliberately by whoever owns that ledger's prose.
$regex / $options must be REFUSED, naming $icontains. DONE on all five (drivers: $regex 响亮拒收 + $icontains 各后端实现(#4706 裁决 B 案 · 驱动半边) #5702) … Each site now prints RETIRED_FILTER_OPERATORS[op].why verbatim, so the five refusals say one thing; driver-mongodb's default: arm was additionally routed through its own INVALID_FILTER helper, which is the code half the case-set requires and the last place a bare new Error escaped the ADR-0112 envelope.
Why it is wrong
It was already false when written. objectql's having face (having-filter.tsunknownOperator()) had two bare new Error returns escaping the same envelope — measured code: undefined / status: undefined on both the retired and the unknown branch (#6993's census, #7047's card).
The "five" in that paragraph counts the five DRIVER faces, which is correct for the requirement's own scope. The trailing clause is not scoped that way: "the last place a bare new Error escaped the ADR-0112 envelope" is a repo-wide claim, and having was a sixth place it escaped from.
#7047 puts both having returns in the envelope, so the repo-wide claim becomes true — but it now attributes the milestone to the wrong site. driver-mongodb's arm was not the last one; having was. A reader auditing envelope coverage from this sentence would stop one face early, which is exactly what happened.
Suggested fix
Scope the clause to the driver family and name where the actual last one landed, e.g.:
… driver-mongodb's default: arm was additionally routed through its own INVALID_FILTER helper, which is the code half the case-set requires and the last bare new Error in the DRIVER family. The sixth refusal face — objectql's having (having-filter.ts) — was outside this gate's scope (packages/drivers/*) and kept its bare new Error until #7047.
That last half-sentence is worth keeping rather than deleting: this gate not covering having is the reason two consecutive defects on that face (#5905, #7047) were found by hand-run censuses instead of by CI.
Flagged from #7047 rather than folded into its PR, per that card's fence (a conformance-script edit riding on a behaviour fix). Recording it so the sentence is corrected deliberately by whoever owns that ledger's prose.
The line
scripts/check-driver-conformance.mjs, FILTER_TEXT requirement 3 (≈ lines 332–339 onorigin/main@3e8e669):Why it is wrong
It was already false when written.
objectql'shavingface (having-filter.tsunknownOperator()) had two barenew Errorreturns escaping the same envelope — measuredcode: undefined/status: undefinedon both the retired and the unknown branch (#6993's census, #7047's card).The "five" in that paragraph counts the five DRIVER faces, which is correct for the requirement's own scope. The trailing clause is not scoped that way: "the last place a bare
new Errorescaped the ADR-0112 envelope" is a repo-wide claim, andhavingwas a sixth place it escaped from.After #7047
#7047 puts both
havingreturns in the envelope, so the repo-wide claim becomes true — but it now attributes the milestone to the wrong site. driver-mongodb's arm was not the last one;havingwas. A reader auditing envelope coverage from this sentence would stop one face early, which is exactly what happened.Suggested fix
Scope the clause to the driver family and name where the actual last one landed, e.g.:
That last half-sentence is worth keeping rather than deleting: this gate not covering
havingis the reason two consecutive defects on that face (#5905, #7047) were found by hand-run censuses instead of by CI.Related
having拒收 retired/unknown 算子时缺 ADR-0112 信封(裸Error,无code/status)—— 五个拒收面中唯一一个 #7047 — the envelope fix (having)packages/spec/src/data— including "$icontains… implemented by nobody" in the very file #6947's fix points@seeat #6993 — the five-face execution census$regex响亮拒收 +$icontains各后端实现(#4706 裁决 B 案 · 驱动半边) #5702 — the retirement PR this paragraph records