Skip to content

fix(runtime): restate pending-registration verdict doc comment in post-#9106 terms#10033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-elon merged 1 commit into from
Aug 19, 2026
+12 −2
Merged

fix(runtime): restate pending-registration verdict doc comment in post-#9106 terms #10033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/pending-registration-verdict-doc.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@objectstack/runtime': patch
---

Restate the `CodeVerdict.pending-registration` doc comment in `dispatcher-error-vocabulary.ts` in post-#9106 terms.

The doc comment said the verdict "reaches a wire `error.code` verbatim" and "the body cannot parse" — both false since #9106 narrowed the dispatcher door: the unregistered spelling now rides the wire's `declaredCode` instead of `error.code`, so the body parses, and what an unswept producer loses instead is its semantic code, silently demoted off `error.code` until registered. The file's own module header and the gate script's header already said so; only the verdict doc comment was the holdout, and it is the classification guide a future `unclassified-site` finding gets picked from. Prose only — `verdict:` values, row data and the gate script are unchanged; `check:dispatcher-error-vocabulary` parses `verdict:` textually with comments masked, so no gate reads this text and no behaviour moves.
7 changes: 5 additions & 2 deletions packages/runtime/src/dispatcher-error-vocabulary.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,11 @@ export type CodeDoor = 'dispatcher' | 'rest' | 'plugin-route' | 'none';

export type CodeVerdict =
/**
* Reaches a wire `error.code` verbatim and the ledger does not know it.
* The body cannot parse. ⇒ #8846's registration input.
* Reaches a wire and the ledger does not know it. Since #9106 the door
* narrows — the unregistered spelling rides the wire's `declaredCode`
* instead of `error.code`, so the body now parses; the producer's
* semantic code is silently demoted off `error.code` until registered.
* ⇒ #8846's registration input.
*/
| 'pending-registration'
/**
Expand Down
Loading