Skip to content

fix: output Vercel serverless function to dist/api/ to match outputDirectory#1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Mar 31, 2026
Merged

fix: output Vercel serverless function to dist/api/ to match outputDirectory #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61955f7
Initial plan
Copilot Mar 31, 2026
b4ab44b
fix: output serverless function to dist/api/index.js to match Vercel …
Copilot Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .changeset/fix-vercel-api-html-response.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,14 @@

Fix Vercel deployment API endpoints returning HTML instead of JSON.

Replace the custom `getRequestListener` export in `server/index.ts` with the
standard `handle()` adapter from `@hono/node-server/vercel` and the
outer→inner Hono delegation pattern (`inner.fetch(c.req.raw)`).
The `bundle-api.mjs` script was emitting the serverless function to `api/index.js`
at the project root, but `vercel.json` sets `outputDirectory: "dist"` — causing
Vercel to never find the function entrypoint and fall back to the SPA HTML route
for all `/api/*` requests.

- The `handle()` adapter correctly wraps the Hono app with the
`(IncomingMessage, ServerResponse) => Promise<void>` signature that
Vercel's Node.js runtime expects for serverless functions in `api/`.
- `@hono/node-server/vercel`'s `getRequestListener()` already handles
Vercel's pre-buffered `rawBody` natively, removing the need for the
custom body-extraction helper.
- The outer→inner delegation pattern matches the documented ObjectStack
Vercel deployment guide and the `@objectstack/hono` adapter test suite.
- Change esbuild `outfile` from `api/index.js` to `dist/api/index.js` so the
bundled serverless function lands inside the Vercel output directory.
- Add explicit `functions` config in `vercel.json` pointing to `api/index.js`
(relative to `outputDirectory`) with `@vercel/node@3` runtime.
- Remove obsolete `.gitignore` entries for `api/index.js` and `api/index.js.map`
(now emitted under `dist/` which is already git-ignored).
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
to `:memory:` (ephemeral SQLite). This ensures data persistence across serverless function
invocations on Vercel. The browser MSW mock kernel remains unchanged (InMemoryDriver).

### Fixed
- **Vercel API always returns HTML — serverless function entrypoint not found** — The `bundle-api.mjs`
script was emitting `api/index.js` at the project root, but `vercel.json` sets `outputDirectory: "dist"`,
so Vercel could not discover the serverless function and fell back to the SPA HTML route for all
`/api/*` requests. Changed esbuild `outfile` to `dist/api/index.js` and added explicit `functions`
config in `vercel.json` with `@vercel/node@3` runtime.
Comment on lines +42 to +47

CopilotAIMar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two separate ### Fixed sections under the [Unreleased] heading (this one and another later in the same section). Consider moving this new bullet into the existing [Unreleased]### Fixed section to keep the changelog structure consistent and easier to scan.

Copilot uses AI. Check for mistakes.

### Added
- **Batch schema sync for remote DDL in kernel bootstrap** — `ObjectQLPlugin.syncRegisteredSchemas()`
now groups objects by driver and uses `syncSchemasBatch()` when the driver advertises
Expand Down
2 changes: 0 additions & 2 deletions apps/studio/.gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,6 @@ pnpm-lock.yaml
dist
build
*.tsbuildinfo
api/index.js
api/index.js.map

# Development
.vite
Expand Down
4 changes: 2 additions & 2 deletions apps/studio/scripts/bundle-api.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,11 @@ await build({
platform: 'node',
format: 'esm',
target: 'es2020',
outfile: 'api/index.js',
outfile: 'dist/api/index.js',
sourcemap: true,
external: EXTERNAL,
// Silence warnings about optional/unused require() calls in knex drivers
logOverride: { 'require-resolve-not-external': 'silent' },
});

console.log('[bundle-api] Bundled server/index.ts → api/index.js');
console.log('[bundle-api] Bundled server/index.ts → dist/api/index.js');
5 changes: 5 additions & 0 deletions apps/studio/vercel.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
"installCommand": "cd ../.. && pnpm install",
"buildCommand": "cd ../.. && pnpm turbo run build --filter=@objectstack/studio && cd apps/studio && node scripts/bundle-api.mjs",
"outputDirectory": "dist",
"functions": {
"api/index.js": {
"runtime": "@vercel/node@3"
}
},
"build": {
"env": {
"VITE_RUNTIME_MODE": "server",
Expand Down
Loading