Uh oh!
There was an error while loading. Please reload this page.
test(qa-checklist): record-share-grant-revoke r4 from its first-ever run at 4a7b3604c - #10083
Merged
os-warren merged 1 commit intoAug 20, 2026
Conversation
…cope probe before the revoke The first execution of this item at revision 3 (it became runnable only when #9697 retargeted its evaluate clause) found the steps' ordering left clause 6's own evidence requirement unsatisfiable: the mis-scoped-revoke probe was ordered AFTER the real revoke, by which point the shareId no longer exists, so the refusal it observes is the ordinary missing-share 404 and says nothing about record scoping. The probe now runs while the share still exists, and the note-creation step creates the second record it needs. Also corrects the manager-position fixture note: since #9237 the stock boot already holds a manager (the seeded dev admin) and materialises the grant, so a bare evaluate answers grantsCreated 0 out of idempotence rather than an empty recipient expansion — which the old text told the runner to read as a fixture gap. Steps and fixture prose only; no acceptance clause changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PnJHU45vPJj5UQrxe946Bx
os-warren
marked this pull request as ready for review
August 20, 2026 01:07
Uh oh!
There was an error while loading. Please reload this page.
os-warren
deleted the
claude/issue-9702-record-share-grant-revoke-followup-run
branch
August 20, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9702
The owed follow-up run for
access-security.record-share-grant-revokeis done. Run record: #10085 (qa-run). This PR carries only what the run changed in the tree: the item's revision 4. Nothing else from a run lands in the repo, per RUNNER.md.What the run was
access-security.record-share-grant-revokewas executable for the first time: PR #9697 (#9237) retargeted its evaluate clause offshare_red_projects_with_execs, whoseevaluatewas refusedSHARING_NOT_ENABLEDbecauseshowcase_projectispublic_read_write. Per #9308's sequencing ruling this is a dedicated run at a new sha onmain— it is deliberately not attached to wave #9296's pinnede4e5c6e3baseline.4a7b3604c(both4012a70cdand06f9848f9verified as ancestors)access-security.record-share-grant-revokebecomes runnable for the first time when #9237 lands — it needs a dedicated run at a new sha #9702 itself, and was not taken here.Why revision 4
Two things the first execution paid for, both prose, no acceptance clause changed:
The revoke-scope probe was ordered after the real revoke. Clause 6 asks for
DELETEthrough a different record's path to be refused and the share to still exist (re-read). Following the steps literally, theshareIdis already gone by then, so the refusal observed is the ordinary missing-share404and proves nothing about record scoping — the clause's own evidence requirement is unsatisfiable. The probe now runs while the share still exists, and the note-creation step creates the second record it needs. Run that way the probe is meaningful:404 NOT_FOUNDnaming both the share and the wrong record, with the share surviving and still readable by the grantee.The manager-position fixture note now reads correctly against the post-app-showcase: two sharing rules declared on objects without record sharing enabled — boot backfill fails, rules never take effect #9237 seeds. The old text told a runner that
grantsCreated 0means an empty recipient expansion, i.e. a fixture gap. Measured on a stock boot: the seeded dev admin already holdsmanager(sys_user_positionusp_showcase_admin_manager) and the boot backfill already materialises the grant, so a bare evaluate answersgrantsCreated 0out of idempotence — confirmed directly ({matchedRecords: 1, expandedUsers: 1, grantsCreated: 0}with the row already present). Assigning the position to one more persona is what makes a created grant observable (expandedUsers 2,grantsCreated 1).Verification
node scripts/check-platform-checklist.mjs—OK -- 15 areas, 190 items (190 active); coverage: 30 kinds mapped, 0 waived.node scripts/check-nul-bytes.mjs—OK (scanned 6367 text file(s) ... no raw ASCII control bytes).node scripts/pm/dispatch-gates.mjs— derived from the merge base, this change set matches no path-scheduled check family.node scripts/checklist-select.mjs access-security.record-share-grant-revoke --json— resolves atrevision 4.All run at
6a22731ab, the branch head.No changeset: QA checklist steps are internal test material, nothing user-visible ships from this. Labeled
skip-changeset(read back after writing).Refs: #10085 (the run record) · #9697 / #9237 (made the item runnable) · #9308 (the sequencing ruling) · #9296 (the wave)
Generated by Claude Code