Skip to content

fix(app-showcase): shut down kernels before disconnecting drivers in approval-resume-relation-expand.test.ts#10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-warren merged 2 commits into from
Aug 21, 2026
+11 −3
Merged

fix(app-showcase): shut down kernels before disconnecting drivers in approval-resume-relation-expand.test.ts #10767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6727d3
fix(app-showcase): shut down kernels before disconnecting drivers in …
claude Aug 21, 2026
bb80eac
fix(app-showcase): correct the teardown comment to match the measurement
claude Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions examples/app-showcase/test/approval-resume-relation-expand.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,12 +68,20 @@ const sleep = (ms: number) => new Promise((r) => setTimeout(r, ms));
const openKernels: Array<{ shutdown?: () => Promise<void> }> = [];
const openDrivers: Array<{ disconnect?: () => Promise<void> }> = [];
afterEach(async () => {
while (openDrivers.length) {
try { await openDrivers.pop()?.disconnect?.(); } catch { /* noop */ }
}
// Kernels first, drivers second: the kernel's own teardown still wants a
// live driver to drain against -- that is the rule, regardless of what it
// costs on any given day.
//
// Measured here (#10373): this file's own DATABASE_ERROR lines are all
// "no such table" probes against sys_* tables bootShowcaseApprovals()
// never provisions, not post-disconnect reads -- swapping the order left
// the count unchanged (36 suite-wide / 31 in this file, before and after).
while (openKernels.length) {
try { await openKernels.pop()?.shutdown?.(); } catch { /* noop */ }
}
while (openDrivers.length) {
try { await openDrivers.pop()?.disconnect?.(); } catch { /* noop */ }
}
});

interface Booted {
Expand Down
Loading