Skip to content

docs(ci): correct the shard-classifier comment to describe the post-#6589 classifier#10817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 2 commits into from
Aug 21, 2026
Merged

docs(ci): correct the shard-classifier comment to describe the post-#6589 classifier #10817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6e53c
docs(ci): correct the shard-classifier comment to describe the post-#…
claude Aug 21, 2026
4aa3ca4
Merge branch 'main' into claude/issue-10713-shard-classifier-comment
claude[bot] Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -403,19 +403,25 @@ jobs:
# the guard for the day that changes, not the normal path.
#
# `git cat-file -e` rather than the more idiomatic strict
# `git rev-parse` spelling, and the reason is not style.
# check-shard-attestation.mjs classifies a job as an aggregate GATE
# when the job's joined `run:` text contains BOTH the string
# "check-shard-attestation.mjs" and, as a bare substring, that
# script's own dash-dash-verify flag. This job already carries the
# first (its --emit step at the bottom), so spelling that flag
# anywhere in this step — including in a comment, since comments
# are part of `run:` — silently reclassifies the shard job as a
# gate. The drift guard then fails with two complaints that name
# nothing to do with the real edit ("its job-level if: is not
# always()", "never downloads the shard attestations it claims to
# count"). Measured both ways on this very change; do not "tidy"
# this back.
# `git rev-parse --verify` spelling. That is history rather than
# style, and it is written down because it used to be a live
# hazard: the pre-#6589 check-shard-attestation.mjs classified a
# job as an aggregate GATE when the script's basename and its
# `--verify` flag merely CO-OCCURRED as substrings anywhere in
# the job's joined `run:` text. This job always carries the
# basename (its `--emit` step at the bottom), so spelling
# `--verify` anywhere in this step — comments included, since
# they were part of `run:` — silently reclassified the shard job
# as a gate.
#
# #6589 closed that by construction. Classification is now by
# INVOCATION: within one command the flag must follow the
# script's own name as an argument, the test is applied per STEP
# and never over the job's joined text, and the lexer drops shell
# comments — all three pinned by that script's `--self-test`,
# which is why this comment can now name the flag at all. Either
# spelling is safe here; `git cat-file -e` stays because
# churning it would buy nothing.
if ! git cat-file -e "refs/remotes/origin/$BASE_REF^{commit}" 2>/dev/null; then
git fetch --no-tags --quiet origin "+refs/heads/$BASE_REF:refs/remotes/origin/$BASE_REF" \
|| echo "::warning::Could not fetch origin/$BASE_REF; the merge-base resolution below will decide."
Expand Down
Loading