Skip to content

fix(docs): type-check apps/docs with next typegen, and delete the dead types:check#10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Aug 21, 2026
Merged

fix(docs): type-check apps/docs with next typegen, and delete the dead types:check#10879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/docs/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,8 @@
"build": "pnpm --filter @objectstack/spec gen:schema && pnpm --filter @objectstack/spec gen:docs && NODE_OPTIONS='--max-old-space-size=4096' next build",
"start": "next start",
"site:lint": "next lint",
"types:check": "fumadocs-mdx && next typegen && tsc --noEmit",
"postinstall": "fumadocs-mdx",
"typecheck": "tsc --noEmit"
"typecheck": "fumadocs-mdx && next typegen && tsc --noEmit"
},
"dependencies": {
"fumadocs-core": "16.14.4",
Expand Down
24 changes: 24 additions & 0 deletions apps/docs/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,30 @@
]
}
},
// `typecheck` runs `next typegen` before tsc on purpose, and these two
// `.next` globs are why. Next writes both of them itself
// (`writeConfigurationDefaults`) and re-adds either one on the next
// `next dev` / `next build` if you delete it -- measured by running that
// routine against a narrowed copy of this file: the `dev` glob came
// straight back and the file was rewritten. This array cannot be narrowed,
// so the honesty has to come from the script instead.
//
// .next/types/** produced by the `next typegen` that the `typecheck`
// script now runs itself, so the checked program is a
// function of source rather than of whatever `.next` an
// earlier build happened to leave behind. A bare
// `tsc --noEmit` here passed over a broken route
// signature precisely because these files were absent.
// .next/dev/types/** written only by `next dev`. Next's own build-mode
// type check filters this directory OUT of the program
// (`getDevTypesPath`, lib/typescript/runTypeCheck.js)
// "to prevent stale dev types from causing errors when
// routes have been deleted since the last dev session".
// Plain tsc has no such filter, so a leftover dev
// session can only add a local false RED here, never a
// false green. Remedy: `rm -rf apps/docs/.next`.
//
// Do not reduce `typecheck` back to a bare `tsc --noEmit`.
"include": [
"next-env.d.ts",
"**/*.ts",
Expand Down
Loading