Merge duplicate list_objects/list_metadata_objects and describe_object/describe_metadata_object tools by Copilot · Pull Request #1091 · objectstack-ai/objectstack

Copilot · 2026-04-08T09:23:53Z

list_objects and list_metadata_objects share the same data source (metadataService.listObjects()), with list_objects being a strictly weaker subset (no filter/includeFields). Same duplication exists for describe_object/describe_metadata_object. This created naming confusion, duplicate ObjectDef/FieldDef types, and gave data_chat agent inferior capabilities.

Changes

Unified tool definitions: Created list-objects.tool.ts and describe-object.tool.ts with the richer parameter sets (filter, includeFields, snake_case validation, enableFeatures). Deleted list-metadata-objects.tool.ts and describe-metadata-object.tool.ts.
data-tools.ts: Removed LIST_OBJECTS_TOOL, DESCRIBE_OBJECT_TOOL, their handlers, and duplicate ObjectDef/FieldDef types. DATA_TOOL_DEFINITIONS: 5 → 3 tools (query_records, get_record, aggregate_data). DataToolContext no longer requires metadataService.
metadata-tools.ts: METADATA_TOOL_DEFINITIONS retains 6 tools, now registering list_objects and describe_object (unified names) with the full-capability handlers.
Agents: metadata_assistant references updated from list_metadata_objects/describe_metadata_object → list_objects/describe_object. data_chat already used these names — no change needed.
Exports: Updated tools/index.ts and src/index.ts — listObjectsTool/describeObjectTool replace listMetadataObjectsTool/describeMetadataObjectTool.

Registration flow

Both agents get list_objects/describe_object from registerMetadataTools(), which only requires metadataService (always available when data tools are registered):

plugin.start()
├─ registerDataTools(registry, { dataEngine }) → 3 tools
└─ registerMetadataTools(registry, { metadataService }) → 6 tools (includes list_objects, describe_object)

vercel · 2026-04-08T09:23:58Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
objectstack-play	Ready	Preview, Comment	Apr 8, 2026 9:59am
spec	Ready	Preview, Comment	Apr 8, 2026 9:59am

…_metadata_object tool pairs - Created unified `list-objects.tool.ts` (name: 'list_objects') with filter/includeFields - Created unified `describe-object.tool.ts` (name: 'describe_object') with snake_case validation - Deleted old `list-metadata-objects.tool.ts` and `describe-metadata-object.tool.ts` - Removed duplicate LIST_OBJECTS_TOOL, DESCRIBE_OBJECT_TOOL from data-tools.ts - Removed duplicate ObjectDef/FieldDef types from data-tools.ts - DATA_TOOL_DEFINITIONS reduced from 5 to 3 (query_records, get_record, aggregate_data) - METADATA_TOOL_DEFINITIONS retains 6 tools with unified names - Updated metadata_assistant agent to use list_objects/describe_object - Updated all tests across service-ai and studio - Updated CHANGELOG.md Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/9ed2bcd9-23a4-4f4d-b8ba-770577f41cb3 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Copilot

Pull request overview

This PR removes the duplicate list_objects/describe_object implementations that previously existed in both “data tools” and “metadata tools”, and standardizes on a single richer implementation registered via registerMetadataTools() so both data_chat and metadata_assistant share identical capabilities.

Changes:

Consolidated list_objects and describe_object tool metadata under unified tool definitions and removed the duplicate data-tools versions/types/handlers.
Simplified DATA_TOOL_DEFINITIONS to the 3 record-level tools and updated DataToolContext to no longer require metadataService.
Updated agents/tests/exports/changelog to use the unified tool names and new output shapes.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/services/service-ai/src/tools/metadata-tools.ts	Swaps tool exports/registrations to unified `list_objects`/`describe_object`.
packages/services/service-ai/src/tools/list-objects.tool.ts	Renames tool metadata to `list_objects` (unified).
packages/services/service-ai/src/tools/describe-object.tool.ts	Adds unified `describe_object` tool metadata file.
packages/services/service-ai/src/tools/describe-metadata-object.tool.ts	Removes the old duplicate `describe_metadata_object` tool metadata.
packages/services/service-ai/src/tools/index.ts	Updates tool exports to the unified names.
packages/services/service-ai/src/tools/data-tools.ts	Removes list/describe tools and drops `metadataService` from `DataToolContext`/registration.
packages/services/service-ai/src/plugin.ts	Updates `registerDataTools()` call site to pass only `{ dataEngine }`.
packages/services/service-ai/src/index.ts	Re-exports unified tool metadata from `metadata-tools`.
packages/services/service-ai/src/agents/metadata-assistant-agent.ts	Updates agent instructions/tool list to `list_objects`/`describe_object`.
packages/services/service-ai/src/tests/metadata-tools.test.ts	Updates tool names and asserts unified registration behavior.
packages/services/service-ai/src/tests/chatbot-features.test.ts	Updates tool counts and moves list/describe expectations to metadata-tool registration.
apps/studio/test/ai-chat-panel.test.tsx	Updates tool invocation part name to `list_objects`.
CHANGELOG.md	Documents the tool unification and tool-definition split change.

Copilot · 2026-04-08T09:48:55Z

@@ -258,7 +258,7 @@ export class AIServicePlugin implements Plugin {
 try {
 const dataEngine = ctx.getService<IDataEngine>('data');
 if (dataEngine && metadataService) {
- registerDataTools(this.service.toolRegistry, { dataEngine, metadataService });
+ registerDataTools(this.service.toolRegistry, { dataEngine });
 ctx.logger.info('[AI] Built-in data tools registered');


registerDataTools() no longer requires metadataService, but this block still gates data-tool registration on metadataService being present (if (dataEngine && metadataService)). This can prevent query_records/get_record/aggregate_data from being registered in runtimes where the data engine exists but metadata is unavailable. Consider registering data tools whenever dataEngine is available, and keep the agent auto-registration (which does require metadataService) behind a separate if (metadataService) check.

Copilot · 2026-04-08T09:48:56Z

 registry: ToolRegistry,
 context: DataToolContext,
 ): void {
- registry.register(LIST_OBJECTS_TOOL, createListObjectsHandler(context));
- registry.register(DESCRIBE_OBJECT_TOOL, createDescribeObjectHandler(context));
 registry.register(QUERY_RECORDS_TOOL, createQueryRecordsHandler(context));
 registry.register(GET_RECORD_TOOL, createGetRecordHandler(context));
 registry.register(AGGREGATE_DATA_TOOL, createAggregateDataHandler(context));


registerDataTools() signature now only takes { dataEngine }, but the doc comment immediately above still states it’s called after the metadata service is available and the example passes metadataService. Update the JSDoc/example to match the new DataToolContext so callers don’t attempt to provide a non-existent dependency.

hotlong · 2026-04-08T09:52:38Z

@copilot fix all

…stale JSDoc - plugin.ts: Register data tools whenever dataEngine is available, not gated on metadataService. Agent auto-registration still requires metadataService and is nested inside a separate check. - data-tools.ts: Update JSDoc/example to match new DataToolContext (no longer references metadataService). Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/f69965e4-42f5-4f19-84ef-74c854bdf5ac Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Copilot · 2026-04-08T09:56:08Z

@copilot fix all

Fixed both review comments in 5543980:

plugin.ts: Data tools (query_records, get_record, aggregate_data) are now registered whenever dataEngine is available, no longer gated on metadataService. Agent auto-registration (data_chat) remains behind a nested if (metadataService) check since it requires persistence.
data-tools.ts: Updated JSDoc and example to match the new DataToolContext — no longer references metadataService.

Initial plan
63ea40d

CopilotAI assigned Copilot and hotlong Apr 8, 2026

Copilotstarted work on behalf of hotlong April 8, 2026 09:23 View session

CopilotAI linked an issue Apr 8, 2026 that may be closed by this pull request
list_objects list_metadata_objects 功能完全一致，应该合并 #1090
Closed

vercelBotdeployed to Preview – spec April 8, 2026 09:34 View deployment

vercelBotdeployed to Preview – objectstack-play April 8, 2026 09:35 View deployment

CopilotAI changed the title ~~[WIP] Merge list_objects and list_metadata_objects functionality~~Merge duplicate list_objects/list_metadata_objects and describe_object/describe_metadata_object toolsApr 8, 2026

CopilotAI requested a review from hotlong April 8, 2026 09:38

Copilotfinished work on behalf of hotlong April 8, 2026 09:38

vercelBotdeployed to Preview – objectstack-play April 8, 2026 09:39 View deployment

vercelBotdeployed to Preview – spec April 8, 2026 09:42 View deployment

hotlong marked this pull request as ready for review April 8, 2026 09:44

CopilotAI review requested due to automatic review settings April 8, 2026 09:44

Copilotstarted reviewing on behalf of hotlong April 8, 2026 09:45 View session

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Copilotstarted work on behalf of hotlong April 8, 2026 09:52 View session

Copilotfinished work on behalf of hotlong April 8, 2026 09:58

vercelBotdeployed to Preview – spec April 8, 2026 09:58 View deployment

hotlong merged commit d22209d into mainApr 8, 2026
2 of 3 checks passed

vercelBotdeployed to Preview – objectstack-play April 8, 2026 09:59 View deployment

os-zhuang mentioned this pull request Aug 4, 2026
fix(auth): organization/create 判权威的 OS_TENANCY_POSTURE，不再判被降级的 OS_MULTI_ORG_ENABLED (#5233) #5267
Merged

claudeBot mentioned this pull request Aug 4, 2026
organization/create 的闸门读的是被降级的 OS_MULTI_ORG_ENABLED，不是权威的 OS_TENANCY_POSTURE —— 只设权威 knob 的有墙部署，引导式「创建工作区」是死路 #5233
Closed

os-zhuang mentioned this pull request Aug 4, 2026
[PM] 分片分工登记表 — 谁在管哪个仓库的队列 #4604
Closed

Navigation Menu

Uh oh!

Merge duplicate list_objects/list_metadata_objects and describe_object/describe_metadata_object tools - #1091

Merge duplicate list_objects/list_metadata_objects and describe_object/describe_metadata_object tools#1091
hotlong merged 3 commits into
mainfrom
copilot/merge-list-objects-and-metadata-objects

CopilotAI commented Apr 8, 2026•
edited
Loading

Uh oh!

vercelBot commented Apr 8, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAIApr 8, 2026

Uh oh!

CopilotAIApr 8, 2026

Uh oh!

hotlong commented Apr 8, 2026

Uh oh!

CopilotAI commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

CopilotAI commented Apr 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Registration flow

Uh oh!

vercelBot commented Apr 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAIApr 8, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIApr 8, 2026

Choose a reason for hiding this comment

Uh oh!

hotlong commented Apr 8, 2026

Uh oh!

CopilotAI commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Apr 8, 2026•
edited
Loading

vercelBot commented Apr 8, 2026•
edited
Loading