fix(security,sharing): materialize the RBAC catalog per organization

[os-warren]

Fixes#10103

Implements the maintainer ruling of 2026-08-20 04:12Z (Option C — per-organization materialization, four ruled points) and the 09:17Z ruling resolving Q1/Q2/Q3. Neither is re-litigated here.

target:v17 release blocker, routed from cloud#1406. Independently reproduced from an app project (titanwind EHR) in the 08:46Z comment.

The defect, restated from the measurement

On a walled posture (group / isolated) every principal — an organization owner and a platform admin alike — listed zero positions, permission sets and sharing rules while the tables held rows. Nothing could be bound through Setup, and a declared hierarchy-security could never be armed.

Every row in those three tables was organization-less. plugin-security's Layer 0 composes a strict organization_id = :tenant, and the middleware ANDs it into the read AST over the driver's (organization_id = :tenant OR organization_id IS NULL). The conjunction of the two is the strict equality alone, so the driver's null arm was annihilated on every authenticated read.

The wall is not changed, at either layer (ruled point 3). tenant-layer.ts and driver-sql/src/sql-driver.ts are untouched — they do not appear in the diff. The rows get an owner instead.

What landed

The four seeders — bootstrapDeclaredPositions, bootstrapBuiltinRoles, bootstrapDeclaredPermissions (plugin-security) and bootstrapDeclaredSharingRules (plugin-sharing) — upsert by (name, organization_id) and run one pass per organization under a walled posture, following #8617's landed pattern in this same plugin. The framework built-ins (platform_admin, org_*, everyone, guest) get a per-organization copy, as the ruling explicitly includes: sys_user_position is already per-organization, and both objects spell their own name index unique: 'organization'. single posture keeps exactly one organization-less pass, byte for byte the pre-existing behaviour — the ruled carve-out.

Seeding also fires on organization creation (ruled point 2), not only at kernel:ready. Re-derived: the ruling cited security-plugin.ts:2937-2962 for this, and that citation is now stale — on current main those lines are the everyone-anchor baseline binding, the kernel:ready hook sits at 3056 and the first-user-insert re-run at 3074-3084, and the note at 3160 records that the per-organization seed data replay moved to @objectstack/organizations. There was no organization-creation trigger for the RBAC catalog at all. Both plugins now register one, walled postures only, refusing to fall back to an organization-less pass when the new id cannot be read.

(a) How the loud guard replaces the reap, and the M3 pin

Q1+Q2 collapsed the reap and the remap on the maintainer's supplied premise: 「新项目还没上线，不需要清理旧数据，也没有老客户升级」and 「titanwind EHR 不是 saas 模式运行的，是本地单库的企业版」. So no reap machinery and no remap/migration machinery ships here.

A reap would also be the wrong instrument on these tables independently of that premise, and the source says so: the rows a reap would delete are grant targets — sys_user_position, sys_position_permission_set, sys_user_permission_set and sys_record_share all point at them by row id. #8617's reap could promise "NO grant changes" precisely because it never touched a junction table; here the junctions are the grants.

What ships instead is warnPreFixOrganizationLessRows: under a walled posture, a per-organization pass that meets pre-fix organization-less rows for names it would seed emits one warning naming the rows and the remedy (re-initialize, or adopt by hand by stamping the owning organization), and states that nothing was deleted and why.

The load-bearing half is that the pass still creates that organization's own copies. The measured M3 failure was the silent no-op: a tenant-threaded pass sees the pre-fix row through the driver's compatibility arm, reads the name as already represented, takes the update branch, and creates nothing — leaving the deployment as broken as before while reporting success. resolveOwnOrganizationRow is the single read that tells "this organization has its row" apart from "somebody's organization-less row is visible here", and every seeder routes through it.

Pinned by case 3 of per-organization-catalog.test.ts, which reproduces a pre-fix deployment through the real seeders and then asserts, separately: the per-organization copies exist (everyone now has an org_jia row, an org_yi row and the untouched organization-less one); the guard fired per organization, naming everyone and sales_manager; the message carries re-initialize, adopt and NOT deleted; and nothing was reaped.

Q1's platform-defaults residue (bootstrapPlatformAdmin's three sets, the ADR-0094 env-door projection) stays outside this card, unreaped, as ruled. The shared projection helpers gained an optionalorganizationId so the environment door's behaviour is byte-unchanged.

(b) The deal_p1 assertion — kept verbatim, retitled

Re-derived from the current file rather than the snippet on the card. packages/plugins/plugin-sharing/src/rule-criteria-org-scope.test.ts:263 reads expect(granted).toEqual(['deal_a1', 'deal_p1']), where deal_p1 is an os10119_dealbusiness record with organization_id = NULL.

The assertion is unchanged. What changed is its justification, in three places (file header, fixture table, inline comment).

The reasoning: ruled point 4 makes D-invalid the single general rule and demotes D-global to a driver-level compatibility note. Ruled point 3 leaves the wall untouched, so applyTenantScope still emits its OR organization_id IS NULL arm — that arm is the compatibility behaviour the ruling preserves. An org-stamped rule routed through it therefore still matches an organization-less record, and the expected value stays correct.

The axis this case actually pins is the third direction its own header names: chokepoint-routing versus a bare-equality reimplementation. That axis is unaffected by which doctrine justifies the arm — the case would be equally load-bearing if the arm existed for no reason at all. So deleting it would cost the suite its most valuable part, and weakening it to a bare-equality expectation would pin the defect. What is now wrong is only reading it as an endorsement of NULL-means-global, and the comments now say so explicitly, in the ruling's own "historical behaviour superseded by this ruling" language.

Verified green as its own run: all 4 cases pass, including this one.

⛔ The ADR-0120 D3 and sql-driver.ts comment retitles are not in this PR — they are a separate maintainer-merged docs pass, as Q3 ruled. docs/adr is untouched.

Q3 — the file surface widened, deliberately

Both halves land here, because the cross-organization bleed only exists once per-organization copies exist and no intermediate version may ship with copies present and the sweep global:

• packages/core/src/security/resolve-authz-context.ts — the section 6a name-sweep. Re-derived: it is at line 501 now (the prior seat's :497 cited the ADMIN_FULL_ACCESS derivation, which is at 497 and is untouched — see the fork note below). It swept sys_position by name across every organization, and the junction read behind it then collected another organization's everyone binding. Scoped by threading the organization into the context, not by adding an organization_id predicate at the call site: the driver's applyTenantScope is the one governed spelling of this wall, and a bare equality written here would be a second ungoverned implementation of it — the exact shape that produced this card's defect. The limit rises with it so the cap admits this organization's rows alongside any organization-less ones, which stay reachable on purpose since grants point at them.
• plugin-security's dbLoader — resolved sets by name under a bare { isSystem: true } with limit: names.length. Correct while one row existed per name; a truncation the moment copies exist. Now a factory parameterised by the caller's organization, with a bounded but wider limit, preferring the organization's own row per name.

(c) Boot reconciliation stays O(changed declarations)

Each pass issues a write only where a declaration actually differs. After the merge this rides #11116's landed mechanism: one batched $in existence read per organization for the whole declaration, then positionRecordDiffers / recordDiffersFromBody deciding per row. bootstrapBuiltinRoles, which #11116 did not convert, uses rowMatchesDeclaration for the same purpose. On the common boot, where nothing declared changed, every organization costs one batched read and zero writes. Steady state does not ride this sweep at all; it rides the organization-creation hook, which seeds exactly the one new organization. Per-request authz resolution stays O(the caller's own organization's catalog) — the 6a sweep was O(organizations) before this change and is not now.

Cross-link: #10119 / PR #10422 — the criteria-sweep org scoping is the third leg, and makes per-organization rules cheaper than the unscoped sweep they replace.

Merged with #11116, which landed in the same seeders mid-run

main advanced during this work and 5337ef162 (#11116 / #10946, batch the identity boot seeds' existence read and skip no-op writes) landed in two of the same files, solving the same round-trip concern I had solved per-name. The merge conflicted, and it was resolved by adopting their design and layering the organization scope onto it rather than keeping mine:

• their seed-name-lookup.ts batches the whole declaration into one $in read and — the part that matters — distinguishes three outcomes, present / absent / unknown, so a read that could not answer is never read as "none of these exist". That is strictly better than the per-name read I had written, and my rowMatchesDeclaration no-op skip is superseded by their positionRecordDiffers / recordDiffersFromBody.
• their oracle needed one change to stay correct under per-organization copies: "first row wins" stops being right. A scoped page carries this organization's row and an organization-less leftover for the same name, in driver order, so taking whichever arrived first would let a pre-fix row answer for this organization — the exact silent no-op above, reintroduced through the batching. The page now keeps every row per name, the read is threaded with the organization, and the leftover comes back on the absent result as organizationLessResidue so the caller both creates the copy and reports the leftover. Their limit: names.length is widened when scoped, for the same truncation reason as the dbLoader.
• a third commit collapses the two resolutions that the merge left behind into one: seed-name-lookup.ts delegates to resolveOwnOrganizationRow and only translates its answer. One question, one implementation — two spellings of it is precisely the shape that produced this card's defect.

Their new bootstrap-seed-round-trips.test.ts (420 lines) passes unchanged alongside the scoping, which is the compatibility signal worth having.

Proof

Behavioural, on a real ObjectQL + better-sqlite3 SqlDriver, through the real shipped seeders — the standard the prior seat set. New suite packages/plugins/plugin-security/src/per-organization-catalog.test.ts, 6 cases: rows stamped per organization; the read that measured ZERO now returns the organization's own catalog and only its own; the M3 guard (above); the single carve-out with the guard silent; a second pass writing nothing; and the cross-organization bleed closed against the realresolveUserAuthzGrants imported from @objectstack/core, with a positive control in the same case so the negative assertion cannot pass by the resolver having stopped resolving.

Ablation, signature predicted in writing before either leg ran, and both legs matched exactly:

leg	mutation	predicted	observed
A	resolveOwnOrganizationRow returns the first row regardless of organization (reintroducing M3)	case 3 alone reddens; 1, 2, 4, 5, 6 stay green	case 3 alone reddened — expected [ null ] to deeply equal [ null, 'org_jia', 'org_yi' ], the silent no-op verbatim
B	drop the organization from the core section-6a sweep	case 6 alone reddens on the negative assertion; 1-5 stay green	case 6 alone reddened — expected [ 'jia_wide_grant' ] to not include 'jia_wide_grant'

Leg A was re-run after the merge, on the merged tree, and reproduced the same signature — case 3 alone — with the collapse above meaning that one mutation point now covers all four seeders rather than only the built-in one. Restore byte-identical (b0d3272c…), re-run to a real verdict, 6 passed.

Leg B's suite consumes @objectstack/core through the package exports, i.e. its dist/, so both legs rebuilt core and proved the artifact: ablation-dist-preflight reported the marker present in 2 built files on the mutated leg and absent from all 12 on the restore. Both restores are byte-identical by git hash-object (b0d3272c…, abf4f76b…) and were re-run to a real verdict (6 passed).

Verification

All through the shared verification lock; exit codes captured before any pipe.

• Dependency closure built first — VERDICT command-exit 0.
• pnpm test on the three affected packages, at the final commit 1452fe320: 3 of 3 script names echoed (no silent zero-match), core 887 / sharing 624 / security 1377 — 2888 tests, all passing.
• Typecheck: plugin-security and plugin-sharing clean. Two standing traps were live here and are reported rather than papered over — @objectstack/core has no typecheck script, so a --filter over it exits 0 having run nothing; and both plugin tsconfig files exclude test files. Explicit programs were run for all three: 0 errors in any file this PR touches (core's 98, plugin-security's 11 and plugin-sharing's 3 are pre-existing, all in test files this PR does not touch, which is why those packages carry ledger entries).
• check:i18n first returned PREREQUISITE NOT MET — not a pass. The workspace closure was built and it was re-run to a real verdict: OK, exit 0, plugin-security and plugin-sharing both in sync.
• check:type-check-debt --re-measure on the merged final commit: OK — 33 ledger entries re-measured, 1895 raw errors total, none above its recorded number.

(d) Derived gate union, re-derived on the final commit

node scripts/pm/dispatch-gates.mjs with no paths (the script derives its own change set from the merge base). The union was derived three times — after the fix commit, after the pin commit, and again on the merged head — and re-deriving after the second commit ADDED two families: check:entry-guard and check:parse-guard, pulled in by scripts/engine-double-contract.pinned.json. Both were run. All 23 at 1452fe320, each EXIT=0:

check:entry-guard · check:parse-guard · check:engine-double-contract · check:query-options-erasure · check:where-matcher · check:type-check-coverage · check:authz-resolver · check:changeset-gate-self-tests · check:cross-package-test-inputs · check:kernel-hook-pairs · check:objectui-changeset · check:slot-lookup · check:test-source-alias · check:type-source-resolution · check:i18n · check:nul-bytes · check-adr-0087-registration · check-changeset-no-major · check-ci-filter-parity · check-cross-package-test-inputs · check-empty-changeset · check-plugin-teardown-shape · docs-audit/check-affected-docs — plus check:type-check-debt --re-measure, OK.

The script reports check:driver-memory-census and check-test-completeness.mjs as unreachable by construction (dead package literals), i.e. quiet green for every card in the tree — recorded, not claimed as coverage.

Ledger movement, stated in the required direction:check:engine-double-contract legitimately reddened on my new test's registry-facing seam. Repaired in the code: update() now opens with assertEngineUpdateDispatch(data, options) (the producer's own predicate), and delete() was dropped since no seeder deletes. The gate then asked for the new pinned coverage to be recorded — one row added to engine-double-contract.pinned.json via its own --write. That is the tightening ledger. The shrink-only engine-double-contract.baseline.json is untouched; no measured exemption was added.

(e) Forks

None taken — and the two that could have fired were checked rather than assumed:

• Migration/backfill. Q1+Q2 ruled none is owed, and nothing measured here contradicts that premise. The M3 shape that made a reap look mandatory is closed by the guard plus the create, which needs no migration machinery.
• Platform-admin derivation. The stop-fork was: can packages/core be org-scoped without changing the PLATFORM_ADMIN derivation, which hangs off an unscoped grant pointing at a specific row id? Re-derived on current main: the derivation is if (ps.name === ADMIN_FULL_ACCESS && unscopedUserPsIds.has(ps.id)) at resolve-authz-context.ts:497, keyed on the sys_user_permission_set grant being unscoped. Since nothing is reaped and bootstrapPlatformAdmin stays outside this card, admin_full_access keeps its organization-less row and its row id. The section 6a scoping is a separate read and does not touch line 497. Fork does not fire.
• packages/spec is untouched. So are the wall files.

Clause-② — this PR stays draft

Contract accept/reject change: an organization-less write becomes invalid state under a walled posture. needs:contract-review stays hung on the card. This seat did not clear it, did not mark ready, did not arm auto-merge and did not merge. The ruled tier is CONTRACT_REVIEW_TIER, read live at scripts/pm/dispatch-gates.mjs:2722 — note the 1932 circulating in the 04:17Z claim comment is stale; the constant's value is unchanged.

---

Generated by Claude Code

[github-actions]

📓 Docs Drift Check

This PR changes 3 package(s): @objectstack/core, @objectstack/plugin-security, @objectstack/plugin-sharing, touching 56 documentable anchor(s).

23 hand-written doc(s) name something this change touched — list omitted above 15 rows. Re-derive on the tree named below: node scripts/docs-audit/affected-docs.mjs --json d806081ddecc18631c29121b8d196d3a9a9f702d.

⛔ 8 release-owned page(s) also affected — read-only, see AGENTS.md Documentation Guardrails.

What this run could not see

• 3 name(s) were too generic to anchor anything (single lowercase words)
• the SDK route bridge reached 45 of 221 client-bound route-ledger rows — the other 176 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run: node scripts/docs-audit/affected-docs.mjs --bridge-coverage

Coarse fallback — 33 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d806081ddecc18631c29121b8d196d3a9a9f702d → packageMentionDocs.

Which tree this was computed on

This run read content/docs from bbe964e97e6e2962323efaffb1e8b2ee92a63b7c — the merge of head 1452fe3209bb30e18f7e880295199fa9576630f7 into base d806081ddecc18631c29121b8d196d3a9a9f702d, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin bbe964e97e6e2962323efaffb1e8b2ee92a63b7c && git checkout bbe964e97e6e2962323efaffb1e8b2ee92a63b7c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d806081ddecc18631c29121b8d196d3a9a9f702d 1452fe3209bb30e18f7e880295199fa9576630f7 && git checkout -B drift-repro d806081ddecc18631c29121b8d196d3a9a9f702d && git merge --no-ff 1452fe3209bb30e18f7e880295199fa9576630f7
node scripts/docs-audit/affected-docs.mjs --json d806081ddecc18631c29121b8d196d3a9a9f702d

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d806081ddecc18631c29121b8d196d3a9a9f702d → pass the list as
args.docs, on the commit named under Which tree this was computed on.

[os-warren]

CI is green on 1452fe320, verified by job name. All check runs terminal, zero failures; the only non-success conclusions are Console Pin Gate and Build Docs, both skipped. Verified by enumerating jobs, not by reading a check-suite conclusion — two check_suite.completed: success events arrived on this head while jobs were still running, which has held on every PR in this lane today.

⛔ This PR stays draft on purpose and is NOT waiting on me. The card carries needs:contract-review; draft is the compensating control for developing a Clause-② card below CONTRACT_REVIEW_TIER (this lane's allocation at that tier is exhausted, so it was developed at a lower tier). It waits on a non-dispatching seat's contract review — nothing else blocks it. As the PM seat that dispatched the card, I will not mark it ready, arm auto-merge, or clear the label.

Four things for the reviewer, all in the PR body but easy to lose in its length:

1. ⭐ The most load-bearing change is a repair to something that landed while this PR was being written. PR perf(plugin-security): batch the identity boot seeds' existence read and skip no-op writes #11116 (5337ef162) batched the same seeders' existence read behind seed-name-lookup.ts with a first-row-wins rule. That is correct in its own world and wrong once per-organization copies exist: applyTenantScope returns the caller's rows and organization-less ones in driver order, so first-row-wins lets a pre-fix organization-less row answer for this organization, the loop takes its update branch, and no copy is ever created — the silent no-op this whole ruling exists to prevent, reintroduced through the batching, with CI green throughout. The lookup now separates "this organization's own row" (present) from an organization-less leftover (absent + organizationLessResidue).

2. The deal_p1 assertion in rule-criteria-org-scope.test.ts was KEPT VERBATIM, and that is correct even though the card's doctrine change might suggest otherwise. Ruled point 3 leaves the wall untouched, so applyTenantScope still emits its OR-NULL arm — which is the driver-level compatibility behaviour ruled point 4 demotes D-global to, not deletes it to. "Organization-less rows are invalid state" governs what the seeders mint and what the guard reports; it does not mean the driver stops returning them. Only the assertion's justification was retitled. ⚠️ My dispatch pushed the other way and was wrong; recording that so the retitle is not re-litigated as an oversight.

3. No reap and no remap machinery ships, per the ruling. The loud guard names the leftover rows, names the remedy, and states that nothing was deleted and why — grants point at those rows by id, which is also why The audience-binding-suggestion reconciler writes with a tenant-less system context, so one organization-less row serves every tenant — the second half of the #8577 install-path dead end #8617's reap could promise "NO grant changes" and this one could not.

4. The diff spans packages/core by explicit ruling (Q3 = A): the section-6a name-sweep and plugin-security's dbLoader are organization-scoped in the same landing, because the cross-org grant bleed only exists once copies exist and no intermediate version may ship with copies present and the sweep global. The wall itself (tenant-layer.ts, sql-driver.ts) is not in the diff, nor is anything under packages/spec or docs/adr.

This is a target:v17 release blocker (cloud#1406) with an independent field reproduction on the card.

---

Generated by Claude Code

[github-actions]

⛔ merge queue 构建失败 — 先分诊，再决定要不要重排

队列构建 32596637081 红了。队列跑的是全量套件（PR 侧 CI 只跑 affected 子集），
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job（日志抽取，best effort）：

• Console Pin Gate — 失败步骤: Build the Console SPA at the pinned objectui SHA

  ✗ Build failed in 5.88s
  

↳ 失败原因 是判读的关键：超时（Test timed out in … / Hook timed out in …）多半是负载/时序，不是本 PR 的回归；
断言（AssertionError: …）才指向真实的行为改变。两者的 FAIL 行长得一模一样，只有这一行能区分。

跨 PR 相同签名（24h，按失败测试文件聚合）：

• ⚠️本次没有可用的聚合签名（日志里没有能解析出测试文件名的 FAIL 行）—— 这不是「没有同签名的其他 PR」，是这一轮没测到。跨 PR 聚合本次不可用，请手工比对其他 PR 的同类评论。
• ⚠️ 24h 评论账本没读完（超过 5 页仍未读到窗口尽头），所以上面的「不同 PR 数」是下界，不是全量。

历史信号：

• 本 PR 过去 24h 无队列失败记录（首次）。
• 过去 24h 队列共有 96 个失败构建（不含本次）。

分诊清单：

1. 失败测试在本 PR 改动的包里 → 真回归，修 PR。
2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」；已有汇总 issue ⇒ flaky/环境问题实锤，去那张 issue 上谈，修好前重排只会再烧一轮全队列。
3. 两者都不是 → 可能与同组 PR 语义冲突；等前面的 PR 落地或失败出队后再重排一次即可，不要连续重排。

---

Generated by Claude Code · merge-queue-triage workflow (#4859)