Skip to content

Move the cross-package glob predicate and declaration table out of the gate that owns them#11871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-steve merged 1 commit into from
Aug 24, 2026
Merged

Move the cross-package glob predicate and declaration table out of the gate that owns them #11871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions scripts/check-ci-filter-parity.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,11 +99,18 @@
*
* ## Why it reads the table instead of holding a copy
*
* `CROSS_PACKAGE_TEST_INPUTS` is imported from the sibling gate, which exports it
* for this purpose. A copy here would be a second list of the declarations kept
* in step by hand -- exactly the defect this gate exists to close, one file
* further out. Importing that module runs nothing: its dispatch is behind
* `isEntrypoint`, and its own `--self-test` spawns a real child to pin that.
* `CROSS_PACKAGE_TEST_INPUTS` is imported from `scripts/cross-package-test-inputs.mjs`,
* the plain module that declares it. A copy here would be a second list of the
* declarations kept in step by hand -- exactly the defect this gate exists to
* close, one file further out.
*
* That module is a plain module and not the sibling GATE, which is a difference
* this gate is the beneficiary of (#11511). The table used to live inside
* `check-cross-package-test-inputs.mjs`, and `scripts/pm/dispatch-gates.mjs`
* follows a gate's first-party imports one level but never into a file that is
* itself a discovered gate -- so the dispatch derivation named this gate for
* NOTHING the table declares, though the table is precisely this gate's
* population. Measured on 589758d22: 1 (gate, file) pair before, 3253 after.
*
* ## Wiring
*
Expand All@@ -123,7 +130,7 @@ import process from 'node:process';
import { requireDependency } from './import-prerequisite.mjs';
const { parse } = await requireDependency('yaml', () => import('yaml'), import.meta.url);

import { CROSS_PACKAGE_TEST_INPUTS } from './check-cross-package-test-inputs.mjs';
import { CROSS_PACKAGE_TEST_INPUTS } from './cross-package-test-inputs.mjs';
import { isEntrypoint } from './invoked-as.mjs';

const HERE = resolve(fileURLToPath(import.meta.url), '..');
Expand Down
Loading
Loading