Uh oh!
There was an error while loading. Please reload this page.
review-checklist: add the git-first spot-check row, paid by in-place compression - #11987
Merged
Merged
Conversation
…compression (#11872) The instruction half of the git-first read-order rule already landed in os-dev.md + dispatch-runbook.md; a silent dev regression against it is not visible at review unless the checklist asks for it. This adds that row. The file sits at the line-ratchet ceiling with zero headroom, so the row is paid for in place, not by raising the ceiling: - the two closing-keyword rows (pre-ready body scan, post-merge closed_by_pull_requests read) merge into one row, 8 -> 5 lines: both carried the parser facts and the same pointer, now stated once - the CI-convergence row is re-wrapped at the corpus's own 120-byte width, 8 -> 7 lines, proved byte-identical after whitespace normalization with its inline code spans identical in sequence Net 0 lines: 84/84, ceiling untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMTpSRF5CjMmQBFfPtPCwJ
This was referenced Aug 25, 2026
hotlong
marked this pull request as ready for review
August 25, 2026 05:11
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#11872
Adds the git-first spot-check row to
.claude/skills/pm-dispatch/references/review-checklist.md, the review half of the read-order rule whose instruction half already landed in.claude/agents/os-dev.mdanddispatch-runbook.md. One file, net 0 lines.The row
Flag, not a verdict: the report stays acceptable and the ACCEPT still goes out — what the row buys is that the pattern becomes visible at review, which the evidence reading alone does not deliver.
The ceiling, and how the row was paid for
The card says 82/82; the file on
origin/mainis at 84/84. The re-pin that landed the 120-byte max-line rule moved this ceiling as part of its wholesale re-wrap, after the card was written. The constraint is unchanged — headroom 0, shrink-only, maintainer-only to raise — so the card's instruction stands exactly as written; only the number is stale. The ceiling inscripts/pm/check-skill-line-ratchet.mjsis untouched by this PR.Two payments, both in place:
1. The two closing-keyword rows merge into one — 8 lines → 5. Real compression: both rows carried the parser facts and the same pointer at the platform-readings table. Every check survives, in the same chronological order:
closed_by_pull_requestsclosed_by_pull_requests」completedfrom every open-only filter; this read is the only mechanical catch2. The CI-convergence row re-wrapped at the corpus's own 120-byte width — 8 lines → 7. No word changed. Proved the way the re-wrap that introduced the rule proved itself:
Ledger: −3 −1 +4 = 0.
check-skill-line-ratchetreadsreview-checklist.md is 84 lines (ceiling 84; headroom 0)— same ceiling, same headroom, one more check on the list.Verification
Gate family derived from the real change set, not recalled:
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack(9 families). Union run after the final commit, at6f7dfe58d— every one green, exit code captured before any pipe:check:pm-skill-ratchet✓ check-skill-line-ratchet: …review-checklist.md is 84 lines (ceiling 84; headroom 0).+✓ self-test: 71 cases pass.check:pm-skill-id-lint✓ check-skill-id-lint: 22 file(s) clean (pattern /#[0-9]{3,}/g).check:skill-frame-sync✓ check-skill-frame-sync self-test: 12 cases pass, plus 5 dispatch-gates declaration cases.check:doc-authoring✓ doc authoring guard: 389 files clean·✓ 38 published skill files cleancheck:required-contexts✓ check-required-contexts --self-test: 150 assertions(both legs exit 0)check:pm-governed-merges✓ check-governed-merges --self-test: 129 assertionscheck:agent-test-spelling✓ check-agent-test-spelling --self-test: all cases passcheck:doc-formula-expressions✓ …: 22 record-scoped formula example(s) across 421 files / 1448 TS blocks judged cleancheck:nul-bytescheck-nul-bytes: OK (scanned 6658 text file(s) … no raw ASCII control bytes).Plus a self-scan of the edited file for control bytes (
grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]') — no match.Declared narrowing — the repo-wide
pnpm lint: not run, and empty by construction rather than skipped. Its governed population is read from eslint's own config, not guessed: none of the 7 config blocks ineslint.config.mjscarries afilespattern that matches markdown, so the one path in this diff is outside whateslint .judges. With no type-aware linting reaching a.mdfile, this diff cannot move a verdict on any untouched file either. CI runs the full farm regardless.Changeset: none.
.claude/-only, internal agent tooling, publishes nothing; theskip-changesetlabel carries that declaration in this repo.Draft on purpose:
.claude/skills/**is a governed surface, so this one merges by a human.Generated by Claude Code
Generated by Claude Code