Uh oh!
There was an error while loading. Please reload this page.
docs(cli): fix stale detectMode quote in serve-process.ts header - #12170
Merged
Conversation
The header's "VITEST is NOT cosmetic" section quoted local-crypto-provider.ts's detectMode with an `env.VITEST ||` arm that #11448 (a58eac3) already removed, and predicted a crypto-posture flip that can no longer happen. Comment-only rewrite: the read existed, #11448 removed it, check:runner-env-posture now holds the class, and the strip in childEnv() stays as defence-in-depth over a gated class rather than the fix for a live read. OS_SECRET_KEY's justification in runServe() is re-derived from NODE_ENV (bin/run-dev.js pins development before argv is parsed) instead of VITEST. No executable line changed.
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 23 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
This was referenced Aug 25, 2026
os-trump
marked this pull request as ready for review
August 25, 2026 14:57
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#11691
What
packages/cli/test/helpers/serve-process.ts's header quoteddetectModefrompackages/services/service-settings/src/local-crypto-provider.tswith anenv.VITEST ||arm that #11448 (a58eac3e) already deleted. The quoted codeno longer matched the source, and the narrative built on it predicted a
crypto-posture flip (
test→development) that can no longer happen.This is a comment-only rewrite of the "VITEST is NOT cosmetic" section:
pnpm check:runner-env-posturenow holds the class shut, and the strip in
childEnv()stays anyway — asdefence-in-depth over a gated class, not as the fix for a live product
read.
OS_SECRET_KEY's justification inrunServe()fromNODE_ENV,not
VITEST:bin/run-dev.jspinsprocess.env.NODE_ENV = 'development'before argv is even parsed, and
NODE_ENVis deliberately outsidechildEnv()'s strip family — so every child spawned through this helper isalready in
developmentcrypto posture, with or without a leakedVITEST. The old text's prediction of a posture flip was false, and hadalready propagated into another card's dispatch as the reason a set of
serve-*spawners were expected to be the harder half of a fix.The
TEST/ better-auth half of the header (isTest()readsTESTdirectly) is untouched — it is still exactly true.
No executable line changed;
childEnv()'s behaviour is unmodified.Verification
env.VITEST ||quotation is gone; new rationale(
#11448,a58eac3e,check:runner-env-posture,defence-in-depth) ispresent.
origin/main(not reconciled to the dispatch'sline numbers): current
detectModesource(
packages/services/service-settings/src/local-crypto-provider.ts:185) hasno
VITESTarm;bin/run-dev.js:28pinsNODE_ENV = 'development'beforerun()is called.packages/cli/test/helpers/serve-process.ts's dependent e2e suites green:serve-process-child-env.e2e.test.ts(6/6),serve-node-env-production-default.e2e.test.tsserve-boot-diagnostics.e2e.test.ts(5/5).pnpm --filter @objectstack/cli typecheckclean.node scripts/pm/dispatch-gates.mjsagainst theactual change set (one file); matched local gates
(
check:cli-test-child-env,check:i18n,check:published-files,check:slot-lookup,check:test-source-alias,check:type-check-coverage,check:type-source-resolution,check-plugin-teardown-shape,check-affected-docs,check-drift-comment) run clean;pnpm lintfull-repo run at
c225c701(see report for the exact output).check:i18n-coverageandcheck:type-check-debt --re-measurecould not belocally re-measured in this scoped worktree (both require the FULL monorepo
build closure, not just
@objectstack/cli's dependency chain) — noted in thedev report; neither can move from a docblock-only edit.
manufactured).
skip-changeset— comment-only, no user-visible behaviour change.Generated by Claude Code
Generated by Claude Code