Skip to content

feat(devx): gate CLI command-id string literals outside the CLI package#12225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinlianghui merged 5 commits into from
Aug 25, 2026
+600 −0
Merged

feat(devx): gate CLI command-id string literals outside the CLI package #12225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f16de56
feat(devx): gate CLI command-id literals outside the CLI package (#12…
claude Aug 25, 2026
0e6fdae
fix(devx): exclude the command-id gate's own source from its own popu…
claude Aug 25, 2026
59066bd
fix(devx): declare the command-id gate's scripts/ subtree so a dispat…
claude Aug 25, 2026
53573b0
Merge remote-tracking branch 'origin/main' into claude/issue-12016-cl…
claude Aug 25, 2026
9fbb5a2
Merge remote-tracking branch 'origin/main' into claude/issue-12016-cl…
claude Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1604,6 +1604,18 @@ jobs:
- name: CLI test child-env guard
run: pnpm check:cli-test-child-env

# #12016. A CLI command id spelled as a string literal OUTSIDE the CLI
# package has nothing tying it to the command file it names: rename the
# command, update the CLI and the docs, and the engine's own drift warning
# keeps printing a route that no longer exists — a stale hint inside an
# otherwise-correct message, which no suite reads as wrong because
# driver-sql's pin asserts the message contains the constant and the
# constant still matches itself. 274 such literals across 98 files were
# measured before the gate was written; the sibling sweep INSIDE
# packages/cli is #11465 / #12177, and the two populations do not overlap.
- name: CLI command-id literals resolve
run: pnpm check:cli-command-ids

# #4093 follow-up. Discovery tells a consumer an absent capability is
# absent AND what to install. The first half has been carefully honest
# since #2462/#4000; the second was invented from the slot name, so ten
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@
"check:org-identifier": "node scripts/check-org-identifier.mjs --self-test && node scripts/check-org-identifier.mjs",
"check:runner-env-posture": "node scripts/check-runner-env-posture.mjs --self-test && node scripts/check-runner-env-posture.mjs",
"check:cli-test-child-env": "node scripts/check-cli-test-child-env.mjs --self-test && node scripts/check-cli-test-child-env.mjs",
"check:cli-command-ids": "node scripts/check-cli-command-ids.mjs --self-test && node scripts/check-cli-command-ids.mjs",
"check:authz-resolver": "node scripts/check-single-authz-resolver.mjs --self-test && node scripts/check-single-authz-resolver.mjs",
"check:slot-lookup": "node scripts/check-slot-lookup-ratchet.mjs --self-test && node scripts/check-slot-lookup-ratchet.mjs",
"check:query-options-erasure": "node scripts/check-query-options-erasure-ratchet.mjs --self-test && node scripts/check-query-options-erasure-ratchet.mjs",
Expand Down
Loading
Loading