Skip to content

Watch the logger receiver-detach class repo-wide, on an anchored receiver vocabulary#13132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-elon merged 2 commits into from
Aug 29, 2026
+808 −0
Merged

Watch the logger receiver-detach class repo-wide, on an anchored receiver vocabulary #13132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c48c7
feat(scripts): watch the logger receiver-detach class repo-wide
os-elon Aug 29, 2026
be6fb46
chore(pm): record the bare-root verdicts the new gate incurs
os-elon Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2110,6 +2110,26 @@ jobs:
- name: Durability-degradation log-level guard
run: pnpm check:durability-log-level

# Logger receiver-detach guard (#12820, from #12773 / #12792). `a.b(...)`
# passes `a` as the receiver; `(a.error ?? a.warn)(...)`, `const fn =
# a.error`, `const { error } = a`, `run(a.warn)` and `{ warn: a.warn }` all
# evaluate to the bare function and call it with `this === undefined`.
# `@objectstack/core`'s ObjectLogger dereferences `this` on every channel,
# so a host that injects one turns those lines into a TypeError — on the
# channel whose whole job is to be loud when something is already wrong.
# The class was closed three times one package at a time (plugin-auth 3
# sites, driver-sql 9) and nothing watched it. The criterion is an anchored
# RECEIVER vocabulary, never the channel name: `error`/`warn`/`info` name
# an error-envelope constructor (117 sites), oclif's throwing
# `Command.error` (91) and `Math.log` (2) in this tree, and the two
# legitimate populations #12820 measured — bound `console` methods and
# caller-supplied options callbacks — must stay green or the gate gets
# turned off. Non-test source only, and every run scans a two-sided control
# corpus first, so a broken matcher cannot print the same green as a clean
# repo. Runs its own --self-test first.
- name: Logger receiver-detach guard
run: pnpm check:logger-receiver-detach

# Startup registry-verdict guard (#4777). One showcase cold start produced
# three instances of one shape in three unrelated subsystems: ask a
# registry "is X there?" while the boot is still filling it, treat the
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,7 @@
"check:kernel-hook-pairs": "node scripts/check-kernel-hook-pairs.mjs --self-test && node scripts/check-kernel-hook-pairs.mjs",
"check:durability-log-level": "node scripts/check-durability-degradation-log-level.mjs --self-test && node scripts/check-durability-degradation-log-level.mjs",
"check:optional-error-sink": "node scripts/check-optional-error-sink-contract.mjs --self-test && node scripts/check-optional-error-sink-contract.mjs",
"check:logger-receiver-detach": "node scripts/check-logger-receiver-detach.mjs --self-test && node scripts/check-logger-receiver-detach.mjs",
"check:startup-registry-verdict": "node scripts/check-startup-registry-verdict.mjs --self-test && node scripts/check-startup-registry-verdict.mjs",
"check:console-sha": "node scripts/check-console-sha.mjs",
"check:console-injection": "node scripts/check-console-injection.mjs --self-test && node scripts/check-console-injection.mjs",
Expand Down
Loading
Loading