fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads - #13755

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths
Aug 31, 2026
Merged

fix(spec): redact mongo CSFLE kmsProviders key material on datasource reads#13755
os-warren merged 1 commit into
mainfrom
claude/issue-13602-kms-providers-secret-paths

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13602

What

redactDatasourceConfig('mongodb', ...) served mongo CSFLE KMS key material inside the options passthrough back in cleartext with no redactedKeys entry. Five client-measured positions join passthroughSecretPaths in packages/spec/src/data/datasource-credential-redaction.ts, with the measurement quoted in the table docblock:

  • options.autoEncryption.kmsProviders.aws.secretAccessKey
  • options.autoEncryption.kmsProviders.aws.sessionToken
  • options.autoEncryption.kmsProviders.azure.clientSecret
  • options.autoEncryption.kmsProviders.gcp.privateKey
  • options.autoEncryption.kmsProviders.local.key

Table rows only. The #13405 mirrored-spelling derivation is untouched and no new credential name spellings were invented — these are the client-measured residue the table exists for.

Premise measurement (#9040 discipline — measured, never inferred from documentation)

Instrumented new MongoClient(url, { ..., ...options }) — the exact spread @objectstack/driver-mongodb performs — against mongodb@7.5.0, with the autoEncryption record, the kmsProviders record and every family object wrapped in read-logging Proxies. Both states of the optional mongodb-client-encryption dependency were measured, and the answers differ:

  • With mongodb-client-encryption installed (7.2.1, inside the pin's ^7.2.0 optional-peer range): construction reads every one of the five leaves — the kmsProviders record is BSON-serialized into the native MongoCrypt. Observed reads: aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey, local.key, plus the identity halves aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email. connect() then proceeds into live CSFLE machinery (mongocryptd spawn attempt).
  • Without it (the repo's own install state — the dependency is absent from the lockfile): the same construction throws MongoMissingDependencyError before reading any of the positions. The stored copy performs no function but sits cleartext at rest — the AWS_SESSION_TOKEN posture already on the table: a loud client failure does not make serving the secret back acceptable.

Boundary kept deliberately narrow: the identity halves the client also reads (aws.accessKeyId, azure.tenantId, azure.clientId, gcp.email) are not credential material (the #8876 asymmetry) and stay served; unmeasured neighbours (kmip.endpoint, keyVaultNamespace, schemaMap, bypassAutoEncryption) mirror no credential spelling, are not on the table, and are pinned untouched by a negative-control test.

Round-trip answer (the card's third question)

  • An untouched Save keeps a working CSFLE config byte-identical.restoreRedactedConfig mirrors the redactor structurally — it computes the served projection from the stored row and grafts every stored leaf back where the patch still matches — so the new rows are covered by construction, with nothing to forget. Pinned end-to-end at the admin service door: read serves the config with the five leaves withheld and named in redactedConfigKeys; an untouched update writes the stored config back deep-equal to the original.
  • The served projection handed straight to the client (restore bypassed) fails loudly, not silently. Measured with the dependency installed: construction throws TypeError: Failed to parse KMS provider aws: expected UTF-8 secretAccessKey (azure and gcp equivalents measured identically); local served as an empty object constructs, but encryption stays armed — the client proceeds into the mongocryptd path, and no silently-unencrypted operation was observed. Redaction therefore creates no silent-downgrade path, and no new write-back semantics were needed.

Clause ②: no

Table entries plus tests only. No accept/reject behaviour changes: the write door refuses and accepts exactly what it did before (these positions were and remain writable — the binder's one secret slot is the login password, the proxyPassword posture), and no public export was added, removed or re-typed.

Verification (all runs at HEAD 3520ba2, after the final commit)

  • pnpm --filter @objectstack/spec exec vitest run src/data/datasource-credential-redaction.test.ts src/kernel/metadata-type-redaction.test.ts — Test Files 2 passed, Tests 47 passed.
  • pnpm --filter @objectstack/service-datasource exec vitest run src/__tests__/datasource-config-redaction.test.ts — Tests 36 passed (includes the new CSFLE round-trip pin).
  • Reverse verification, fix committed first: the redaction module was reverted to the branch base (mutation proven on disk — autoEncryption occurrence count 6 to 0), the new CSFLE pin went red exactly (1 failed, 36 passed; the negative control stayed green), then restored from HEAD with byte-identity proven (git diff HEAD empty; worktree blob hash equals the HEAD blob). The suite resolves relative src imports, so no dist build participates in either leg.
  • pnpm --filter @objectstack/spec typecheck and pnpm --filter @objectstack/service-datasource typecheck — green; both edited test files confirmed inside their tsc programs via a listFiles probe (1 hit each).
  • scripts/pm/dispatch-gates.mjs (no paths — changeset derived from merge-base; answer asserted for objectstack-ai/objectstack at commit 3520ba2) derived 46 families for this diff, path-matched plus convention-triggered test-file families. 44 PASS — including check:type-check-debt re-measure ("29 ledger entries re-measured, none above its recorded number"), check:authorable-surface, check:docs, check:engine-double-contract, check:where-matcher, check:cross-package-test-inputs. 2 declared PREREQUISITE NOT MET by their own exit-3 text (NOT MEASURED, not red): check-test-completeness (grades a saved CI turbo test log that does not exist locally) and check-half-states (needs repo-scoped REST reads; this session's gate answers 403 — CI-owned).
  • Changeset: .changeset/csfle-kms-providers-redacted.md, @objectstack/spec patch.

Measurement scripts and full logs are excerpted in the report comment on #13602. Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2

Generated by Claude Code


Generated by Claude Code

… reads
The five client-measured positions inside the options passthrough
(aws.secretAccessKey, aws.sessionToken, azure.clientSecret, gcp.privateKey,
local.key under options.autoEncryption.kmsProviders) join
passthroughSecretPaths, with the mongodb@7.5.0 measurement quoted in the
table docblock (both with and without the optional mongodb-client-encryption
dependency). Pins: all five redacted with redactedKeys entries, unmeasured
neighbours untouched (negative control), and an untouched CSFLE Save
round-trips byte-identically through restoreRedactedConfig.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBjwYLS6BciTQW3c9xQiD2
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 6 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/permissions/authentication.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/permissions/sso.mdx(via clientSecret (literal, a string literal in mongodb))
  • content/docs/plugins/index.mdx(via clientSecret (literal, a string literal in mongodb))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via clientSecret (literal, a string literal in mongodb))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1bpackageMentionDocs.

Which tree this was computed on

This run read content/docs from b14d242215f66c8a2e6a1698f313d8f72210de7b — the merge of head 3520ba2dac649ab533c3525d7b89ca82dce37e4e into base d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b14d242215f66c8a2e6a1698f313d8f72210de7b && git checkout b14d242215f66c8a2e6a1698f313d8f72210de7b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b 3520ba2dac649ab533c3525d7b89ca82dce37e4e && git checkout -B drift-repro d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b && git merge --no-ff 3520ba2dac649ab533c3525d7b89ca82dce37e4e
node scripts/docs-audit/affected-docs.mjs --json d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs d7ca6dc77edc2e158fb31b24176e6bf2341f9d1b → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 10:26
@os-warren
os-warren enabled auto-merge August 31, 2026 10:26
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit 5060877Aug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13602-kms-providers-secret-paths branch August 31, 2026 11:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/mteststooling

Projects

None yet

2 participants

@os-warren@claude