Skip to content

fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-warren merged 1 commit into from
Aug 31, 2026
+55 −18
Merged

fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary #13869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/search-excluded-ghost-types.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.
49 changes: 37 additions & 12 deletions packages/spec/src/data/search-fields.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
const validTypes: ReadonlySet<string> = new Set(FieldType.options);
const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
];

it('every member is a real FieldType — no ghost vocabulary entries', () => {
for (const t of SEARCHABLE_ENUM_TYPES) {
expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
it.each(vocabularies)('%s has no ghost members', (name, set) => {
const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
});

it('CONTROL — the subset assertions are not vacuous', () => {
// A broken `FieldType` import (empty `options`) or an accidentally emptied
// vocabulary would green every subset check above while pinning nothing.
expect(validTypes.size).toBeGreaterThan(0);
for (const [name, set] of vocabularies) {
expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
}
// Positive control — one known-real member per vocabulary, so the pin is
// measuring membership, not an accident of empty intersections.
expect(validTypes.has('text')).toBe(true);
expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
});
});

Expand Down
19 changes: 13 additions & 6 deletions packages/spec/src/data/search-fields.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
'json', 'image', 'file', 'avatar', 'vector', 'location',
'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
* [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
// `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
// every type it names already falls through the `return` below as `false`
// — identically to a type in none of the three sets (`number`, `date`, …).
// Measured over the full 56-type domain (`FieldType` ∪ all three
// vocabularies), deleting this line moves not one resolution. So it is NOT
// Measured over the full domain of `FieldType` ∪ all three vocabularies
// (56 types when the guard landed; the union IS `FieldType` since #13716
// dropped the last ghost members), deleting this line moves not one
// resolution. So it is NOT
// load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
// require keeping it out of this set for the auto-default to reject it.
//
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
// it the positive list wins and the type enters the auto-default AND, one
// layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
// flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
// This set names `secret`, `password`, `encrypted` and `vector`: failing
// open there means a `$contains` scan over a masked or heavy column.
// This set names `secret`, `password`and `vector`: failing open there
// means a `$contains` scan over a masked or heavy column.
//
// The disjointness is not left to coincidence. `search-fields.test.ts` pins
// all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary by os-warren · Pull Request #13869 · objectstack-ai/objectstack · GitHub
Skip to content
fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary#13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-warren
merged 1 commit into

from

Aug 31, 2026

+55

−18

 Merged


fix(spec): drop four dead ghost members from SEARCH_AUTO_EXCLUDED_TYPES and extend the [#13695] pin to every search type vocabulary
#13869
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/search-excluded-ghost-types.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@objectstack/spec": patch
---

Drop four dead members — 'object', 'grid', 'geometry', 'encrypted' — from `SEARCH_AUTO_EXCLUDED_TYPES` (`search-fields.ts`). None of the four was ever a member of the `FieldType` enum at any commit, so none could ever match a real field's `type`: the exclusion set's live behaviour is unchanged, and the file's fail-closed tiebreak comment no longer asserts a safety property for names that cannot occur. The `[#13695]` pin in `search-fields.test.ts` is extended to hold every search type vocabulary (`SEARCHABLE_TEXTUAL_TYPES`, `SEARCHABLE_ENUM_TYPES`, `SEARCH_AUTO_EXCLUDED_TYPES`, `SEARCH_VIRTUAL_TYPES`) to `FieldType` membership, so a future ghost entry is a red test instead of a silent no-op.

49 changes: 37 additions & 12 deletions
packages/spec/src/data/search-fields.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,25 +144,50 @@ describe('[#4483] $search auto field set — lead orders, never admits', () => {
// and in opposite directions, so no single relaxation can make this pin vacuous.
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
// [#13695] `SEARCHABLE_ENUM_TYPES` members must be real `FieldType`s.
// [#13695] Every search type vocabulary in this file is a subset of `FieldType`.
//
// The #6934 disjointness pins above check the vocabularies against EACH OTHER
// The #6934 disjointness pins below check the vocabularies against EACH OTHER
// but never against `FieldType` itself, so a member that matches no real field
// type at all — a pure ghost, distinct from an overlap — passed every existing
// pin silently: `'status'` sat in this set matching nothing, for as long as it
// took a docs sweep to notice by hand. This pin closes that probe gap for the
// enum vocabulary specifically (the one the finding hit); it is deliberately
// NOT extended to `SEARCH_AUTO_EXCLUDED_TYPES`, which is a separate, larger
// finding of its own (`object`/`grid`/`geometry`/`encrypted` are ghosts there
// too) filed out of scope for this fix.
// pin silently: `'status'` sat in `SEARCHABLE_ENUM_TYPES` matching nothing for
// as long as it took a docs sweep to notice by hand, and the same probe run
// against the other sets found four more in `SEARCH_AUTO_EXCLUDED_TYPES`
// (#13716: 'object', 'grid', 'geometry', 'encrypted' — never `FieldType`
// members at any commit, so the fail-closed tiebreak comment was asserting a
// safety property for names that cannot occur). This pin now holds ALL of the
// file's type vocabularies to the enum: an exclusion or allowance spelled with
// a name `FieldType` does not contain governs nothing.
// (`SEARCH_AUTO_EXCLUDED_FIELDS` is deliberately absent — its members are
// field NAMES, not types.)
// ---------------------------------------------------------------------------
describe('[#13695] SEARCHABLE_ENUM_TYPES ⊆ FieldType', () => {
describe('[#13695] search type vocabularies ⊆ FieldType', () => {
 const validTypes: ReadonlySet<string> = new Set(FieldType.options);
 const vocabularies: ReadonlyArray<[string, ReadonlySet<string>]> = [
 ['SEARCHABLE_TEXTUAL_TYPES', SEARCHABLE_TEXTUAL_TYPES],
 ['SEARCHABLE_ENUM_TYPES', SEARCHABLE_ENUM_TYPES],
 ['SEARCH_AUTO_EXCLUDED_TYPES', SEARCH_AUTO_EXCLUDED_TYPES],
 ['SEARCH_VIRTUAL_TYPES', SEARCH_VIRTUAL_TYPES],
 ];

 it('every member is a real FieldType — no ghost vocabulary entries', () => {
 for (const t of SEARCHABLE_ENUM_TYPES) {
 expect(validTypes.has(t), `'${t}' is in SEARCHABLE_ENUM_TYPES but not a FieldType member`).toBe(true);
 it.each(vocabularies)('%s has no ghost members', (name, set) => {
 const ghosts = [...set].filter((t) => !validTypes.has(t)).sort();
 expect(ghosts, `${name} names types that are not FieldType members`).toEqual([]);
 });

 it('CONTROL — the subset assertions are not vacuous', () => {
 // A broken `FieldType` import (empty `options`) or an accidentally emptied
 // vocabulary would green every subset check above while pinning nothing.
 expect(validTypes.size).toBeGreaterThan(0);
 for (const [name, set] of vocabularies) {
 expect(set.size, `${name} is unexpectedly empty`).toBeGreaterThan(0);
 }
 // Positive control — one known-real member per vocabulary, so the pin is
 // measuring membership, not an accident of empty intersections.
 expect(validTypes.has('text')).toBe(true);
 expect(SEARCHABLE_TEXTUAL_TYPES.has('text')).toBe(true);
 expect(SEARCHABLE_ENUM_TYPES.has('select')).toBe(true);
 expect(SEARCH_AUTO_EXCLUDED_TYPES.has('secret')).toBe(true);
 expect(SEARCH_VIRTUAL_TYPES.has('formula')).toBe(true);
 });
});

Expand Down

19 changes: 13 additions & 6 deletions
packages/spec/src/data/search-fields.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,14 @@ export const SEARCH_AUTO_EXCLUDED_FIELDS: ReadonlySet<string> = new Set([
 'id', '_id', 'created', 'modified', 'created_at', 'updated_at',
 'created_by', 'updated_by', 'owner_id', 'organization_id', 'space', 'company_id',
]);
// [#13716] 'object', 'grid', 'geometry' and 'encrypted' were dropped from this
// set: none was a `FieldType` member at ANY commit (imported vocabulary, never
// renamed spellings — 'location', 'secret' and 'json' were already in both the
// enum and this set the day the set landed), so each could only ever match
// nothing. The [#13695] pin now holds every member to `FieldType`.
export const SEARCH_AUTO_EXCLUDED_TYPES: ReadonlySet<string> = new Set([
 'json', 'object', 'grid', 'image', 'file', 'avatar', 'vector', 'location',
 'geometry', 'secret', 'password', 'encrypted', 'boolean', 'lookup', 'master_detail',
 'json', 'image', 'file', 'avatar', 'vector', 'location',
 'secret', 'password', 'boolean', 'lookup', 'master_detail',
]);
/**
 * [#6674] Field types with NO STORED COLUMN — the value is computed on read, so
Expand DownExpand Up@@ -117,8 +122,10 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // `SEARCH_AUTO_EXCLUDED_TYPES` is disjoint from both positive lists, so
 // every type it names already falls through the `return` below as `false`
 // — identically to a type in none of the three sets (`number`, `date`, …).
 // Measured over the full 56-type domain (`FieldType` ∪ all three
 // vocabularies), deleting this line moves not one resolution. So it is NOT
 // Measured over the full domain of `FieldType` ∪ all three vocabularies
 // (56 types when the guard landed; the union IS `FieldType` since #13716
 // dropped the last ghost members), deleting this line moves not one
 // resolution. So it is NOT
 // load-bearing: adding a type to `SEARCHABLE_TEXTUAL_TYPES` does not also
 // require keeping it out of this set for the auto-default to reject it.
 //
Expand All@@ -129,8 +136,8 @@ function autoDefaultFields(fields: Record<string, SearchFieldMeta>, displayField
 // it the positive list wins and the type enters the auto-default AND, one
 // layer up, the #4254 ingress allow-list — so `$searchFields=<that field>`
 // flips from refused to ACCEPTED, the same widening #4483 closed for `id`.
 // This set names `secret`, `password`, `encrypted` and `vector`: failing
 // open there means a `$contains` scan over a masked or heavy column.
 // This set names `secret`, `password`and `vector`: failing open there
 // means a `$contains` scan over a masked or heavy column.
 //
 // The disjointness is not left to coincidence. `search-fields.test.ts` pins
 // all three vocabularies pairwise disjoint AND pins both resolution
Expand Down
Loading