Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions packages/metadata/src/metadata-manager-cluster.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -399,3 +399,115 @@ describe('MetadataManager — a cluster peer write invalidates local caches (#51
expect(cachedTypes(a)).toEqual(['view']);
});
});

/**
* #13609 — the seam behind "delete keeps being served cluster-wide, longer
* than any TTL", measured statically (no live multi-node deployment
* available; see the issue for the full write-up).
*
* Every test above in this file shares ONE `TestPubSub` bus between A and
* B — the correct model of a WORKING cross-node transport (a real `redis` /
* `postgres` cluster driver), and it is why `unregister()`'s cluster fan-out
* (`notifyWatchers` → `CLUSTER_CHANNEL` → the peer's `invalidateForForeignWrite`)
* checks out as correct: register() and unregister() call it identically, so
* the #13405 reading ("create broadcasts, delete does not mirror") is false
* as a claim about this mechanism.
*
* But `Runtime`'s shipped DEFAULT (`cluster` option omitted) is
* `defineCluster({})` → `driver: 'memory'`, and `MemoryPubSub`'s own
* doc-comment is explicit: "No cross-process delivery — use the redis /
* postgres / nats driver for real multi-node setups." Each of N replica
* PROCESSES constructs its OWN `MemoryPubSub` instance; nothing wires them
* together. The split-brain guard (`assertClusterDriverSafeForTopology`,
* `split-brain-guard.ts`) only fires when the operator has *declared*
* multi-node via `OS_EXPECT_MULTI_NODE` / `OS_CLUSTER_REPLICAS>1` — silent
* otherwise, by design (ADR-0010, path A).
*
* So the below gives A and B *separate* `TestPubSub` instances instead of
* `makeCluster()`'s shared one — the faithful in-process stand-in for two
* real OS processes each on the shipped default driver. No live cluster is
* needed to observe the isolation: it is a property of the transport object
* (no socket, no IPC — see `MemoryPubSub`'s full implementation), identical
* whether the two instances live in one test process or two real ones.
*
* Both replicas locally `register()` the row before the delete, matching
* what `restoreRuntimeDatasources` does on every replica's own boot: each
* reads the same durable `sys_metadata` row and calls `metadata.register()`
* LOCALLY — not via a broadcast. That is also the reconciling condition for
* the three-way tension: `readListUncached()` merges the in-memory registry
* BEFORE the loader and never overwrites a registry hit with a loader
* answer (see `metadata-manager.ts`). A **new** name a peer's registry has
* never seen falls through to the (shared, authoritative) loader on every
* read, so a create looks like it "reaches" peers within one `list()` call —
* no propagation required. A name a peer's registry already holds POSITIVE
* is never re-checked against the loader at all, so a stale positive
* survives every list-cache TTL window forever, not for ~30s. That asymmetry
* — not "delete doesn't broadcast" — is what #13405 actually observed.
*/
describe('MetadataManager — default `memory` cluster driver does not cross OS processes (#13609)', () => {
const dsRow = (name: string) => ({ name, driver: 'postgres', origin: 'runtime' as const });

it('control: WITH a working cross-node transport, unregister() on A evicts B immediately', async () => {
// `makeCluster()` shares one bus — models a real redis/postgres driver.
const { store, a, b } = makeCluster();
await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
// Both replicas locally register at "boot", exactly like
// `restoreRuntimeDatasources` reading the same `sys_metadata` row.
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

await a.unregister('datasource', 'ds_doomed');

// Positive control: the probe below (get + list, same door
// `/api/v1/meta/datasource` reads through) WOULD have seen this.
expect(await b.get('datasource', 'ds_doomed')).toBeUndefined();
expect(viewNames(await b.list('datasource'))).toEqual([]);
});

it('WITHOUT it (the shipped default across real replicas): B keeps serving the deleted row past 10 list-cache TTL windows', async () => {
vi.useFakeTimers();
try {
const store = new SharedStoreLoader();
const a = new MetadataManager({ formats: ['json'], loaders: [store] });
const b = new MetadataManager({ formats: ['json'], loaders: [store] });
// Two INDEPENDENT pubsub instances, not shared — the isolation
// `defineCluster({ driver: 'memory' })` (the omitted-config
// default) actually ships with across two real processes.
a.attachClusterPubSub(new TestPubSub(), 'node-A');
b.attachClusterPubSub(new TestPubSub(), 'node-B');

await store.save('datasource', 'ds_doomed', dsRow('ds_doomed'));
await a.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
await b.register('datasource', 'ds_doomed', dsRow('ds_doomed'));
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();

// DELETE lands on A (e.g. the admin REST door). Storage-first,
// in-memory second (#5259): A is correct immediately, and the
// shared DB row is gone too.
await a.unregister('datasource', 'ds_doomed');
expect(await a.get('datasource', 'ds_doomed')).toBeUndefined();
expect(store.storage.get('datasource')?.has('ds_doomed')).toBe(false);

// B's broadcast never arrives (separate pubsub instance). Advance
// WAY past the list-cache TTL this manager applies to `list()` —
// if this were TTL-bound (the #5109 / A2.3 shape) it would have
// cleared by now. It has not: the stale entry lives in the
// REGISTRY, which carries no TTL at all, and every fresh
// `readListUncached()` re-derives the same answer because the
// registry hit is never checked against the (correct) loader.
const ttl = (MetadataManager as unknown as { LIST_CACHE_TTL_MS: number })
.LIST_CACHE_TTL_MS;
vi.advanceTimersByTime(ttl * 10);

// This is exactly what `/api/v1/meta/datasource` reads through
// (`MetadataProtocol` → `metadataService.list('datasource')`) and
// what the admin `listDatasourceRecords` reads for the
// detail/admin registry (`metadataOf()?.list('datasource')`).
expect(await b.get('datasource', 'ds_doomed')).toBeTruthy();
expect(viewNames(await b.list('datasource'))).toEqual(['ds_doomed']);
} finally {
vi.useRealTimers();
}
});
});
Loading