Skip to content

Fix test failures from schema evolution (CustomValidator.handler, TenantSchema removal) - #139

Merged
hotlong merged 3 commits into
copilot/fix-action-step-issue-another-onefrom
copilot/update-github-actions-workflow
Jan 25, 2026
Merged

Fix test failures from schema evolution (CustomValidator.handler, TenantSchema removal)#139
hotlong merged 3 commits into
copilot/fix-action-step-issue-another-onefrom
copilot/update-github-actions-workflow

Conversation

CopilotAI commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

CI failing due to test data not updated after schema changes.

Changes

  • CustomValidatorSchema tests: Replace validatorFunctionhandler field in all custom validator test cases
  • TenantSchema: Restore as deprecated with migration guide to HubSpaceSchema

Context

CustomValidatorSchema uses handler field (line 334, validation.zod.ts), while AsyncValidationSchema uses validatorFunction. Tests incorrectly used validatorFunction for custom validators.

TenantSchema was removed with comment "now an attribute of Space", but 39 tests still imported it. Restored with deprecation notice rather than rewriting tests.

// Before (broken){type: 'custom',validatorFunction: 'validateBusinessRule',// Wrong field}// After (fixed){type: 'custom',handler: 'validateBusinessRule',// Correct field}
Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21326059710/job/61383424733#step:8:1


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel

vercelBot commented Jan 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
specReadyReadyPreview, CommentJan 25, 2026 4:48am

Request Review

CopilotAIand others added 2 commits January 25, 2026 04:45
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
CopilotAI changed the title [WIP] Update GitHub Actions workflow configurationFix test failures from schema evolution (CustomValidator.handler, TenantSchema removal)Jan 25, 2026
CopilotAI requested a review from hotlongJanuary 25, 2026 04:48
@hotlong
hotlong marked this pull request as ready for review January 25, 2026 04:58
CopilotAI review requested due to automatic review settings January 25, 2026 04:58
@hotlong
hotlong merged commit f02f3a8 into copilot/fix-action-step-issue-another-oneJan 25, 2026
5 checks passed
CopilotAI removed the request for review from CopilotMarch 24, 2026 01:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hotlong