Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-project-manager merged 2 commits into from
Aug 31, 2026
Merged

Delete the unreachable Array.isArray limb at all three adapter.find() sites #13969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc14ec
Delete the unreachable Array.isArray limb at all three adapter.find s…
claude Aug 31, 2026
02086eb
Add the changeset for the docs sample change
claude Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .changeset/react-pages-array-isarray-limb.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
`enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
raw-GET path and the client-SDK path), and `return existing`, which hands back a
promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
`data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
**wraps** a bare array into that envelope. The array case is folded before any caller
sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.
8 changes: 6 additions & 2 deletions content/docs/ui/react-pages.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
$filter: ['status', '!=', 'paid'],
$top: 200,
});
const records = result?.data ?? (Array.isArray(result) ? result : []);
if (alive) setRows(records);
if (alive) setRows(result.data);
})();
return () => { alive = false; };
}, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down
7 changes: 5 additions & 2 deletions examples/app-showcase/src/ui/pages/crm-workbench.page.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
// silently stuck at 0 even though the ListView beside them showed the same
// rows. Read .data: it is the only row shape QueryResult declares, so a
// tolerant '.data || .records' alias would render correctly while
// teaching a spelling the producer cannot emit.
// teaching a spelling the producer cannot emit. There is no array
// shape to test for either: every find() path resolves to that same
// object envelope, and normalizeQueryResult WRAPS a bare array
// response into it, so an 'Array.isArray(all)' limb can never be taken.
//
// The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
// and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
// "Active" stays a per-row verdict over the 200 rows actually fetched;
// an exact one would need its own filtered count query.
const all = await adapter.find('showcase_project', { $top: 200 });
const rows = Array.isArray(all) ? all : (all && all.data) || [];
const rows = all?.data ?? [];
const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
setStats({ total, active: rows.filter((r) => r.status === 'active').length });
} catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down
6 changes: 4 additions & 2 deletions examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
// applied, is the server's real count over the same $filter rather than
// the page length. Counting data.length under a cap is how a KPI starts
// under-reporting in silence; count 'total' and the cap stays a fetch
// bound instead of a lie about the business.
// bound instead of a lie about the business. That envelope is the ONLY
// shape find() resolves to -- normalizeQueryResult WRAPS a bare array
// response into it -- so there is no array form to test for either.
React.useEffect(() => {
let alive = true;
(async () => {
if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
const rows = (res) => res?.data ?? [];
const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
const projects = rows(pr);
const invoices = rows(iv);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Delete the unreachable Array.isArray limb at all three adapter.find() sites#13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Aug 31, 2026
 Merged


Delete the unreachable Array.isArray limb at all three adapter.find() sites
#13969
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
ddc14ec

Delete the unreachable Array.isArray limb at all three adapter.find s…


claude Aug 31, 2026
02086eb

Add the changeset for the docs sample change


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
.changeset/react-pages-array-isarray-limb.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
---
"@objectstack/docs": patch
---

docs(react-pages): delete the unreachable `Array.isArray(result)` limb from the live-data sample

`ObjectStackAdapter.find()` cannot resolve to an array, so the `Array.isArray(result)`
arm the live-data sample carried could never be taken. Re-derived against objectui at
the sha this repo pins (`9602dc82`) and again at objectui `origin/main`, which agree
line for line:

- `find()` returns from five points — `{ data: [], total: 0 }` for a resource already
 memoized as missing, `{ data: [], total: 0 }` for a fresh 404 that is not an
 `enable`-block denial, two `normalizeQueryResult(...)` calls (the `$expand`/`$search`
 raw-GET path and the client-SDK path), and `return existing`, which hands back a
 promise produced by that same set.
- Both branches of `normalizeQueryResult()` return an object literal with exactly
 `data`, `total`, `page`, `pageSize`, `hasMore`. The first branch is the one that
 makes the limb dead: it tests `Array.isArray(result)` on the *transport* response and
 **wraps** a bare array into that envelope. The array case is folded before any caller
 sees it.

The sample now reads `result.data` directly, and a new paragraph under it states the
envelope contract so the reason survives the next edit. The two `kind:'react'` pages in
`examples/app-showcase` carrying the same dead limb — `crm-workbench` and
`renewals-pipeline` — were repaired in the same edit, with the derivation recorded in the
comment that already explains the neighbouring `.records` trap.

Behaviour-preserving: `.data` was read first and always won. What goes is a shape the
producer cannot emit, sitting in the page a customer — and a coding agent — copies from.

8 changes: 6 additions & 2 deletions
content/docs/ui/react-pages.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -176,8 +176,7 @@ function Page() {
 $filter: ['status', '!=', 'paid'],
 $top: 200,
 });
 const records = result?.data ?? (Array.isArray(result) ? result : []);
 if (alive) setRows(records);
 if (alive) setRows(result.data);
 })();
 return () => { alive = false; };
 }, [adapter]);
Expand All@@ -186,6 +185,11 @@ function Page() {
}
```

`find()` always resolves to the same envelope — a `QueryResult` carrying the rows
under `data`. A backend that answers with a bare array is folded into that envelope
before your code sees it, so `result.data` is the only row shape a page is ever handed:
read it directly, with no fallback for a shape the adapter cannot produce.

<Callout type="warn">
The `$` prefixes are load-bearing. An unprefixed `top:` or a `filters:` key is not a
query option — it is silently dropped, and the query runs as if you had not written
Expand Down

7 changes: 5 additions & 2 deletions
examples/app-showcase/src/ui/pages/crm-workbench.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,10 @@ function Page() {
 // silently stuck at 0 even though the ListView beside them showed the same
 // rows. Read .data: it is the only row shape QueryResult declares, so a
 // tolerant '.data || .records' alias would render correctly while
 // teaching a spelling the producer cannot emit.
 // teaching a spelling the producer cannot emit. There is no array
 // shape to test for either: every find() path resolves to that same
 // object envelope, and normalizeQueryResult WRAPS a bare array
 // response into it, so an 'Array.isArray(all)' limb can never be taken.
 //
 // The cap is $top, not 'limit': QueryParams declares only $-prefixed keys
 // and the adapter copies only those, so a bare 'limit' is dropped without
Expand All@@ -48,7 +51,7 @@ function Page() {
 // "Active" stays a per-row verdict over the 200 rows actually fetched;
 // an exact one would need its own filtered count query.
 const all = await adapter.find('showcase_project', { $top: 200 });
 const rows = Array.isArray(all) ? all : (all && all.data) || [];
 const rows = all?.data ?? [];
 const total = typeof (all && all.total) === 'number' ? all.total : rows.length;
 setStats({ total, active: rows.filter((r) => r.status === 'active').length });
 } catch (e) { console.warn('[CRM Workbench] failed to refresh stats', e); }
Expand Down

6 changes: 4 additions & 2 deletions
examples/app-showcase/src/ui/pages/renewals-pipeline.page.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,14 +75,16 @@ function Page() {
 // applied, is the server's real count over the same $filter rather than
 // the page length. Counting data.length under a cap is how a KPI starts
 // under-reporting in silence; count 'total' and the cap stays a fetch
 // bound instead of a lie about the business.
 // bound instead of a lie about the business. That envelope is the ONLY
 // shape find() resolves to -- normalizeQueryResult WRAPS a bare array
 // response into it -- so there is no array form to test for either.
 React.useEffect(() => {
 let alive = true;
 (async () => {
 if (!adapter || !sel) { setRelated({ projects: 0, invoices: 0, openInvoices: 0, capped: false }); return; }
 const pr = await adapter.find('showcase_project', { $filter: ['account', '=', sel], $top: 500 });
 const iv = await adapter.find('showcase_invoice', { $filter: ['account', '=', sel], $top: 500 });
 const rows = (res) => (Array.isArray(res) ? res : (res && res.data) || []);
 const rows = (res) => res?.data ?? [];
 const count = (res, list) => (typeof (res && res.total) === 'number' ? res.total : list.length);
 const projects = rows(pr);
 const invoices = rows(iv);
Expand Down
Loading