Skip to content

Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuangjianguo merged 1 commit into from
Aug 31, 2026
+102 −0
Merged

Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE #13976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/closure-context-key-completeness.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.
75 changes: 75 additions & 0 deletions packages/metadata-protocol/src/runtime-authoring-gate.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
* Every context collection some row above routes into.
*
* Read off the table rather than restated: the `as const` keeps the values a
* union of literal keys, and the `satisfies` clause above has already pinned
* that each one is a real {@link RuntimeStackContext} key. So this union
* cannot name a collection the context does not have, and the only remaining
* question is the one below.
*/
type RoutedContextCollections =
(typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
* `never`, or a compile error naming the collection nobody routes into.
*
* The constraint is the whole mechanism: a non-empty
* {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
* `Type '"<collection>"' does not satisfy the constraint 'never'` at the
* assertion below — the missing key, by name, at the file that owns the table.
*/
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
* COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
* clause cannot state, and the last one of this set that was still missing.
*
* ## What the `satisfies` above does NOT ask
*
* It asks that every key the table NAMES is a real `RuntimeStackContext` key.
* It does not ask that every collection needing a row HAS one — validity, not
* completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
* in `@objectstack/lint` before #13390 derived it, one package over.
*
* ## Why it is worth an assertion when nothing is broken
*
* The set is correct as it stands. #13390's ruling is about what "correct
* today" costs: adding the `pages` collection had to touch FIVE spellings of
* this one set and only ONE announced itself, and the unguarded spelling
* produced correct-LOOKING findings whose `path` the caller could not resolve,
* with no test and no gate going red. Four of the five can no longer be
* forgotten. This was the fifth.
*
* ## What goes red, and when
*
* Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
* row that routes a metadata type into it, and this package stops building:
* the dts build reports `TS2344` here. Measured, not assumed — a type error
* confined to this file fails `pnpm --filter @objectstack/metadata-protocol
* build` with `DTS Build error`, which is what CI's workspace build runs.
*
* The red arrives after `@objectstack/lint` is REBUILT, because the type
* crosses the package wall through `dist/runtime.d.ts`. That is inherent to
* the boundary and is the same latency the `satisfies` clause above and
* `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
* makes it unconditional in CI.
*
* ## Why an assertion rather than a derivation
*
* A derivation would have to read the context-collection set as a VALUE, and
* `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
* `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
* Reaching it would mean widening the deliberately narrow
* `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
* same red this costs nothing to get. The TYPE is already here; only the
* completeness question needed asking.
*
* Exported because `noUnusedLocals` is on: a local alias nothing reads is a
* hard `TS6196` here, so an unexported guard would not compile at all.
*/
export type ClosureRoutingCoversEveryContextCollection =
NoUnroutedContextCollection<UnroutedContextCollections>;

/**
* The live collection with this batch's pending drafts folded in — REPLACING
* by name, never appended beside.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE by claude[bot] · Pull Request #13976 · objectstack-ai/objectstack · GitHub
Skip to content
Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE#13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zhuangjianguo
merged 1 commit into

from

Aug 31, 2026

+102

−0

 Merged


Assert every context collection is routed by CLOSURE_CONTEXT_KEY_BY_TYPE
#13976
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


27 changes: 27 additions & 0 deletions
.changeset/closure-context-key-completeness.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/metadata-protocol': patch
---

runtime publish gate: assert that every context collection is routed by `CLOSURE_CONTEXT_KEY_BY_TYPE` (#13768)

The last hand-kept spelling of the runtime publish gate's snapshot collection
set now has a completeness guard. `CLOSURE_CONTEXT_KEY_BY_TYPE`'s `satisfies`
clause asks that every key it NAMES is a real `RuntimeStackContext` key —
validity. It never asked that every collection needing a row HAS one, which is
the asymmetry #13390 removed from the four sibling spellings in
`packages/lint/src/runtime-gate.ts` and explicitly left standing here.

Nothing was broken: the table is correct as it stands, and this ships no
behaviour change of any kind — it adds one exported type alias and no runtime
code. What changes is what happens NEXT time the set widens. Adding a key to
`RuntimeStackContext` without the row that routes a metadata type into it now
fails this package's build (`TS2344`, naming the unrouted collection), where
before it compiled clean and the collection silently stayed empty for every
batch — the shape #10377 was filed for.

The guard is an assertion rather than a derivation because the derivation is
not available: the context-collection set exists as a VALUE only in
`CONTEXT_STACK_KEYS`, which is module-private in `@objectstack/lint` and on
neither of that package's entries. Reaching it would mean widening the
deliberately narrow `@objectstack/lint/runtime` entry to buy a red the
already-imported TYPE gives for free.

75 changes: 75 additions & 0 deletions
packages/metadata-protocol/src/runtime-authoring-gate.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -401,6 +401,81 @@ export const CLOSURE_CONTEXT_KEY_BY_TYPE = {
 page: 'pages',
} as const satisfies Readonly<Record<string, keyof RuntimeStackContext>>;

/**
 * Every context collection some row above routes into.
 *
 * Read off the table rather than restated: the `as const` keeps the values a
 * union of literal keys, and the `satisfies` clause above has already pinned
 * that each one is a real {@link RuntimeStackContext} key. So this union
 * cannot name a collection the context does not have, and the only remaining
 * question is the one below.
 */
type RoutedContextCollections =
 (typeof CLOSURE_CONTEXT_KEY_BY_TYPE)[keyof typeof CLOSURE_CONTEXT_KEY_BY_TYPE];

/** Context collections with NO row above. Must be empty — see the assertion. */
type UnroutedContextCollections = Exclude<keyof RuntimeStackContext, RoutedContextCollections>;

/**
 * `never`, or a compile error naming the collection nobody routes into.
 *
 * The constraint is the whole mechanism: a non-empty
 * {@link UnroutedContextCollections} cannot satisfy `never`, so `tsc` reports
 * `Type '"<collection>"' does not satisfy the constraint 'never'` at the
 * assertion below — the missing key, by name, at the file that owns the table.
 */
type NoUnroutedContextCollection<Unrouted extends never> = Unrouted;

/**
 * COMPLETENESS — the half {@link CLOSURE_CONTEXT_KEY_BY_TYPE}'s `satisfies`
 * clause cannot state, and the last one of this set that was still missing.
 *
 * ## What the `satisfies` above does NOT ask
 *
 * It asks that every key the table NAMES is a real `RuntimeStackContext` key.
 * It does not ask that every collection needing a row HAS one — validity, not
 * completeness. That is exactly the asymmetry `NAME_KEYED_STACK_KEYS` carried
 * in `@objectstack/lint` before #13390 derived it, one package over.
 *
 * ## Why it is worth an assertion when nothing is broken
 *
 * The set is correct as it stands. #13390's ruling is about what "correct
 * today" costs: adding the `pages` collection had to touch FIVE spellings of
 * this one set and only ONE announced itself, and the unguarded spelling
 * produced correct-LOOKING findings whose `path` the caller could not resolve,
 * with no test and no gate going red. Four of the five can no longer be
 * forgotten. This was the fifth.
 *
 * ## What goes red, and when
 *
 * Add a key to `RuntimeStackContext` in `@objectstack/lint` without adding the
 * row that routes a metadata type into it, and this package stops building:
 * the dts build reports `TS2344` here. Measured, not assumed — a type error
 * confined to this file fails `pnpm --filter @objectstack/metadata-protocol
 * build` with `DTS Build error`, which is what CI's workspace build runs.
 *
 * The red arrives after `@objectstack/lint` is REBUILT, because the type
 * crosses the package wall through `dist/runtime.d.ts`. That is inherent to
 * the boundary and is the same latency the `satisfies` clause above and
 * `protocol.ts`'s `-?` accumulator already have; turbo's dependency order
 * makes it unconditional in CI.
 *
 * ## Why an assertion rather than a derivation
 *
 * A derivation would have to read the context-collection set as a VALUE, and
 * `metadata-protocol` cannot: `CONTEXT_STACK_KEYS` is module-private in
 * `runtime-gate.ts` and appears on neither of `@objectstack/lint`'s entries.
 * Reaching it would mean widening the deliberately narrow
 * `@objectstack/lint/runtime` entry — a package-boundary change — to buy the
 * same red this costs nothing to get. The TYPE is already here; only the
 * completeness question needed asking.
 *
 * Exported because `noUnusedLocals` is on: a local alias nothing reads is a
 * hard `TS6196` here, so an unexported guard would not compile at all.
 */
export type ClosureRoutingCoversEveryContextCollection =
 NoUnroutedContextCollection<UnroutedContextCollections>;

/**
 * The live collection with this batch's pending drafts folded in — REPLACING
 * by name, never appended beside.
Expand Down
Loading