Skip to content

fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-project-manager merged 1 commit into from
Sep 1, 2026
+106 −8
Merged

fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory #14009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 106 additions & 8 deletions scripts/import-prerequisite.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
* exit 1
*
* Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
* reading. The expensive direction is not the lost minutes: a dev who assumes
* reading — which is why the guarded refusal below does NOT keep that number
* (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
* minutes: a dev who assumes
* "this needs an install" and moves on has recorded a gate as RUN when it never
* executed a single assertion, and a seat that reads the stack as a verdict
* reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
* Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
* what went unmeasured stays with the gate. Only the gate knows what it did not
* check, and "nothing was measured" is the load-bearing half of the message.
*
* ## The exit code is 3 — the class every sibling already answers these words with
*
* A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
* says the same number in the same stroke. That constant's comment carries the
* argument, the five sites that had already written the contract, and the true
* half of the counter-argument this replaced.
*/
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
* The exit-code contract, NAMED rather than spelled inline at each site, so the
* self-test pins the value each path actually returns instead of a comment
* about it — `check-test-completeness.mjs`'s shape, and the one
* `check-type-check-coverage.mjs` adopted in PR #13982.
*
* ## Why 3, when this frame argued for 1 until #13983
*
* Because 3 is what every OTHER gate in this repo means by these two words.
* Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
* places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
* length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
* `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
* constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
* declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
* to render "the runner could not reach the board" instead of "the sweep
* failed", so a consumer that reads 3 by value already exists.
*
* ⚠️ The argument this replaces stood in this file, and half of it was right:
* *"a second failure code would be a new contract nobody asked for"*.
*
* • The half that HOLDS: nothing mechanical changes. Every consumer of the
* gates that import this frame treats any non-zero as failure — measured,
* not assumed: the `&&` chains in the root `package.json`, the bare `run:`
* steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
* branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
* zero CI benefit today and must not be sold as if it did.
* • The half that does NOT: it is not a new contract. The contract was
* already written, by the five sites above. What this frame was doing was
* CONTRADICTING it from the largest inheritance surface in the repo — the
* closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
* importing gates. A reader (or a gate-reconciling agent) who learned "3
* means nothing was measured" from those five read all 45 backwards.
*
* ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
* is still that gate's own exit 1, and this module never touches it. And the
* refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
* fires at all were all correct already.
*/
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
* A gate's real verdict — NOT this module's to produce. Named here for the one
* thing the advisory has to do that the number alone cannot: say which code it
* is distinct FROM.
*/
export const EXIT_FINDINGS = 1;

/**
* The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
* `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
* Load a dependency, or refuse with a diagnosis and exit 1.
* Load a dependency, or refuse with a diagnosis and exit
* `EXIT_PREREQUISITE_NOT_MET`.
*
* Exits 1, the code every real verdict uses: any wrapper treating non-zero as
* failure keeps behaving identically, and a second failure code would be a new
* contract nobody asked for. The reading a caller MUST be able to make is not in
* the code — it is in the printed text, which says nothing was measured.
* The code and the printed advisory move together — a number changed without
* the prose would leave 45 gates inheriting a FALSE advisory, which is worse
* than either number consistently applied. Why 3, and what did not change, is
* on the constant. The reading a caller MUST be able to make is still in the
* printed text, which says nothing was measured; the code is what a reader who
* sees only the number gets, and it now agrees with the text.
*
* @param {string} specifier e.g. `'typescript'`
* @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
*/
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
process.exit(1);
process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
` Nothing was measured: this gate exited before running a single check, so this\n` +
` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
` evidence that anything in the tree is wrong.\n` +
` (Exit code 1 — capture it BEFORE any pipe:\n` +
` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
!/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

// ── the exit-code CLASS, and the advisory that must move with it ──────────
//
// Pinned over the FUNCTION BODIES rather than over the constant alone —
// PR #13982's shape, for the same reason it gave: the regression that costs
// something is not a mistyped constant. It is a `process.exit(1)` written
// back into the refusal by an author who never thought about exit codes, or a
// number typed into the advisory instead of interpolated. Either leaves the
// constant reading 3, every consumer green (they all treat any non-zero as
// failure, so 1-instead-of-3 is invisible to all of them), and a message that
// still reads perfectly right. Nothing else in this repo would notice.
const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
t('the refusal exits through the named constant, never a literal',
!hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
t('the advisory INTERPOLATES the code rather than spelling one',
!spellsALiteralCode(prerequisiteNotMetText));
// The NEGATIVE CONTROLS, and the reason the two cases above are measurements
// rather than tautologies: each predicate is run against a function that does
// the forbidden thing and must SEE it. Without these, one typo in either
// regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
// control is ever CALLED; they exist to be read by `toString()`.
const controlHardcodedExit = () => { process.exit(1); };
const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

t('the refusal class is 3 — the code four sibling gates answer these words with',
EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
t('the refusal class is distinct from a finding and from a pass',
EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
t('the advisory names its own code AND the finding code it is distinct from',
advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
&& advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
// The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
// the text is a false advisory inherited by all 45 importers.
t('the advisory carries NO stale spelling of the old code',
!/Exit code 1\b/.test(advisory), advisory);

const failed = cases.filter((c) => !c.ok);
for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
if (failed.length) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory by claude[bot] · Pull Request #14009 · objectstack-ai/objectstack · GitHub
Skip to content
fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory#14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 1 commit into

from

Sep 1, 2026

+106

−8

 Merged


fix(scripts): answer an import-prerequisite refusal with exit 3, in one stroke with its advisory
#14009
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


114 changes: 106 additions & 8 deletions
scripts/import-prerequisite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,9 @@
 * exit 1
 *
 * Exit 1 from an unmet prerequisite and exit 1 from a real finding are the same
 * reading. The expensive direction is not the lost minutes: a dev who assumes
 * reading — which is why the guarded refusal below does NOT keep that number
 * (see `EXIT_PREREQUISITE_NOT_MET`). The expensive direction is not the lost
 * minutes: a dev who assumes
 * "this needs an install" and moves on has recorded a gate as RUN when it never
 * executed a single assertion, and a seat that reads the stack as a verdict
 * reports a false RED against whatever landed most recently. Both were measured
Expand DownExpand Up@@ -67,6 +69,13 @@
 * Following `cli-build-prerequisite.mjs`: the FRAME is shared, the claim about
 * what went unmeasured stays with the gate. Only the gate knows what it did not
 * check, and "nothing was measured" is the load-bearing half of the message.
 *
 * ## The exit code is 3 — the class every sibling already answers these words with
 *
 * A refusal here exits `EXIT_PREREQUISITE_NOT_MET`, and the printed advisory
 * says the same number in the same stroke. That constant's comment carries the
 * argument, the five sites that had already written the contract, and the true
 * half of the counter-argument this replaced.
 */
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
Expand All@@ -78,6 +87,54 @@ import { isEntrypoint } from './invoked-as.mjs';
/** `pnpm install` at the repo root — the one remedy for an absent dependency. */
export const INSTALL_FIX = 'pnpm install';

/**
 * The exit-code contract, NAMED rather than spelled inline at each site, so the
 * self-test pins the value each path actually returns instead of a comment
 * about it — `check-test-completeness.mjs`'s shape, and the one
 * `check-type-check-coverage.mjs` adopted in PR #13982.
 *
 * ## Why 3, when this frame argued for 1 until #13983
 *
 * Because 3 is what every OTHER gate in this repo means by these two words.
 * Measured on this tree, `PREREQUISITE NOT MET` is already exit 3 in five
 * places: `check-test-completeness.mjs` (`EXIT_PREREQUISITE_NOT_MET`, argued at
 * length in its header), `check-dual-build-cjs-loads.mjs` (`EXIT_PREREQ`),
 * `check-type-check-coverage.mjs`, and `pm/check-half-states.mjs` — whose
 * constant `pm/ci-failure.mjs` IMPORTS rather than re-picks. It is not only
 * declared: `half-state-patrol.yml` branches on the number (`exitCode === 3`)
 * to render "the runner could not reach the board" instead of "the sweep
 * failed", so a consumer that reads 3 by value already exists.
 *
 * ⚠️ The argument this replaces stood in this file, and half of it was right:
 * *"a second failure code would be a new contract nobody asked for"*.
 *
 * • The half that HOLDS: nothing mechanical changes. Every consumer of the
 * gates that import this frame treats any non-zero as failure — measured,
 * not assumed: the `&&` chains in the root `package.json`, the bare `run:`
 * steps in `lint.yml`/`ci.yml`, and `required-set-patrol.yml`, which
 * branches on `== '0'` / `!= '0'` and nothing finer. ⛔ This change buys
 * zero CI benefit today and must not be sold as if it did.
 * • The half that does NOT: it is not a new contract. The contract was
 * already written, by the five sites above. What this frame was doing was
 * CONTRADICTING it from the largest inheritance surface in the repo — the
 * closing paragraph of `prerequisiteNotMetText` is printed verbatim by 45
 * importing gates. A reader (or a gate-reconciling agent) who learned "3
 * means nothing was measured" from those five read all 45 backwards.
 *
 * ⛔ ONLY the prerequisite branch has a code of its own. A gate's real verdict
 * is still that gate's own exit 1, and this module never touches it. And the
 * refusal itself is unchanged: what a refusal SAYS, when it fires, and that it
 * fires at all were all correct already.
 */
export const EXIT_PREREQUISITE_NOT_MET = 3;

/**
 * A gate's real verdict — NOT this module's to produce. Named here for the one
 * thing the advisory has to do that the number alone cannot: say which code it
 * is distinct FROM.
 */
export const EXIT_FINDINGS = 1;

/**
 * The package a bare specifier names, subpath removed: `yaml/util` -> `yaml`,
 * `@objectstack/spec/system` -> `@objectstack/spec`. Returns '' for a relative or
Expand DownExpand Up@@ -350,12 +407,15 @@ export function classifyImportFailure(specifier, err, fromDir) {
}

/**
 * Load a dependency, or refuse with a diagnosis and exit 1.
 * Load a dependency, or refuse with a diagnosis and exit
 * `EXIT_PREREQUISITE_NOT_MET`.
 *
 * Exits 1, the code every real verdict uses: any wrapper treating non-zero as
 * failure keeps behaving identically, and a second failure code would be a new
 * contract nobody asked for. The reading a caller MUST be able to make is not in
 * the code — it is in the printed text, which says nothing was measured.
 * The code and the printed advisory move together — a number changed without
 * the prose would leave 45 gates inheriting a FALSE advisory, which is worse
 * than either number consistently applied. Why 3, and what did not change, is
 * on the constant. The reading a caller MUST be able to make is still in the
 * printed text, which says nothing was measured; the code is what a reader who
 * sees only the number gets, and it now agrees with the text.
 *
 * @param {string} specifier e.g. `'typescript'`
 * @param {() => Promise<any>} load `() => import('typescript')`, written in the CALLER
Expand DownExpand Up@@ -424,7 +484,7 @@ export async function requireDefaultExport(specifier, load, importerUrl, options
 */
export function reportPrerequisiteNotMet(importerUrl, verdict, measures) {
 console.error(prerequisiteNotMetText(importerUrl, verdict, measures));
 process.exit(1);
 process.exit(EXIT_PREREQUISITE_NOT_MET);
}

/**
Expand All@@ -441,7 +501,7 @@ function prerequisiteNotMetText(importerUrl, verdict, measures) {
 ` Nothing was measured: this gate exited before running a single check, so this\n` +
 ` result says NOTHING about ${subject}. It is NOT a finding, and it is not\n` +
 ` evidence that anything in the tree is wrong.\n` +
 ` (Exit code 1 — capture it BEFORE any pipe:\n` +
 ` (Exit code ${EXIT_PREREQUISITE_NOT_MET}, distinct from a finding's ${EXIT_FINDINGS} — capture it BEFORE any pipe:\n` +
 ` \`node scripts/${gate}.mjs > /tmp/${gate}.log 2>&1; echo "EXIT=$?"\`.\n` +
 ` Piped, \`$?\` is the LAST command's status, and \`head\`/\`tail\` essentially never fail — that\n` +
 ` is the false green, and no pipe shape repairs it. \`\${PIPESTATUS[0]}\`/\`pipefail\` do recover\n` +
Expand DownExpand Up@@ -652,6 +712,44 @@ export function selfTest() {
 t('the advisory does NOT claim a pipe shape defeats `${PIPESTATUS[0]}`/`pipefail`',
 !/turns even .*PIPESTATUS.*green|reads green either way/.test(advisory));

 // ── the exit-code CLASS, and the advisory that must move with it ──────────
 //
 // Pinned over the FUNCTION BODIES rather than over the constant alone —
 // PR #13982's shape, for the same reason it gave: the regression that costs
 // something is not a mistyped constant. It is a `process.exit(1)` written
 // back into the refusal by an author who never thought about exit codes, or a
 // number typed into the advisory instead of interpolated. Either leaves the
 // constant reading 3, every consumer green (they all treat any non-zero as
 // failure, so 1-instead-of-3 is invisible to all of them), and a message that
 // still reads perfectly right. Nothing else in this repo would notice.
 const hardcodesExitCall = (fn) => /process\.exit\(\s*\d/.test(fn.toString());
 const spellsALiteralCode = (fn) => /Exit code \d/.test(fn.toString());
 t('the refusal exits through the named constant, never a literal',
 !hardcodesExitCall(reportPrerequisiteNotMet), reportPrerequisiteNotMet.toString());
 t('the advisory INTERPOLATES the code rather than spelling one',
 !spellsALiteralCode(prerequisiteNotMetText));
 // The NEGATIVE CONTROLS, and the reason the two cases above are measurements
 // rather than tautologies: each predicate is run against a function that does
 // the forbidden thing and must SEE it. Without these, one typo in either
 // regex passes forever — a pin that cannot fail is not a pin. ⛔ Neither
 // control is ever CALLED; they exist to be read by `toString()`.
 const controlHardcodedExit = () => { process.exit(1); };
 const controlLiteralAdvisory = () => ` (Exit code 1 — capture it BEFORE any pipe:`;
 t('NEGATIVE CONTROL: the literal-exit pin can still fail', hardcodesExitCall(controlHardcodedExit));
 t('NEGATIVE CONTROL: the literal-advisory pin can still fail', spellsALiteralCode(controlLiteralAdvisory));

 t('the refusal class is 3 — the code four sibling gates answer these words with',
 EXIT_PREREQUISITE_NOT_MET === 3, String(EXIT_PREREQUISITE_NOT_MET));
 t('the refusal class is distinct from a finding and from a pass',
 EXIT_PREREQUISITE_NOT_MET !== EXIT_FINDINGS && EXIT_PREREQUISITE_NOT_MET !== 0);
 t('the advisory names its own code AND the finding code it is distinct from',
 advisory.includes(`Exit code ${EXIT_PREREQUISITE_NOT_MET}`)
 && advisory.includes(`a finding's ${EXIT_FINDINGS}`), advisory);
 // The one stroke Zone 1.2 of this card is about: a stale spelling anywhere in
 // the text is a false advisory inherited by all 45 importers.
 t('the advisory carries NO stale spelling of the old code',
 !/Exit code 1\b/.test(advisory), advisory);

 const failed = cases.filter((c) => !c.ok);
 for (const c of failed) console.error(` ✗ ${c.name}${c.detail ? ` -- ${c.detail}` : ''}`);
 if (failed.length) {
Expand Down
Loading