Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions content/docs/permissions/authentication.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -850,11 +850,12 @@ fallback: omit it and the member simply joins no team.

<Callout type="warn" title="This is an ObjectStack mount, not a better-auth route">
better-auth declares `addMember` as a **server-only** API with no HTTP path of
its own — measured on 1.7.1, where `addMember` builds its endpoint with no path
argument while every sibling in the same module (`/organization/remove-member`,
`/organization/list-members`, `/organization/leave`, …) passes one. So the
vendor's documentation does not list this URL, and an audit that enumerates
better-auth's mounted surface will not find it there either. ObjectStack mounts it ahead of the
its own — measured on the then-installed 1.7.1, where `addMember` builds its
endpoint with no path argument while every sibling in the same module
(`/organization/remove-member`, `/organization/list-members`,
`/organization/leave`, …) passes one. So the vendor's documentation does not
list this URL, and an audit that enumerates better-auth's mounted surface will
not find it there either. ObjectStack mounts it ahead of the
catch-all and wraps the vendor's server-only endpoint; the vendor's own checks
(already-a-member, membership limit, team resolution, hooks) are not
reimplemented.
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/test/init.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -388,13 +388,13 @@ describe('benign peer-skew declarations (#10326)', () => {

it('kept the @better-auth/utils widening when the better-call pin retired (#3653)', () => {
// @better-auth/scim appeared in TWO entries for two unrelated reasons, and
// they retire on different days — which HAPPENED: the better-call one went
// with the rc pin (stable 1.7.1 peers better-call 1.4.0), while the utils
// one outlives it (stable 1.7.1 still peers @better-auth/utils 0.4.2;
// its own retirement key is the pnpm 10.31 floor). Deleting both together
// — the obvious move when the rc pin lifted — would have silently put the
// utils report back on a newcomer's first screen; this pin is what stops
// that regression from ever landing quietly.
// they retire on different days — which HAPPENED in #3653: the better-call
// one went with the rc pin (stable 1.7.1 peers better-call 1.4.0), while
// the utils one outlives it (stable 1.7.1 still peers @better-auth/utils
// 0.4.2; its own retirement key is the pnpm 10.31 floor). Deleting both
// together — the obvious move when the rc pin lifted — would have silently
// put the utils report back on a newcomer's first screen; this pin is what
// stops that regression from ever landing quietly.
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>better-call']).toBeUndefined();
expect(SCAFFOLD_ALLOWED_PEER_VERSIONS['@better-auth/scim>@better-auth/utils']).toBe('0.5.0');
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,8 +105,9 @@ const isPlainObject = (v: unknown): v is Record<string, unknown> =>

/**
* The permission-query bodies the installed vendor handler EVALUATES, and no
* others (see the header for why both directions matter). Measured on
* better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`, `userHasPermission`):
* others (see the header for why both directions matter). Measured on the
* then-installed better-auth 1.7.1 (`dist/plugins/admin/routes.mjs`,
* `userHasPermission`):
*
* - the zod body schema is `{ userId?: coerce.string, role?: string }`
* intersected with `xor(permission | permissions)`, each a
Expand Down
7 changes: 4 additions & 3 deletions packages/plugins/plugin-auth/src/auth-manager.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2101,9 +2101,10 @@ export class AuthManager {
// resolved `baseURL` origin and treats `trustedOrigins` as purely
// ADDITIVE, so an empty list and an omitted key are equivalent and
// both leave exactly the deployment's own origin trusted; every other
// origin is refused with `403 INVALID_ORIGIN`. Measured against
// better-auth 1.7.1 (`getTrustedOrigins` in `dist/context/helpers.mjs`,
// `validateOrigin` in `dist/api/middlewares/origin-check.mjs`).
// origin is refused with `403 INVALID_ORIGIN`. Measured against the
// then-installed better-auth 1.7.1 (`getTrustedOrigins` in
// `dist/context/helpers.mjs`, `validateOrigin` in
// `dist/api/middlewares/origin-check.mjs`).
if (
process.env.NODE_ENV !== 'production' &&
!origins.length && (!corsOrigin || corsOrigin === '*')
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-auth/src/auth-plugin.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2556,7 +2556,7 @@ export class AuthPlugin implements Plugin {
// ────────────────────────────────────────────────────────────────────
// #9941 — organization/add-member. better-auth declares `addMember`
// WITHOUT an HTTP path (server-only `auth.api.addMember`; measured on the
// installed 1.7.1), so the catch-all never mounts it — yet the
// then-installed 1.7.1), so the catch-all never mounts it — yet the
// `sys_member` `add_member` toolbar action has always targeted this URL,
// and on a multi-org posture it is the only UI path that can attach an
// existing user to an organization. This mount restores that declared
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* ── Why this mount exists (the measurement) ─────────────────────────────────
*
* better-auth declares `addMember` WITHOUT an HTTP path — measured on the
* installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* then-installed 1.7.1, `dist/plugins/organization/routes/crud-members.mjs`:
* `addMember` returns `createAuthEndpoint({ method: "POST", ... })` (no path
* argument), while its siblings keep theirs
* (`createAuthEndpoint("/organization/remove-member", …)`,
Expand Down
Loading
Loading