Uh oh!
There was an error while loading. Please reload this page.
fix(example-crm): migrate workflows to state-machine schema - #1403
Merged
Conversation
The `workflow` metadata type was reclaimed for state machines (`StateMachineSchema`), but app-crm's two example workflows were still declared as the legacy `Automation.WorkflowRule`, so `defineStack` validation rejects them and the example build/boot fails. Migrate both to `StateMachineConfig`, preserving the original intent as guarded transitions: - high-value-deal: `open` --UPDATE[amount>100k]--> `high_value` (email_alert to sales managers); closes won/lost. - stale-opportunity: `active` --STALE_30D[open]--> `flagged` (email_alert + task_creation follow-up); `UPDATED` clears back to `active`; closes won/lost.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate app-crm's two example workflows from the legacy
Automation.WorkflowRuleto the state-machineStateMachineConfig(theworkflowmetadata type now maps toStateMachineSchema).Why
The
workflowtype was reclaimed for state machines, but the example workflows were never migrated — sodefineStackvalidation fails (workflows.0.id / initial / statesrequired) and the example build/boot is broken onmain. This also blocks every framework PR, since CI's Build Core compiles the example app.Changes
open—UPDATE[amount>100k]→high_value(email_alert to sales managers);won/lostfinal.active—STALE_30D[open]→flagged(email_alert + task_creation follow-up);UPDATEDclears back toactive;won/lostfinal.Both preserve the original rules' intent as guarded transitions + entry actions.
Notes
@objectstack/example-crmisprivate→ no changeset. Prerequisite for the datasource-action refactor PR (#1402), which will rebase onto this.