Uh oh!
There was an error while loading. Please reload this page.
feat(automation): connector_action as baseline generic dispatch + connector-rest (ADR-0018) - #1416
Merged
Merged
Conversation
…nector-rest (ADR-0018) Promote `connector_action` to a built-in baseline node — the generic-dispatch counterpart to `http_request`: where http_request calls any raw URL, connector_action invokes any registered connector's declared action. - engine: connector registry (registerConnector / unregisterConnector / resolveConnectorAction / getRegisteredConnectors) + ConnectorActionHandler / ConnectorActionContext / RegisteredConnector types. registerConnector validates via ConnectorSchema and asserts every declared action has a handler. - builtin/connector-nodes.ts: connector_action executor (source:'builtin', category:'io', all three paradigms), wired into installBuiltinNodes() — the core plugin now seeds 11 baseline node types. Missing connector fails the step (not flow registration) with a clear error. - packages/connectors/connector-rest (@objectstack/connector-rest): the reference concrete connector. createRestConnector + ConnectorRestPlugin, `request` action, static auth (none/api-key/basic/bearer), no OAuth2 refresh (enterprise tier). - New packages/connectors/ workspace category (alongside plugins/services/adapters). - ADR-0018 §Addendum: records the decision, resolves Open-question #1, supersedes M2's "connector_action dropped from baseline". Tests: service-automation 87/87, connector-rest 10/10 (incl. end-to-end kernel boot: both plugins -> connector_action flow -> REST handler).
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
| /** Build the request URL from base + path + query, encoding query params. */ | ||
| function buildUrl(baseUrl: string, path: string, query?: RestRequestInput['query']): string { | ||
| const base = baseUrl.replace(/\/+$/, ''); |
| @@ -0,0 +1,139 @@ | |||
| // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license. | |||
| import { describe, it, expect, vi } from 'vitest'; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promotes
connector_actionto a built-in baseline node — the generic-dispatch counterpart tohttp_request. Wherehttp_requestcalls any raw URL,connector_actioninvokes any registered connector's declared action. Adds the first concrete connector,@objectstack/connector-rest, as the reference plugin.Resolves ADR-0018 §Open-questions #1 and supersedes M2's "connector_action dropped from baseline". See the ADR-0018 §Addendum.
Changes
Baseline mechanism —
service-automationengine.ts: connector registry (registerConnector/unregisterConnector/resolveConnectorAction/getRegisteredConnectors) +ConnectorActionHandler/ConnectorActionContext/RegisteredConnectortypes.registerConnectorvalidates viaConnectorSchemaand asserts every declared action has a handler.builtin/connector-nodes.ts(new): theconnector_actionexecutor —source:'builtin',category:'io', all three paradigms. Wired intoinstallBuiltinNodes()→ core plugin now seeds 11 baseline node types. A missing connector fails the step (not flow registration) with a clear error.Reference connector —
packages/connectors/connector-rest(@objectstack/connector-rest)createRestConnector+ConnectorRestPlugin,requestaction, static auth (none/api-key/basic/bearer). No OAuth2 refresh — that's the enterprise tier.packages/connectors/workspace category, alongsideplugins//services//adapters/.Open/enterprise boundary
Mechanism (registry + dispatch node) + static auth = open-source. Managed credentials/vault, OAuth2 refresh, multi-tenant lifecycle, premium connectors, marketplace = enterprise (ADR-0015 datasource precedent). Boundary documented in the
cloudrepo'sconnector-tiering.mddesign note (separate repo).Tests
@objectstack/service-automation: 87/87 (flipped 2 old "NOT baseline" assertions; addedconnector-nodes.test.ts).@objectstack/connector-rest: 10/10, including an end-to-end kernel boot — both plugins →connector_actionflow → REST handler with bearer auth + body, output propagated back.