Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .changeset/view-binding-blocks-complete.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@objectstack/spec': minor
'@objectstack/lint': patch
---

`view/layout-without-binding` now covers every view type that carries a binding block, and a new `view/tree-without-parent-field` rule catches the silently flat tree

`checkViewCompleteness`'s `VIEW_BINDING_BLOCKS` table named `kanban` / `calendar` / `gantt` only, while
`ListViewSchema.type` has six members with a type-specific binding block. The other three fell through
the same trapdoor the rule exists to close: objectui's ListView adapter falls back to literal field
names (`timeline` → `startDateField || 'created_at'`, `titleField || 'name'`; `map` →
`locationField || 'location'`; `tree` → `labelField || titleField || 'name'`), so a view authored
without its block rendered empty — `timeline` drops every row whose start date fails to parse —
while `os validate --json` reported `warnings: []` and `valid: true`. Measured both ways: deleting a
`timeline` block was silent, deleting the sibling `gantt` block warned as designed.

- The table now names all six. Each new entry carries a `fix` hint naming the keys that make the block
a binding (`timeline`'s two schema-required keys; either coordinate form for `map`; `parentField` +
`labelField` for `tree`). Severity stays `warning` (ADR-0078 §1 — the view degrades, it does not die).
- `map` is read for its coordinate binding, not merely for block presence: `ListMapConfigSchema` requires
no key, so a `map` block declaring neither `locationField` nor the `latitudeField`/`longitudeField`
pair is the same unbound view with braces and is warned about at `map.locationField`.
- **New rule `view/tree-without-parent-field`** (warning, path `tree.parentField`): a `type: 'tree'` view
with no declared `parentField` on an object that carries neither a `tree` field nor a
`lookup`/`master_detail` back to itself renders FLAT — every record at depth 0, a correct-looking table
whose expand slot never opens. Every `TreeConfigSchema` key is optional, so `tree: {}` satisfies the
block check and still renders flat; this rule mirrors objectui's `detectParentField` exactly, so a
view the renderer resolves by auto-detection is never warned about.
- `checkViewCompleteness(view, boundObject?)` takes the bound object definition as an optional second
argument (additive; one-argument callers are unchanged and the tree rule stays silent for them).
`@objectstack/lint`'s `validate-functional-completeness` resolves the object by name from
`stack.objects` — the list view's own `data.object` first, then the container's binding — and hands
it over; no rule logic moved into lint.
- `gallery` is measured (`titleField || 'name'`) and deliberately not added: its schema has no binding key
to demand. `page` stays deliberately absent (a `page` view refuses at parse via `checkListViewPageMount`).

Under `os validate --strict` the new warnings are failures, as every warning in this family is.
116 changes: 116 additions & 0 deletions packages/lint/src/validate-functional-completeness.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@

import { describe, expect, it } from 'vitest';

import { runAuthoringRules, splitBySeverity } from './authoring-rules.js';
import { validateFunctionalCompleteness } from './validate-functional-completeness.js';

const bareSummary = { type: 'summary' };
Expand DownExpand Up@@ -85,6 +86,52 @@ describe('validateFunctionalCompleteness — the walk', () => {
expect(findings.every((f) => f.severity === 'warning')).toBe(true);
});

it('hands the bound object to the view predicate — the tree parent pointer resolves against `stack.objects`', () => {
// The predicate's tree rule needs the object's fields; this proves the
// walk actually delivers them, in every resolution the sibling
// reference-integrity rules use. Array-form objects, container binding:
const flat = validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [{ name: 'name', type: 'text' }] }],
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
});
expect(flat.map((f) => [f.rule, f.severity, f.path])).toEqual([
['view/tree-without-parent-field', 'warning', 'views[0].listViews.org.tree.parentField'],
]);
expect(flat[0].where).toMatch(/› listViews\.org$/);

// Map-form objects (the walk injects `name`), a self-lookup → silent.
expect(validateFunctionalCompleteness({
objects: { unit: { fields: { parent: { type: 'lookup', reference: 'unit' } } } },
views: [{ object: 'unit', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);

// The container's default `list` slot is handed the object too.
expect(validateFunctionalCompleteness({
objects: [{ name: 'unit', fields: [] }],
views: [{ object: 'unit', list: { type: 'tree', tree: {} } }],
}).map((f) => f.path)).toEqual(['views[0].list.tree.parentField']);

// A list view's own `data.object` retargets the lookup (ADR-0047):
// `cat` carries a `tree` field, so the view bound to it is clean even
// though the container's object has nothing to detect.
expect(validateFunctionalCompleteness({
objects: [
{ name: 'unit', fields: [] },
{ name: 'cat', fields: [{ name: 'parent', type: 'tree' }] },
],
views: [{
object: 'unit',
listViews: { org: { type: 'tree', tree: {}, data: { provider: 'object', object: 'cat' } } },
}],
})).toEqual([]);

// An object the stack does not declare: nothing is handed over and the
// tree rule stays silent — `validate-object-references` owns that miss.
expect(validateFunctionalCompleteness({
views: [{ object: 'ghost', listViews: { org: { type: 'tree', tree: {} } } }],
})).toEqual([]);
});

it('walks webhooks in both spellings', () => {
expect(validateFunctionalCompleteness({
webhooks: [{ name: 'notify', url: 'https://x' }],
Expand DownExpand Up@@ -128,3 +175,72 @@ describe('validateFunctionalCompleteness — the walk', () => {
}
});
});

/**
* The card's acceptance criteria, pinned end-to-end through the rule table
* (the #14108 precedent): `timeline` / `map` / `tree` without their binding
* block must produce a diagnostic on `os validate` (and `os build`), and a
* `tree` view bound to an object with no self-reference must produce one
* whether its block is empty or absent. The clean twins prove the fixtures
* fail for the right reason.
*/
describe('#14106 acceptance — timeline / map / tree bindings reach `validate` AND `build`', () => {
const object = {
name: 'duly_task',
fields: {
subject: { type: 'text' },
last_update_at: { type: 'datetime' },
site: { type: 'text' },
},
};
const repro = {
objects: [object],
views: [{
object: 'duly_task',
listViews: {
recent: { type: 'timeline', columns: ['subject'] },
sites: { type: 'map', columns: ['subject'] },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
flatter: { type: 'tree', columns: ['subject'] },
},
}],
};
const clean = {
objects: [{
...object,
fields: { ...object.fields, parent: { type: 'lookup', reference: 'duly_task' } },
}],
views: [{
object: 'duly_task',
listViews: {
recent: {
type: 'timeline', columns: ['subject'],
timeline: { startDateField: 'last_update_at', titleField: 'subject' },
},
sites: { type: 'map', columns: ['subject'], map: { locationField: 'site' } },
flat: { type: 'tree', tree: {}, columns: ['subject'] },
declared: { type: 'tree', tree: { parentField: 'parent' }, columns: ['subject'] },
},
}],
};
const BINDING_RULES = ['view/layout-without-binding', 'view/tree-without-parent-field'];

for (const command of ['validate', 'build'] as const) {
it(`the measured repro is diagnosed by \`${command}\``, () => {
const { advisories } = splitBySeverity(runAuthoringRules(command, { normalized: repro as never }));
const hits = advisories.filter((f) => BINDING_RULES.includes(f.rule)).map((f) => `${f.rule} @ ${f.path}`).sort();
expect(hits).toEqual([
'view/layout-without-binding @ views[0].listViews.flatter.tree',
'view/layout-without-binding @ views[0].listViews.recent.timeline',
'view/layout-without-binding @ views[0].listViews.sites.map',
'view/tree-without-parent-field @ views[0].listViews.flat.tree.parentField',
'view/tree-without-parent-field @ views[0].listViews.flatter.tree.parentField',
]);
});

it(`the bound stack passes \`${command}\``, () => {
const { errors, advisories } = splitBySeverity(runAuthoringRules(command, { normalized: clean as never }));
expect([...errors, ...advisories].filter((f) => BINDING_RULES.includes(f.rule))).toEqual([]);
});
}
});
27 changes: 25 additions & 2 deletions packages/lint/src/validate-functional-completeness.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,15 +103,38 @@ export function validateFunctionalCompleteness(stack: unknown): FunctionalComple
// ── List views: views[] containers → list / listViews.* ────────────────
// (Form views carry no layout-binding contract; field completeness inside
// objects is already covered above.)
//
// The predicate takes the BOUND OBJECT as its optional second argument —
// the `tree` parent-pointer rule needs the object's fields to ask whether
// the renderer could auto-detect one. This is wiring only: the object is
// looked up by name in `stack.objects` (already normalized to an array, so
// both authorable spellings arrive with a `name`), resolved in the order
// the sibling reference-integrity rules use — a list view's own
// `data.object` retarget first (ADR-0047), then the container's binding —
// and handed over. Absent from the stack, nothing is handed and the
// predicate stays silent on that rule; the dangling `data.object` itself
// is `validate-object-references`' finding.
const objectsByName = new Map(entriesOf(stack.objects).map((o) => [o.name, o.def]));
const strName = (v: unknown): string | undefined => (typeof v === 'string' && v ? v : undefined);
const boundObjectOf = (view: AnyRec, container: AnyRec): AnyRec | undefined => {
const own = isRec(view.data) ? strName(view.data.object) : undefined;
const name = own ?? strName(container.objectName) ?? strName(container.object);
return name ? objectsByName.get(name) : undefined;
};
for (const [vi, container] of entriesOf(stack.views).entries()) {
const where = container.def.object ? `view container "${container.name}"` : `view container [${vi}]`;
if (isRec(container.def.list)) {
push(out, checkViewCompleteness(container.def.list), `${where} › list`, `views[${vi}].list`);
push(
out,
checkViewCompleteness(container.def.list, boundObjectOf(container.def.list, container.def)),
`${where} › list`,
`views[${vi}].list`,
);
}
for (const lv of entriesOf(container.def.listViews)) {
push(
out,
checkViewCompleteness(lv.def),
checkViewCompleteness(lv.def, boundObjectOf(lv.def, container.def)),
`${where} › listViews.${lv.name}`,
`views[${vi}].listViews${lv.key}`,
);
Expand Down
1 change: 1 addition & 0 deletions packages/spec/api-surface/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError (type)",
"ValidationErrorSchema (const)",
"ValidationResult (type)",
Expand Down
1 change: 1 addition & 0 deletions packages/spec/export-origins/kernel.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -442,6 +442,7 @@
"UpgradeSnapshotParsed": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotParsed (type)",
"UpgradeSnapshotSchema": "src/kernel/package-upgrade.zod.ts#UpgradeSnapshotSchema (const)",
"VIEW_LAYOUT_WITHOUT_BINDING": "src/kernel/functional-completeness.ts#VIEW_LAYOUT_WITHOUT_BINDING (const)",
"VIEW_TREE_WITHOUT_PARENT_FIELD": "src/kernel/functional-completeness.ts#VIEW_TREE_WITHOUT_PARENT_FIELD (const)",
"ValidationError": "src/kernel/plugin-validator.zod.ts#ValidationError (type)",
"ValidationErrorSchema": "src/kernel/plugin-validator.zod.ts#ValidationErrorSchema (const)",
"ValidationResult": "src/kernel/plugin-validator.zod.ts#ValidationResult (type)",
Expand Down
Loading
Loading