Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/turso-unsafe-identifier-envelope.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@objectstack/driver-turso': patch
'@objectstack/spec': patch
---

drivers(turso): an unsafe identifier on the remote transport answers `400 INVALID_REQUEST`, not an opaque 500

`RemoteTransport.assertSafeIdentifier` is the one gate for every position where
an identifier is inlined into SQL — the `object`, `field` and `groupBy`
field/output-key positions of `aggregate`, the table and column names in
`syncSchema` / `syncSchemasBatch`, and the index name and columns in unique-index
sync — plus the free function of the same name in the remote canonical backfill.
All of them threw a bare `Error` with no `code` and no `status`, so `mapDataError`
reached none of its classifying branches and served a sanitised **500**: a caller
whose own identifier was refused was told the server had faulted, and an SDK
reading a 5xx retries a request that can never succeed.

Every one of those refusals now carries the ADR-0112 envelope `code:
'INVALID_REQUEST'`, `status: 400`, built by one constructor so the positions
cannot answer three ways. `@objectstack/spec` gains only the error-code ledger's
provenance row registering this driver as an emitter of a code seven packages
already register — the registered-code union is byte-identical (248 codes before
and after) and no new code is minted.

**Nothing about which identifiers are refused changed.** `SAFE_IDENTIFIER` and
every refusal message are untouched; exactly the inputs refused before are
refused after, with byte-identical prose. Only `code` and `status` are new.
35 changes: 33 additions & 2 deletions packages/drivers/driver-turso/src/remote-canonical-backfill.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,6 +93,12 @@
* twin's contract calls out, kept across the transport boundary.
*/

// [#14287] The unsafe-identifier refusal's ADR-0112 envelope, from the one
// place that decides it. Imported rather than re-spelled so this module and
// `RemoteTransport` cannot answer one condition two ways; `turso-driver.ts`
// already loads both modules together, so the edge costs nothing at runtime.
import { unsafeIdentifierError } from './remote-transport.js';

/** The `@libsql/client` surface this module uses — nothing more. */
export interface RemoteBackfillClient {
execute(stmt: { sql: string; args?: unknown[] } | string): Promise<{
Expand DownExpand Up@@ -218,9 +224,34 @@ export const REMOTE_BACKFILL_EPOCH_MS_MAX = 4_102_444_800_000;
*/
const SAFE_IDENTIFIER = /^[a-zA-Z_][a-zA-Z0-9_]*$/;

function assertSafeIdentifier(name: string): void {
/**
* [#14287] The second producer of the transport's unsafe-identifier refusal,
* carrying the identical ADR-0112 envelope — `INVALID_REQUEST` / 400 — through
* the one constructor that decides it ({@link unsafeIdentifierError}). One
* condition, one wire answer, whichever of the two helpers refused it.
*
* ## Measured: on THIS module's paths the envelope is defence in depth, not a
* ## wire answer — and saying so is the point
*
* Both callers flatten the throw by design: {@link probeRemoteCanonicalColumns}
* turns it into `{ error: message }` and {@link backfillRemoteCanonicalColumn}
* into `report.error`, because ADR-0053 D-B3 forbids a migration from taking a
* boot down. So `code` and `status` reach no response envelope from here today
* — only the MESSAGE survives, into the report a caller logs. The envelope is
* still worth carrying, for two reasons and no third: the two producers of one
* condition must not drift onto two spellings (the card's own "decide the code
* once" argument), and a future caller that propagates instead of reporting
* inherits the right answer rather than re-deriving one.
*
* ⛔ It is therefore NOT the wire-reachability evidence for this package's
* ledger provenance row — `RemoteTransport`'s DDL and `aggregate` positions
* are, and they answer over HTTP. Exported so the envelope has a real pin: no
* exported path can observe it, and an unobservable assertion is the phantom
* check `AGENTS.md` names rather than a test.
*/
export function assertSafeIdentifier(name: string): void {
if (!SAFE_IDENTIFIER.test(name)) {
throw new Error(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
throw unsafeIdentifierError(`remote canonical backfill: unsafe identifier rejected: "${name}"`);
}
}

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,6 +216,21 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
});

describe('regression controls — the positions this card did NOT touch', () => {
/**
* [#14287] Every control below asserts the ADR-0112 envelope beside the
* sentence, because "still refuses" was the half that was true all along
* and the half that was WRONG was invisible to it: these positions threw a
* bare `Error`, which `mapDataError` served as an opaque 500. #14287 gave
* the one producer `code: 'INVALID_REQUEST'` / `status: 400`. Asserting
* `message` alone here would let a regression to the bare `Error` land
* green through the very controls written to hold this shape.
*/
const envelopeOf = (err: unknown) => ({
code: (err as { code?: unknown }).code,
status: (err as { status?: unknown }).status,
});
const ENVELOPE = { code: 'INVALID_REQUEST', status: 400 };

it('the `field` position still refuses an unsafe identifier, and sends nothing', async () => {
// `SAFE_IDENTIFIER` is doing real work here: `field` becomes a column
// REFERENCE, which is grammar. Escaping is the answer for a NAME only.
Expand All@@ -233,6 +248,8 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
// itself safe is what makes this case reach the `field` check at all.
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('amount"; DROP TABLE showcase_delivery; --');
// [#14287] …and it is a 400 the caller can act on, not an opaque 500.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand All@@ -248,6 +265,7 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
(e) => e as Error,
);
expect(err.message).toContain('unsafe identifier rejected');
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand DownExpand Up@@ -277,6 +295,10 @@ describe('[#14113] RemoteTransport — the aggregation alias is escaped, not gat
);
expect(err.message).toContain('unsafe identifier rejected');
expect(err.message).toContain('showcase_delivery.region');
// [#14287] The GATING is what this control holds; the ENVELOPE is what
// that card added to it. Both are pinned, so the open gating card cannot
// be mistaken for having landed.
expect(envelopeOf(err)).toEqual(ENVELOPE);
expect(seen).toEqual([]);
});

Expand Down
Loading
Loading