fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baozhoutao merged 4 commits into from
Sep 2, 2026
Merged

fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union #14437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21b1b7b
wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…
claude Sep 2, 2026
3bd72a2
fix(lint): resolve dotted dashboard filter fields on the object graph…
claude Sep 2, 2026
6782382
fix(lint): keep the tracker id out of the dashboard-filter finding me…
claude Sep 2, 2026
e685f78
Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…
claude Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .changeset/dashboard-filter-dotted-seam.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
`if (field.includes('.')) continue;`, accurate when nothing in the package could
walk relationship hops and false since the object-graph seam landed. A filter
re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
whether or not `signed_at` existed on it, and whether or not `account` was
declared in the dataset's `include`. It is now walked hop by hop, and a miss
names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
"could this be a system column *anywhere*". On an `ownership: 'none'` object the
platform injects no `owner_id`, and on `systemFields: { audit: false }` no
`created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.
4 changes: 4 additions & 0 deletions packages/lint/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
DASHBOARD_FILTER_FIELD_UNKNOWN,
DASHBOARD_FILTER_FIELD_UNPROVISIONED,
// [#14275] The `include` clause on a DASHBOARD-level filter's effective
// field, now that it is resolved on the object graph rather than skipped
// whenever it was dotted.
DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
// [#14148] The widget's OWN two references, at the same site: the keys of its
// presentation-scope `filter` (resolved on the #14105 object-graph seam, with
// the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down
15 changes: 9 additions & 6 deletions packages/lint/src/system-fields-consumers.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
'(validate-page-field-bindings, #8340), not to the bundle that names it.',
},
'validate-widget-bindings.ts': {
kind: 'rule',
reach: ['direct'],
asksProvenance: true,
why: 'Blanket .has read site. Provenance wired by #8340.',
},
// [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
// `.has` read site was the `dashboard-filter-field-unknown` branch, which now
// resolves through `resolveFieldPath` and therefore through the PER-OBJECT
// `injectedColumnsFor` instead — the distinction this ledger's own header
// calls "the two differ exactly where it matters". Its #8116 obligation did
// not lapse with the row: the rule still asks the provenance question, now
// gated by the verdict's `injected` marker. Recorded here rather than by a
// silent deletion because a shrinking population is the one direction this
// census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union#14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

baozhoutao
merged 4 commits into

from

Sep 2, 2026
 Merged


fix(lint): resolve dotted dashboard filter fields on the object graph and drop the SYSTEM_FIELDS union
#14437
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
21b1b7b

wip(lint): migrate dashboard-filter-field-unknown onto the object-gra…


claude Sep 2, 2026
3bd72a2

fix(lint): resolve dotted dashboard filter fields on the object graph…


claude Sep 2, 2026
6782382

fix(lint): keep the tracker id out of the dashboard-filter finding me…


claude Sep 2, 2026
e685f78

Merge remote-tracking branch 'origin/main' into claude/issue-14275-da…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


41 changes: 41 additions & 0 deletions
.changeset/dashboard-filter-dotted-seam.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
---
'@objectstack/lint': patch
---

lint: `dashboard-filter-field-unknown` resolves dotted dashboard-filter fields on the object graph, and answers system columns per object

A dashboard-level filter (`dateRange`, or a `globalFilters[]` entry) is ANDed into
**every** widget's analytics query, so its effective field — after any
`filterBindings` re-target — has to resolve on each bound widget's dataset object.
The rule that enforces that shipped with two holes, and this closes both by
migrating the check onto the shared `resolveFieldPath` / `joinablePrefixes` seam
the widget's own `filter` keys already use one position over.

- **Dotted paths are no longer skipped.** The branch carried
 `if (field.includes('.')) continue;`, accurate when nothing in the package could
 walk relationship hops and false since the object-graph seam landed. A filter
 re-targeted to `account.signed_at` was unjudged whether or not `account` existed,
 whether or not `signed_at` existed on it, and whether or not `account` was
 declared in the dataset's `include`. It is now walked hop by hop, and a miss
 names **which** hop failed.
- **System columns are resolved per object, not through the flat union.** The old
 test was `objectFields.has(field) || SYSTEM_FIELDS.has(field)`, which answers
 "could this be a system column *anywhere*". On an `ownership: 'none'` object the
 platform injects no `owner_id`, and on `systemFields: { audit: false }` no
 `created_at` — both were answered as resolvable and are now reported.

New error id **`dashboard-filter-field-not-included`**: the effective field
resolves, but its relationship prefix is not declared in the bound dataset's
`include`, so ADR-0021 compiles no join and the column is out of the broadcast
query's reach. It mirrors `widget-filter-field-not-included` one level down, and is
its own id because the fix is a different edit (declare the join, versus point the
filter at something real).

This **narrows the accept set of a shipped gating rule**. Both new answers are
error-tier, so like the rule's other errors they fail `os validate` / `os build`
and the runtime publish gate for `dashboard` writes. Measured over the shipped
dashboard corpus — the three example apps plus the platform's own
`system_overview` — the change is 0 findings before and 0 after; the
`dashboard-filter-field-unprovisioned` warning is unchanged and now travels with
the verdict, so it answers a dotted path landing on an ADR-0015 `external` object
too.

4 changes: 4 additions & 0 deletions
packages/lint/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,10 @@ export {
 WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
 DASHBOARD_FILTER_FIELD_UNKNOWN,
 DASHBOARD_FILTER_FIELD_UNPROVISIONED,
 // [#14275] The `include` clause on a DASHBOARD-level filter's effective
 // field, now that it is resolved on the object graph rather than skipped
 // whenever it was dotted.
 DASHBOARD_FILTER_FIELD_NOT_INCLUDED,
 // [#14148] The widget's OWN two references, at the same site: the keys of its
 // presentation-scope `filter` (resolved on the #14105 object-graph seam, with
 // the ADR-0021 `include` clause its `runtimeFilter` really is subject to) and
Expand Down

15 changes: 9 additions & 6 deletions
packages/lint/src/system-fields-consumers.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -451,12 +451,15 @@ const LEDGER: Record<string, LedgerRow> = {
 'prevent. The blank-column consequence belongs to the surface that RENDERS the anchor ' +
 '(validate-page-field-bindings, #8340), not to the bundle that names it.',
 },
 'validate-widget-bindings.ts': {
 kind: 'rule',
 reach: ['direct'],
 asksProvenance: true,
 why: 'Blanket .has read site. Provenance wired by #8340.',
 },
 // [#14275] `validate-widget-bindings.ts` LEFT the population. Its one blanket
 // `.has` read site was the `dashboard-filter-field-unknown` branch, which now
 // resolves through `resolveFieldPath` and therefore through the PER-OBJECT
 // `injectedColumnsFor` instead — the distinction this ledger's own header
 // calls "the two differ exactly where it matters". Its #8116 obligation did
 // not lapse with the row: the rule still asks the provenance question, now
 // gated by the verdict's `injected` marker. Recorded here rather than by a
 // silent deletion because a shrinking population is the one direction this
 // census cannot distinguish from a broken analyzer.
};

// ── Fixtures: a module set whose right answer is known ────────────────────
Expand Down
Loading
Loading