docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 4 commits into from
Sep 2, 2026
Merged

docs(spec): state minApprovals' real per-behavior default in the schema prose #14543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a386b10
docs(spec): state minApprovals' per-behavior default in the schema prose
claude Sep 2, 2026
cebff4f
docs(spec): regenerate the approval reference table and add the chang…
claude Sep 2, 2026
acaeaa5
Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…
claude Sep 2, 2026
f1aceed
chore(spec): classify minApprovals' omitted threshold in the empty-st…
claude Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/min-approvals-default-prose.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.
2 changes: 1 addition & 1 deletion content/docs/references/automation/approval.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down
10 changes: 10 additions & 0 deletions packages/spec/scripts/liveness/empty-state-registry.mts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
},

{
file: 'packages/spec/src/automation/approval.zod.ts',
property: 'minApprovals',
semantics: 'closed',
rationale:
"The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
evidence:
'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
},

// ---- Scope selectors ---------------------------------------------------

{
Expand Down
20 changes: 20 additions & 0 deletions packages/spec/src/automation/approval.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
expect(perGroup.behavior).toBe('per_group');
expect(perGroup.approvers[0].group).toBe('legal');
});

// The schema injects NO default for `minApprovals`: omitting it leaves the
// key undefined and the enforced threshold is then chosen by `behavior` —
// every resolvable approver under `quorum`, one per group under `per_group`.
// The `.describe()` prose is the only place an author can read that, so pin
// both halves together: a threshold silently declared as 1 while the runtime
// demands unanimity is the drift this test exists to catch.
it('declares the per-behavior default of an omitted minApprovals', () => {
const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
expect(quorum.minApprovals).toBeUndefined();
const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
expect(perGroup.minApprovals).toBeUndefined();

const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
expect(doc).toContain('quorum');
expect(doc).toContain('per_group');
expect(doc).toContain('all resolvable approvers for quorum');
expect(doc).toContain('1 per group for per_group');
expect(doc).not.toContain('Default 1');
});
});

describe('ApprovalEscalationSchema', () => {
Expand Down
11 changes: 8 additions & 3 deletions packages/spec/src/automation/approval.zod.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

/**
* Threshold for `quorum` (total approvals required, M of N) and `per_group`
* (approvals required from EACH group). Defaults to 1. Clamped at runtime so
* it can never exceed the resolvable approver count (no deadlock).
* (approvals required from EACH group). Omitted, the threshold follows the
* behaviour rather than a fixed 1: `quorum` requires every resolvable
* approver, `per_group` requires one approval per group. Clamped at runtime
* so it can never exceed the resolvable approver count (no deadlock).
*/
minApprovals: z.number().int().min(1).optional()
.describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
.describe(
'Approvals required — total (quorum) or per group (per_group). '
+ 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
),

/** Lock the triggering record from edits while this node is pending. */
lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
docs(spec): state minApprovals' real per-behavior default in the schema prose#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-zhuang
merged 4 commits into

from

Sep 2, 2026
 Merged


docs(spec): state minApprovals' real per-behavior default in the schema prose
#14543
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a386b10

docs(spec): state minApprovals' per-behavior default in the schema prose


claude Sep 2, 2026
cebff4f

docs(spec): regenerate the approval reference table and add the chang…


claude Sep 2, 2026
acaeaa5

Merge remote-tracking branch 'origin/main' into claude/issue-13809-mi…


claude Sep 2, 2026
f1aceed

chore(spec): classify minApprovals' omitted threshold in the empty-st…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
.changeset/min-approvals-default-prose.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
---
'@objectstack/spec': patch
---

Approval nodes: `minApprovals` now documents its real per-behavior default.

The property described itself as "Default 1", but an omitted threshold has never
meant 1 under `behavior: 'quorum'` — the approval runtime falls back to the
resolvable approver count, so a quorum node authored without `minApprovals`
requires **every** approver rather than one. Under `behavior: 'per_group'` the
fallback really is one approval per group.

The schema text and the generated reference table now state both defaults. This
is a documentation correction only: no schema default was added, the accepted
value set is unchanged, and no stored approval flow changes behavior.

2 changes: 1 addition & 1 deletion
content/docs/references/automation/approval.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ const result = ApprovalDecision.parse(data);
| :--- | :--- | :--- | :--- |
| **approvers** | `{ type: Enum<'manager' \| 'position' \| 'department' \| 'team' \| 'field' \| 'expression' \| …>; value?: string; resolveAs?: Enum<'user' \| 'department' \| 'position' \| 'team'>; group?: string; … }[]` | ✅ | Allowed approvers for this node |
| **behavior** | `Enum<'first_response' \| 'unanimous' \| 'quorum' \| 'per_group'>` | optional (default: `"first_response"`) | How to combine multiple approvers |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Default 1 |
| **minApprovals** | `integer` | optional | Approvals required — total (quorum) or per group (per_group). Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group |
| **lockRecord** | `boolean` | optional (default: `true`) | Lock the record from editing while pending |
| **approvalStatusField** | `string` | optional | Business-object field to mirror request status onto |
| **onEmptyApprovers** | `Enum<'admin_rescue' \| 'fail' \| 'auto_approve'>` | optional (default: `"admin_rescue"`) | Behavior when no concrete approver resolves at node entry |
Expand Down

10 changes: 10 additions & 0 deletions
packages/spec/scripts/liveness/empty-state-registry.mts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,16 @@ export const EMPTY_STATE_REGISTRY: EmptyStateEntry[] = [
 'packages/core/src/security/resolve-authz-context.ts (resolveAuthzContext.hasPlatformAdminGrant — the single source of truth) and packages/plugins/plugin-security/src/explain-engine.ts (the identical predicate, replicated so the panel cannot overstate)',
 },

 {
 file: 'packages/spec/src/automation/approval.zod.ts',
 property: 'minApprovals',
 semantics: 'closed',
 rationale:
 "The approval threshold of a `quorum` / `per_group` node, and a case where the permissive-looking word is the restrictive one. Omitted under `quorum` the runtime requires EVERY resolvable approver — the threshold falls back to the resolved approver count, so a node whose author never wrote the key blocks until all of them sign, the least-privilege direction rather than the widest. Under `per_group` omission means one approval per group, and every group must still reach it. The `all` in the declared text therefore names APPROVERS REQUIRED, never access granted. Registered rather than reworded around the scanner because that sentence is the only place an author learns the omitted threshold is not 1 — which is precisely the drift this classification exists to keep visible.",
 evidence:
 'packages/plugins/plugin-approvals/src/approval-service.ts (ApprovalService.isApprovalSatisfied — the omitted-threshold fallbacks and their clamp to the resolvable count)',
 },

 // ---- Scope selectors ---------------------------------------------------

 {
Expand Down

20 changes: 20 additions & 0 deletions
packages/spec/src/automation/approval.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -296,6 +296,26 @@ describe('ApprovalNodeConfigSchema', () => {
 expect(perGroup.behavior).toBe('per_group');
 expect(perGroup.approvers[0].group).toBe('legal');
 });

 // The schema injects NO default for `minApprovals`: omitting it leaves the
 // key undefined and the enforced threshold is then chosen by `behavior` —
 // every resolvable approver under `quorum`, one per group under `per_group`.
 // The `.describe()` prose is the only place an author can read that, so pin
 // both halves together: a threshold silently declared as 1 while the runtime
 // demands unanimity is the drift this test exists to catch.
 it('declares the per-behavior default of an omitted minApprovals', () => {
 const quorum = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'quorum' });
 expect(quorum.minApprovals).toBeUndefined();
 const perGroup = ApprovalNodeConfigSchema.parse({ ...minimal, behavior: 'per_group' });
 expect(perGroup.minApprovals).toBeUndefined();

 const doc = ApprovalNodeConfigSchema.shape.minApprovals.description ?? '';
 expect(doc).toContain('quorum');
 expect(doc).toContain('per_group');
 expect(doc).toContain('all resolvable approvers for quorum');
 expect(doc).toContain('1 per group for per_group');
 expect(doc).not.toContain('Default 1');
 });
});

describe('ApprovalEscalationSchema', () => {
Expand Down

11 changes: 8 additions & 3 deletions
packages/spec/src/automation/approval.zod.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -711,11 +711,16 @@ export const ApprovalNodeConfigSchema = lazySchema(() => strictObject(

 /**
 * Threshold for `quorum` (total approvals required, M of N) and `per_group`
 * (approvals required from EACH group). Defaults to 1. Clamped at runtime so
 * it can never exceed the resolvable approver count (no deadlock).
 * (approvals required from EACH group). Omitted, the threshold follows the
 * behaviour rather than a fixed 1: `quorum` requires every resolvable
 * approver, `per_group` requires one approval per group. Clamped at runtime
 * so it can never exceed the resolvable approver count (no deadlock).
 */
 minApprovals: z.number().int().min(1).optional()
 .describe('Approvals required — total (quorum) or per group (per_group). Default 1'),
 .describe(
 'Approvals required — total (quorum) or per group (per_group). '
 + 'Omitted ⇒ all resolvable approvers for quorum, 1 per group for per_group',
 ),

 /** Lock the triggering record from edits while this node is pending. */
 lockRecord: z.boolean().default(true).describe('Lock the record from editing while pending'),
Expand Down
Loading