fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-trump merged 7 commits into from
Sep 2, 2026
+585 −0
Merged

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body #14544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad0eca2
test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…
claude Sep 2, 2026
583879d
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…
claude Sep 2, 2026
da77b96
Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…
claude Sep 2, 2026
0511bab
test(rest): type the raw-error filter in the parity pins so tsconfig.…
claude Sep 2, 2026
6d08082
Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…
claude Sep 2, 2026
3fbbe68
fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…
claude Sep 2, 2026
cdca42f
Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…
claude Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rest-duplicate-record-arm-field-restored.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.
78 changes: 78 additions & 0 deletions packages/rest/src/error-response.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
},
};
}
// [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
// with the structured `field` restored.
//
// Since #14095 `engine.insert` answers a driver's unique violation with the
// `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
// 409`, `object`, `field` when the dialect determinably named a column,
// the driver error whole on `cause`. It DECLARES a status, so it reached
// the declared-status passthrough below first and left through it: status
// right, `field` gone, and the platform's own sentence in `error`, while
// the `isUniqueViolationError` arm further down — holding the curated
// end-user wording and the `field` key since #7821 — was never reached
// for an insert conflict any more. Surfaced FIRST, beside the two
// structured 409s above, for the same reason they are: the structured
// field must survive the generic catch-alls.
//
// **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
// 2026-09-02: the answer that changes nothing for clients — every consumer
// branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
// a wire code under existing consumers is a published-contract change,
// not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
// is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
// (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
// with ADR-0112's "presence means demotion" amendment define the field as
// the demoted spelling of an UNREGISTERED code — absent when the
// producer's code IS a vocabulary member. So the field stays ABSENT here
// (contract review on the card, 2026-09-02), and the engine's spelling
// stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
// `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
// below. ADR-0112's 2026-08-29 scope correction declares the hand-written
// `declaredCode` emission population to be exactly one site; this arm is
// not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
// codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
//
// **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
// curated end-user sentence the #6250/#7821 arm has always produced: fixed
// text plus, at most, the bare column identifier the ENGINE resolved
// through `uniqueViolationColumn` (`field` is read off the envelope, not
// re-derived — the envelope is the contract). `developerMessage` is the
// engine's own sentence (`message`): it names the object and the column
// and carries no value. The envelope's own `developerMessage` is
// deliberately NOT relayed — it addresses the in-process caller of
// `engine.insert` ("attached as `cause`", "branch on `code ===
// 'DUPLICATE_RECORD'`"), and neither holds on this wire.
//
// **The body echoes nothing the driver said.** `cause` never reaches the
// wire and the sentence is fixed text. This matters most for
// `driver-memory`, whose raw refusal declares `status: 409` itself and so
// ALREADY took the passthrough before #14095 — with a message quoting the
// offending values as JSON. The envelope removed that; this arm keeps it
// removed.
//
// ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
// two siblings above are, and the difference is load-bearing: they relay
// `error.message`, this arm REPLACES it. A hook that deliberately throws
// the registered `DUPLICATE_RECORD` from a sandbox body is a different
// producer speaking a member of the vocabulary; it keeps the answer the
// sandbox unwrap door gives it today (its own sentence, its own code —
// `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
// sentence swapped for this one and the QuickJS debug wrapper shipped as
// `developerMessage`.
if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
return {
status: 409,
body: {
error: field
? `A record with this ${field} already exists`
: 'A record with this value already exists',
code: 'UNIQUE_VIOLATION',
...(typeof error?.message === 'string' && error.message.length > 0
? { developerMessage: error.message }
: {}),
...(field ? { field } : {}),
...(refused ? { object: refused } : {}),
},
};
}
// A declared datasource that is refused by the host policy, or failed to
// connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
// Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body#14544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-trump
merged 7 commits into

from

Sep 2, 2026

+585

−0

 Merged


fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envelope with the structured 409 UNIQUE_VIOLATION body
#14544
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
ad0eca2

test(rest): pin the 409 body for the engine's DUPLICATE_RECORD insert…


claude Sep 2, 2026
583879d

fix(rest): answer the engine's DUPLICATE_RECORD insert-conflict envel…


claude Sep 2, 2026
da77b96

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
0511bab

test(rest): type the raw-error filter in the parity pins so tsconfig.…


claude Sep 2, 2026
6d08082

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026
3fbbe68

fix(rest): drop declaredCode from the DUPLICATE_RECORD arm's 409 body…


claude Sep 2, 2026
cdca42f

Merge remote-tracking branch 'origin/main' into claude/issue-14389-re…


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.changeset/rest-duplicate-record-arm-field-restored.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@objectstack/rest': patch
---

Restore the `field` key and the curated conflict sentence on the 409 body for an insert refused by a unique constraint

Since the ObjectQL engine began answering a driver's unique violation with its own `DUPLICATE_RECORD` envelope (`status: 409`, `object`, `field`, the driver error on `cause`), `POST /api/v1/data/:object` let that envelope leave `classifyDataError` through the generic declared-status passthrough: still 409, but with `code: 'DUPLICATE_RECORD'`, no `field`, and the engine's own sentence in `error`. The `isUniqueViolationError` arm that names the conflicting column (`field: 'email'`, "A record with this email already exists") was no longer reached for an insert conflict. Measured with the real engine and real drivers: on `driver-sqlite-wasm` the `field` key disappeared from every conflict on a single-column index; on `driver-memory` the sentence changed.

A dedicated arm for the engine's envelope now sits with the other structured 409s (`DELETE_RESTRICTED`, `CONCURRENT_UPDATE`), ahead of the passthrough:

- `code` stays `UNIQUE_VIOLATION` — the code every client branching on this conflict already reads.
- `field` is restored whenever the dialect determinably named the column (SQLite, Postgres); composite keys and index-naming dialects (MySQL) carry no `field` key, exactly as before.
- `error` is the curated end-user sentence again; the engine's own sentence rides on `developerMessage`, the same split the `DELETE_RESTRICTED` body uses.
- The body still quotes nothing the driver said — no offending value, no statement, no index name — including on `driver-memory`, whose raw refusal used to echo the offending values as JSON through the passthrough.

`patch`: a restoration of the shipped body's keys and wording; the wire `code` and the status are unchanged. The arm fires for the engine's envelope only; a plugin or sandbox body that throws the registered `DUPLICATE_RECORD` itself keeps the answer it gets today.

78 changes: 78 additions & 0 deletions
packages/rest/src/error-response.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -698,6 +698,84 @@ function classifyDataError(error: any, object?: string): { status: number; body:
 },
 };
 }
 // [#14389] The engine's insert-conflict envelope → 409 `UNIQUE_VIOLATION`,
 // with the structured `field` restored.
 //
 // Since #14095 `engine.insert` answers a driver's unique violation with the
 // `DuplicateRecordError` envelope — `code: 'DUPLICATE_RECORD'`, `status:
 // 409`, `object`, `field` when the dialect determinably named a column,
 // the driver error whole on `cause`. It DECLARES a status, so it reached
 // the declared-status passthrough below first and left through it: status
 // right, `field` gone, and the platform's own sentence in `error`, while
 // the `isUniqueViolationError` arm further down — holding the curated
 // end-user wording and the `field` key since #7821 — was never reached
 // for an insert conflict any more. Surfaced FIRST, beside the two
 // structured 409s above, for the same reason they are: the structured
 // field must survive the generic catch-alls.
 //
 // **The wire `code` stays `UNIQUE_VIOLATION`** (triage ruling on the card,
 // 2026-09-02: the answer that changes nothing for clients — every consumer
 // branching on this conflict today reads `UNIQUE_VIOLATION`, and renaming
 // a wire code under existing consumers is a published-contract change,
 // not a door's call). **No `declaredCode` beside it.** `DUPLICATE_RECORD`
 // is a `StandardErrorCode` member, and `ApiErrorSchema.declaredCode`
 // (`packages/spec/src/api/contract.zod.ts`, with its docblock) together
 // with ADR-0112's "presence means demotion" amendment define the field as
 // the demoted spelling of an UNREGISTERED code — absent when the
 // producer's code IS a vocabulary member. So the field stays ABSENT here
 // (contract review on the card, 2026-09-02), and the engine's spelling
 // stays in-process exactly as every dialect code (`SQLITE_CONSTRAINT_UNIQUE`,
 // `23505`, `ER_DUP_ENTRY`) always has at the `isUniqueViolationError` arm
 // below. ADR-0112's 2026-08-29 scope correction declares the hand-written
 // `declaredCode` emission population to be exactly one site; this arm is
 // not a second. Pinned in `rest-duplicate-record-arm.test.ts`: §0 (both
 // codes parse as `ErrorCode` — the reason) and §1 (`not.toHaveProperty`).
 //
 // **Two sentences — the `DELETE_RESTRICTED` split above.** `error` is the
 // curated end-user sentence the #6250/#7821 arm has always produced: fixed
 // text plus, at most, the bare column identifier the ENGINE resolved
 // through `uniqueViolationColumn` (`field` is read off the envelope, not
 // re-derived — the envelope is the contract). `developerMessage` is the
 // engine's own sentence (`message`): it names the object and the column
 // and carries no value. The envelope's own `developerMessage` is
 // deliberately NOT relayed — it addresses the in-process caller of
 // `engine.insert` ("attached as `cause`", "branch on `code ===
 // 'DUPLICATE_RECORD'`"), and neither holds on this wire.
 //
 // **The body echoes nothing the driver said.** `cause` never reaches the
 // wire and the sentence is fixed text. This matters most for
 // `driver-memory`, whose raw refusal declares `status: 409` itself and so
 // ALREADY took the passthrough before #14095 — with a message quoting the
 // offending values as JSON. The envelope removed that; this arm keeps it
 // removed.
 //
 // ⚠️ Gated on the ENVELOPE — name AND code — not on the code alone as the
 // two siblings above are, and the difference is load-bearing: they relay
 // `error.message`, this arm REPLACES it. A hook that deliberately throws
 // the registered `DUPLICATE_RECORD` from a sandbox body is a different
 // producer speaking a member of the vocabulary; it keeps the answer the
 // sandbox unwrap door gives it today (its own sentence, its own code —
 // `rest-thrown-code-vocabulary.test.ts` §2) rather than having its
 // sentence swapped for this one and the QuickJS debug wrapper shipped as
 // `developerMessage`.
 if (error?.code === 'DUPLICATE_RECORD' && error?.name === 'DuplicateRecordError') {
 const field = typeof error?.field === 'string' && error.field.length > 0 ? error.field : undefined;
 const refused = typeof error?.object === 'string' && error.object.length > 0 ? error.object : object;
 return {
 status: 409,
 body: {
 error: field
 ? `A record with this ${field} already exists`
 : 'A record with this value already exists',
 code: 'UNIQUE_VIOLATION',
 ...(typeof error?.message === 'string' && error.message.length > 0
 ? { developerMessage: error.message }
 : {}),
 ...(field ? { field } : {}),
 ...(refused ? { object: refused } : {}),
 },
 };
 }
 // A declared datasource that is refused by the host policy, or failed to
 // connect under OS_ALLOW_DRIVER_CONNECT_FAILURE → 503 (framework#3828).
 // Handled before the catch-alls because nothing about the REQUEST is wrong:
Expand Down
Loading
Loading