test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(spec): discover the migrate-sentence markdown corpus instead of naming one file - #14557

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus
Sep 2, 2026
Merged

test(spec): discover the migrate-sentence markdown corpus instead of naming one file#14557
os-sam merged 1 commit into
mainfrom
claude/issue-13859-migrate-sentence-corpus

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#13859

What was wrong

packages/spec/src/shared/retired-key-migrate-sentence.test.ts pinned the house tombstone sentence over two source corpora and a markdown corpus of exactly one hard-coded file — the internal retirement playbook (RETIREMENT_SKILL_MD).

The regex was never the defect; the population was. WITHDRAWN_CLAIM matches the withdrawn "rewrite it automatically" claim verbatim, and that claim nevertheless reached skills/objectstack-upgrade/SKILL.md — published, customer-facing — with nothing scanning it. It was corrected by hand in #13861 (commit 88c30af, one line: rewrite it automatically. becomes list the mechanical edits for existing sources; apply them by hand.). Nothing mechanical found it, and until this PR nothing stopped it coming back.

What this changes

One test file. The markdown corpus is discovered, not named: the internal retirement playbook plus every .md file under skills/. Discovery is

  • deterministicreaddirSync(...).sort() at every level, so the corpus order and every failure message read the same on every machine and every run;
  • symlink-safelstatSyncskips a symlink instead of following one out of the repo (or back in, judging a file twice);
  • non-vacuous, and asserted to be — the corpus must be non-empty, must contain the playbook, and must contain at least one published skill. A walk that silently reached zero published files would restore exactly the one-file blindness this card is about, while every other assertion in the suite stayed green.

The three existing markdown assertions keep their intent:

assertionpopulation after this PR
every prescription sentence is house-form or MIXED two-clausethe whole discovered corpus
anti-vacuity: BOTH shapes are taught, so at least two sites are judgedthe playbook only
[#9529] the withdrawn automatic-rewrite claim is absent, in every spellingthe whole discovered corpus

The BOTH-shapes floor stays pinned to the one file that owns both templates, deliberately: a published skill that names the command once is not a regression, so widening that floor would fail on the catalog's editorial choices rather than on drift.

SKILL_MARKER keeps its leading-Run requirement — naming the command mid-prose is not prescribing a sentence, and the published upgrade skill names it a dozen times without prescribing anything. WITHDRAWN_CLAIM stays English-only by design, so Chinese prose anywhere in the wider corpus cannot fabricate a match.

The one thing the widening needed that the card could not predict

A naive widening does not land green, and the file that reds it is the very file this card is about.

The old anchors required a judged sentence to end at a double-backtick code-span close. That is how the playbook writes its two taught templates, so on a one-file corpus it read as "the sentence must be last in its container". On a wider corpus it means something else: any occurrence that is not inside a code span is an unconditional RED, because nothing but a code span can supply the terminator. That is not a property — it is a trap that fires the moment the corpus stops being one file.

Measured on origin/main at 4a37870, with the pin's own regexes over the widened corpus: 3 markers, 1 violationskills/objectstack-upgrade/SKILL.md, quoting the corrected house sentence verbatim inside a rendered parse-error transcript whose next line is expected: never. The span-only anchor would have red-flagged the text #13861 had just fixed.

So "container" is now two things, and the judge asks which one it is looking at:

  • a taught template — the marker opens a double-backtick code span — must close that span, so prose still cannot bury the command mid-span;
  • a sentence quoted in prose or a transcript has no span to close, and is judged on its wording, ending at its own period.

What that gives up, deliberately and only in prose: burying (... apply them by hand. Also do X.) passes there. It stays RED inside a template and RED in every .ts prescription — the two places from which a reader actually copies text.

skills/** is read by the widened corpus and never written by this PR: the diff is one test file, and the corpus found no other violation to report.

Verification

Union re-run after the final commit, at db374e225.

  • The changed pin, pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/shared/retired-key-migrate-sentence.test.tsTest Files 1 passed (1) / Tests 14 passed (14).

  • Whole @objectstack/spec suiteTest Files 451 passed (451) / Tests 12190 passed (12190). Not sharded.

  • pnpm --filter @objectstack/spec build && ... typecheckcheck:test-typecheck: OK ... 54 file(s) / 262 error(s) / 146 pinned signature(s), the ledgered counts unchanged. The edited file is genuinely in that program, not merely adjacent to it: tsc -p tsconfig.test.json --listFiles lists it (1 hit), and none of the 262 ledgered errors names it.

  • Reverse verification (the widening is real, not declarative). The exact withdrawn sentence was appended to skills/objectstack-upgrade/SKILL.md in the worktree, after the implementation was committed. Mutation proven on disk before the run — occurrence count 0 then 1, blob 16b7a39e then 87b24b72. The pin went RED, 2 failed / 12 passed, both failures naming the file:

    • every prescription sentence in the markdown corpus is house-form or MIXED two-clauseAssertionError: skills:objectstack-upgrade/SKILL.md [prose] — "Run ... to rewrite it automatically."
    • [#9529] the withdrawn automatic-rewrite claim is absent from the corpus, in every spelling — same file.

    Restored with git checkout HEAD -- (absolute path) under an EXIT INT TERM trap on absolute paths, and proven restored by bytes rather than by an exit code: blob back to 16b7a39e (equal to the HEAD blob, non-empty), occurrence count back to 0, git diff HEAD empty, git status --porcelain empty. The mutation was never committed or pushed. On origin/main neither assertion could have seen that file at all.

  • Gate family, derived mechanically with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at db374e225 (1 path vs merge base 4a37870): 47 commands. 44 measured green — each exit code captured to a file before any pipe. Among them check:cross-package-test-inputs (the widened read of skills/ is already inside this package's declared globs, and turbo.json already hashes them), check:test-source-alias, check:type-check-coverage, check:published-files, and every @objectstack/spec check:* in the family. Plus pnpm check:nul-bytesOK (scanned 7938 text file(s) ... no raw ASCII control bytes).

  • 3 gates NOT MEASURED, all prerequisite-not-met on an unbuilt workspace, none a finding: check-dev-prereqs (The workspace is not built — 1 unmet precondition), check:doc-formula-expressions (exit 3, needs @objectstack/formula dist), check:dual-build-cjs-loads (exit 3, PREREQUISITE NOT MET — this gate reads built output), check:type-check-debt (exit 3, PREREQUISITE NOT MET), and check-test-completeness (exit 3, whose own text says to record it as NOT MEASURED when run without a turbo run test log). CI builds the workspace and measures all of them.

  • Declared narrowing: the repo-wide pnpm lint sweep was not run locally. It is CI-owned and CI runs it on this PR regardless.

Changeset

None. This is a test-only change — one *.test.ts file, publishing nothing from any package — so it carries the repo's documented test-only handling, the skip-changeset label, rather than a fabricated release note.

Draft on purpose: the PM seat reviews and lands. Not marked ready, no auto-merge.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…naming one file
The retired-key migrate-sentence pin scanned exactly one markdown file
(`.claude/skills/spec-property-retirement/SKILL.md`), so the withdrawn
"rewrite it automatically" claim could reach the published skill catalog —
the artifacts a customer agent actually loads — with nothing scanning it.
The markdown corpus is now DISCOVERED: the internal retirement playbook plus
every `.md` file under `skills/`. Discovery is sorted (stable failure
messages), skips symlinks rather than following one out of the repo, and is
itself asserted non-vacuous — it must contain the playbook and at least one
published skill, so a walk that silently reached zero published files cannot
read green.
The two-shape judge keeps its leading-`Run` requirement (naming the command
mid-prose is not a prescription) and gains the distinction the wider
population needs: a taught TEMPLATE is a double-backtick code span and must
close it, while a sentence quoted in prose or a rendered transcript ends at
its own period. Under a span-only anchor every quoted occurrence is an
unconditional RED — the published upgrade skill quotes the house sentence
verbatim inside an example parse error — which is a trap, not a property.
Burying stays RED inside a template and in every `.ts` prescription.
The BOTH-shapes anti-vacuity floor stays pinned to the playbook, the one file
that owns both templates; a published skill that names the command once is
not a regression.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
@claudeclaudeBot added needs:contract-review skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 53d368921b06abdc76502234ceb31733ad9d3ab1packageMentionDocs.

@os-sam
os-sam marked this pull request as ready for review September 2, 2026 14:37
@os-sam
os-sam enabled auto-merge September 2, 2026 14:38
@os-sam
os-sam added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 2514d49Sep 2, 2026
47 checks passed
@os-sam
os-sam deleted the claude/issue-13859-migrate-sentence-corpus branch September 2, 2026 15:07
baozhoutao pushed a commit that referenced this pull request Sep 3, 2026
`scripts/cross-package-test-inputs.mjs`'s `@objectstack/spec` declaration
block carried two comments PR #14557 made stale:
- the `.claude/skills/spec-property-retirement/SKILL.md` entry said the
retirement pin (`retired-key-migrate-sentence.test.ts`) judges "the ONE
governed markdown file" — after #14557 the pin judges that file PLUS
every `skills/**/*.md`. "One file, not `.claude/**`" was still literally
true about the `.claude` entry while reading as an exhaustive scope claim
about the test's population, so the sentence needed re-aiming, not a
bumped count: it now names the two-corpus structure and points at the
`skills/**` entry below for the second corpus.
- the `skills/**` entry named `scripts/export-list.test.ts` as its only
holder. `retired-key-migrate-sentence.test.ts` reads the same root
(`PUBLISHED_SKILLS_ROOT`, `:102`) as its second corpus — "plus every
`.md` file under `skills/`" (`:92`), emitted as `skills:`-prefixed
entries (`:484-485`). The comment now names both holders.
Comments only: every glob is unchanged, `check:cross-package-test-inputs`
was already green on #14557's head, and it stays green here.
Fixes#14560
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The retired-key migrate-sentence pin scans ONE markdown file, so the withdrawn "rewrite it automatically" claim reached the published catalog unseen

2 participants

@os-sam@claude