docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces - #14690

Merged
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded
Sep 2, 2026
Merged

docs(objectql): record the deliberate lock-face/static-face asymmetry, and pin both faces#14690
os-musk merged 2 commits into
mainfrom
claude/issue-14259-lock-face-asymmetry-recorded

Conversation

@os-musk

Copy link
Copy Markdown
Collaborator

Fixes#14259

Seam 1 residual only. Seam 2 landed as 00ff228fe (PR #14472) with a Part of line; the card was held open for this half.

No behaviour moves. Every changed line in packages/objectql/src/validation/rule-validator.ts is a comment line, mechanically verified — the diff of that file with comment lines filtered out is empty. The other two files are tests. This is an S card: it writes down a rule that already holds.

What the maintainer ruled (decision batch #12 item 4, #14259 comment 5511947941)

B. Seam 1 (isCallerSuppliedValue, behind stripReadonlyWhenFields / stripReadonlyWhenFieldsMulti) stays on value equality. On a readonlyWhen state lock, a before-phase hook assignment that writes back the value already on the key — data.x = data.x, or a normalisation that is the identity for canonical input — does not count as a hook write: the caller's value is stripped, with the existing warning and the same onFieldsDropped / strictReadonlyWrites reporting. LOCK 3b stands as the pin of that rule. The divergence from the provenance-based static face is recorded as a deliberate, lock-motivated asymmetry, and each face carries a measurement pin. The residual (a hook deriving a locked field while the caller echoed the identical value loses its write) is accepted; no instance exists in the tree.

The three things this PR is

1. The docblock correction

The false sentence, quoted verbatim from origin/main before this PR:

Shared by the single-id and bulk strips so the two can never disagree about what "caller-supplied" means, and written to be textually parallel with the same test inside stripReadonlyFields.

...and, four paragraphs up in the ReadonlyWhenStripOptions docblock the above @links to, the same claim stated more strongly:

a key is judged only when it is still the caller's — the identical two-part test stripReadonlyFields applies

Both were true when written and neither has held since #14088 moved stripReadonlyFields onto a record of the keys the before-phase hook chain assigned (options.hookWrittenKeys), asked ahead of the value comparison. Both are corrected in place to state the asymmetry and its reason, which is what each face guards:

The second correction is inside the same isCallerSuppliedValue region and is the same claim; leaving it would have left the docblock still asserting the falsehood this card exists to retire.

2. The two face pins, written to be read side by side

Why a new pin rather than a reference to an existing one. The card asked me to check whether engine-hook-provenance-sibling-seams.test.ts already carries this. It carries a case with that exact name — but that suite is seam 2 — the insert-side runtime-owned strip reads PROVENANCE, its subject is engine.insert on an autonumber column, and it pins stripRuntimeOwnedFields. That is a different face from the update-side static readonly seam stripReadonlyFields the ruling names. Verified: nothing in engine-readonly-strip-caller-values.test.ts covered the self-assignment input, and hook-write-provenance.test.ts unit-tests the recorder rather than a strip face. So the update-side static face genuinely had no pin, and now has one.

Both new comment blocks state that a future ruling reversing this inverts the pins rather than deleting them.

3. One patch changeset

.changeset/lock-face-value-equality-recorded.md. isCallerSuppliedValue and ReadonlyWhenStripOptions are both package-internal and unexported, so neither docblock reaches dist/*.d.ts; the changeset is a plain patch, no ADR-0087 marker owed (not breaking).

Verification — all on the final merged head da2dc1967

  • pnpm --filter @objectstack/objectql test263 files / 4553 tests passed.
  • pnpm --filter @objectstack/objectql typecheck — green; verdict line check:test-typecheck: OK — @objectstack/objectql's test layer compiles under packages/objectql/tsconfig.test.json. The test layer is compiled by a sibling tsconfig.test.json, so the two edited test files really are type-checked.
  • pnpm lint — full repo, eslint . --no-inline-config, exit 0. No narrowing claimed.
  • Gate family re-derived on the final tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (identical before and after the origin/main merge, 38 commands). 34 green. Four exit 3, each printing its own PREREQUISITE NOT MET / NOT MEASURED verdict rather than a finding, all needing a full workspace build or a saved turbo run test log this container cannot produce: check-test-completeness, check:dual-build-cjs-loads, check:type-check-debt, check-half-states. Recorded as NOT MEASURED, not as green and not as red. Exit codes were captured by redirecting to a file first, never through a pipe.

Reverse verification of the new pin

Committed first, then mutated, with an absolute-path trap restore. The pin's hook was retargeted from completed_at to title so no hook write is recorded for the locked key. Mutation proved on disk before running (target occurrences 1 to 0, injected 1, blob 986d3b0a to eb33cb5e). Predicted direction RED; observed RED:

AssertionError: expected '2026-08-01T09:00:00.000Z' to be '1999-01-01T00:00:00.000Z'

That is the stored STAMPED timestamp surviving — the strip taking the caller's forged value away once the self-assignment stops being recorded. The pin measures the provenance seam rather than restating a tautology. Restore proved byte-exact afterwards: blob back to 986d3b0a, git diff HEAD empty, git status --porcelain empty.

Scope

packages/objectql/src/engine.ts was not touched — it is held in flight by another dispatch (#14399). origin/main was merged immediately before opening this PR; #14311's checkStateMachine change landed around line 2180 of the same file, a different region, and merged cleanly. The full objectql suite and the gate family were re-run afterwards, on the merged head.

One stale-prose finding in engine-hook-provenance-sibling-seams.test.ts is filed separately rather than fixed here; it is named in the report comment on #14259.

🤖 Generated with Claude Code

Generated by Claude Code


Generated by Claude Code

…th faces
`isCallerSuppliedValue`'s docblock claimed the readonlyWhen seam runs "the
identical two-part test `stripReadonlyFields` applies" and is "textually
parallel" with it. Neither has held since #14088 moved the static face onto a
hook-write record and #14472 did the same to the insert-side twin. The
divergence is deliberate and lock-motivated, so it is now stated where the test
lives, with the reason each face guards a different thing.
Adds the static face's missing measurement pin (a lone self-assigning hook
leaves the CALLER value on the key) beside #14088's own suite, and cross-links
it with `LOCK 3b`, which pins the opposite verdict for the identical hook
spelling. Comment- and test-only; no behaviour moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/objectql/src/validation/rule-validator.ts) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a3d5724c8857d8e31721feceadd1a62e04934674packageMentionDocs.

@os-muskClaude

Copy link
Copy Markdown
CollaboratorAuthor

Landing provenance (engine execution seat, session session_0112hMx9hjJ9BgB28X97DS68): flipped ready at 19:23Z and armed auto-merge (squash) at 19:23:52Z on head da2dc1967. The echo read method: MERGE; the queue build ref is the arming reading, not the echo.

  • Review: ACCEPT on the card, comment 5514606510. Clause-② no — the ruling itself says so: no accept set moves, the behaviour written down is today's behaviour. In-seat review is in order; the CONTRACT_REVIEW_TIER requirement binds Clause-② yes cards, and this seat is currently off tier (claude-opus-5 served against claude-fable-5-1 required).
  • Governed-surface test re-run on the final four-path file list: 0 of 4 path(s) hit the register — ordinary queue landing. Re-derived rather than recalled.
  • Enqueue bar: all 33 check runs on da2dc1967 completed success or skipped, read with perPage: 50. Last standing was Test Core (1/6) (18:38:37Z → 19:02:15Z, 24 min — the long shard's usual band) and the Test Core rollup behind it at 19:02:32Z. The full page was re-read before calling it green rather than inferring the total from the one job that had been outstanding.
  • Verified by this seat against the tree rather than the report: rule-validator.ts is comment-only (added lines filtered against ^\+\s*(\*|//) leave an empty set); packages/objectql/src/engine.ts is absent from the diff, so the serial slot held by The two SOURCE view-container registrars disagree on where the row's own name sits in the object-derivation chain #14399 was respected; LOCK 3b stands at engine-readonly-when-derived-writes.test.ts:219.

⭐ The substantive correction this PR carries is to the ruling's own parenthetical. Ruling B said the static face was "already pinned"; measured, the existing MEASURED: case sits in describe('seam 2 — the insert-side runtime-owned strip reads PROVENANCE') and pins stripRuntimeOwnedFields on engine.insert, which is a different face from the update-side static stripReadonlyFields the ruling names. The card therefore shipped two pins, not one. The dispatch carried that parenthetical as a Zone 2 item to verify rather than as a fact — the only reason it was caught.

⚠️ Known exposure: the queue build runs the full suite, so this PR meets packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts — the flake tracked on #14648, which ejected #14629 at 17:45Z. If ejected, the disposition is fixed: ⛔ no re-queue while #14648 is open, ⛔ no weakening of that test, and the card goes to pm:blocked with an Unlock-action: line rather than being re-dispatched.

Owed by the seat at MERGED: verify by content on origin/main that both docblock corrections landed and both face pins are present, then — because this is Fixes #14259 and closes the card — strip everypm:* label in the same stroke, post the landing record, and reconcile inventory. Seam 1 and seam 2 are both delivered at that point.


Generated by Claude Code

@os-musk
os-musk added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit a8fac3aSep 2, 2026
35 checks passed
@os-musk
os-musk deleted the claude/issue-14259-lock-face-asymmetry-recorded branch September 2, 2026 20:52
os-musk pushed a commit that referenced this pull request Sep 2, 2026
…14693)
Three passages in `engine-hook-provenance-sibling-seams.test.ts` still said the
`readonlyWhen` sibling seam was "WITHHELD pending a maintainer ruling" and went
"to the decision inbox, never resolved here". It was ruled — #14259, maintainer
ruling B: that seam keeps value equality and the asymmetry is deliberate — and
#14690 landed the corrected `isCallerSuppliedValue` docblock plus a pin on each
face. A landed PR now routes readers straight into the sentence that
contradicts the ruling.
Comment-only: every assertion, test name and fixture is untouched. The prose is
replaced with a pointer to where the argument now lives rather than a fourth
copy of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112hMx9hjJ9BgB28X97DS68
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

2 participants

@os-musk@claude