feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 4 commits into from
Sep 2, 2026
+540 −67
Merged

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down) #14714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0306841
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…
claude Sep 2, 2026
f394666
chore(spec): regenerate reference docs, authorable surface and livene…
claude Sep 2, 2026
f83dd78
Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…
claude Sep 2, 2026
1efaac7
chore(spec): regenerate liveness counts on the merged tree (#14192)
claude Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .changeset/manifest-unknown-keys-refused.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.
6 changes: 4 additions & 2 deletions content/docs/protocol/kernel/plugin-spec.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down
3 changes: 3 additions & 0 deletions content/docs/references/api/package-api.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
1 change: 1 addition & 0 deletions content/docs/references/api/protocol.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
1 change: 1 addition & 0 deletions content/docs/references/kernel/manifest.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down
2 changes: 2 additions & 0 deletions content/docs/references/kernel/package-registry.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down
2 changes: 2 additions & 0 deletions content/docs/references/kernel/package-upgrade.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)#14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Sep 2, 2026

+540

−67

 Merged


feat(spec): refuse unknown keys inside manifest: — ManifestSchema goes strict (the #8687 door one level down)
#14714
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
0306841

feat(spec): refuse unknown keys inside manifest: — ManifestSchema goe…


claude Sep 2, 2026
f394666

chore(spec): regenerate reference docs, authorable surface and livene…


claude Sep 2, 2026
f83dd78

Merge remote-tracking branch 'origin/main' into claude/issue-14192-ma…


claude Sep 2, 2026
1efaac7

chore(spec): regenerate liveness counts on the merged tree (#14192)


claude Sep 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


40 changes: 40 additions & 0 deletions
.changeset/manifest-unknown-keys-refused.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
---
"@objectstack/spec": minor
---

feat(spec): refuse unknown keys inside `manifest:` — `ManifestSchema` goes strict, with its nested `contributes` / `kinds[]` / `engine` / `engines` blocks

**BREAKING** accept-set narrowing on a published spec schema, landing after the
v17.0.0 cut (the lockstep launch-window convention ships it as `minor`).

<!-- adr-0087: not-required (no-migration-prescription) this change retires NO key. The manifest vocabulary is byte-identical except for one ADDITIVE declaration (`main`, a key the `os plugin build` door already honoured), and only the unknown-key POSTURE moves, from strip to reject. Nothing exists for `objectstack migrate meta` to rewrite: an undeclared key was never honoured — it was dropped at parse and so never reached storage, the registry or any reader — so no stored shape carries one and no authored shape that ever WORKED becomes invalid. There is no single rewrite rule a ledger entry could state either, since what is now refused is an open set of author typos rather than a renamed key. The upgrade channel is the schema rejection itself, which names the offending key at the author's own path and carries either the declared spelling or the wrong-layer pointer (`specVersion`). The retired manifest keys keep their existing ledger entries (`kernel/Manifest:loading`, `kernel/Manifest:capabilities`, `kernel/Manifest:configuration`, `kernel/Manifest:extensions`, the `kernel/Manifest:contributes.*` family) and their tombstones. Measured blast radius before the close: 0 undeclared keys across the four example apps, the three `os init` templates, the `create-objectstack` blank template and every other shipped `manifest:` block; the one undeclared key found at a real door (`main`, on `objectstack.plugin.json`) is declared by this change rather than refused. -->

The package manifest — the `manifest:` block of every `objectstack.config.ts`, the
`objectstack.plugin.json` that `os plugin build` reads, the Studio package form —
was a plain open object: an unknown key inside it parsed green and its value was
silently dropped, at every door. A transposed `namesapce` therefore left
`manifest.namespace` undefined with exit 0, and that key decides every object's
table name, REST path and the install-time namespace gate — objects landed under a
name the author never wrote. The same silent drop held one level down: `kind:` for
`kinds:` inside `contributes`, `protocl:` for `protocol:` inside `engines`, which
quietly switched the load-time protocol handshake off.

**What is refused:** any key `ManifestSchema` does not declare — at the manifest
root and inside `contributes`, `contributes.kinds[]`, `engine` and `engines` — with
a message naming the surface and the offending key. A near miss carries the declared
spelling (`namesapce` is answered with `namespace`, `protocl` with `protocol`).
`specVersion` is answered with a wrong-layer pointer: the protocol axis the runtime
checks is `engines.protocol`. The retired keys (`loading`, `capabilities`,
`configuration`, `extensions`, the retired `contributes` members, `kinds[].globs`)
keep answering with their upgrade prescriptions, and a typo is never pointed at one
of them. The refusal reaches every door: `defineStack` / `os validate` /
`os compile`, `devPlugins`, the artifact `packages[]` entry (the assembled body
inherits it), `os plugin build`, and the package request shapes that embed the
manifest.

**What stays accepted:** every declared key, byte-identically — the four example
apps, every `os init` template and every shipped `manifest:` block parse unchanged.
**Newly declared:** `main` (optional), the entry module of a code-bearing plugin.
`os plugin build` has always read it off the source manifest and written it into
the compiled one as `dist/index.mjs`; it is declared now because a closed surface
that did not declare it would have refused every plugin that names its entry.

6 changes: 4 additions & 2 deletions
content/docs/protocol/kernel/plugin-spec.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,10 +168,12 @@ export default definePlugin({
required; the optional fields are `namespace`, `defaultDatasource`, `scope`,
`description`, `permissions`, `objects`, `datasources`, `dependencies`,
`contributes`, `data`, `navigationContributions`, `engine`, `engines`, `runtime`,
`packaging` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`packaging`, `main` and `integrity`. The `configuration`, `capabilities`, `extensions` and
`loading` keys are **retired tombstones** (ADR-0049 enforce-or-remove): nothing ever
read any of them, so authoring one is now a compile error and a parse error carrying
the migration prescription.
the migration prescription. Any other key is refused at parse — the schema is closed
against unknown keys, at the manifest root and inside `contributes`, `engine` and
`engines` — with a message naming the key and, for a near miss, the declared spelling.

The `displayName` / `author` / `license` / `homepage` / `optionalDependencies` /
`peerDependencies` / `metadata` / `config` / `marketplace` keys above are
Expand Down

3 changes: 3 additions & 0 deletions
content/docs/references/api/package-api.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -210,6 +210,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `PackageInstallRequest.artifactRef`
Expand DownExpand Up@@ -332,6 +333,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -416,6 +418,7 @@ Resolve dependencies request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/api/protocol.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1893,6 +1893,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down

1 change: 1 addition & 0 deletions
content/docs/references/kernel/manifest.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ const result = ManifestSchema.parse(data);
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `Manifest.permissions`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-registry.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -214,6 +214,7 @@ Install package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -309,6 +310,7 @@ Installed package with runtime lifecycle state
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |

### Nested Shape: `InstalledPackage.upgradeHistory[number]`
Expand Down

2 changes: 2 additions & 0 deletions
content/docs/references/kernel/package-upgrade.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -163,6 +163,7 @@ Upgrade package request
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand DownExpand Up@@ -305,6 +306,7 @@ Pre-upgrade state snapshot for rollback capability
| **engines** | `{ platform?: string; protocol?: string }` | optional | Plugin compatibility ranges (ADR-0025 §3.2; supersedes `engine`) |
| **runtime** | `Enum<'node' \| 'sandbox' \| 'worker'>` | optional | Plugin trust tier the plugin declares (ADR-0025 §3.6) — enforced at the cloud marketplace publish gate (unverified publisher requesting `node` → HTTP 422 + manual review); load-side enforcement is NOT implemented, so a locally installed plugin is not isolated by the tier it declares |
| **packaging** | `Enum<'bundled' \| 'manifest-deps'>` | optional | Dependency packaging strategy (ADR-0025 §3.3) |
| **main** | `string` | optional | Entry module of a code-bearing plugin, relative to the plugin root; `os plugin build` bundles it and writes `dist/index.mjs` here in the compiled manifest (ADR-0025 §3.4) |
| **integrity** | `Record<string, string>` | optional | Per-file content digests of the plugin artifact (ADR-0025 §3.2) |


Expand Down
Loading
Loading