test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(plugin-auth): register the production object set in the two SCIM harnesses - #14751

Merged
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects
Sep 3, 2026
Merged

test(plugin-auth): register the production object set in the two SCIM harnesses#14751
os-sales merged 2 commits into
mainfrom
claude/issue-14615-scim-harness-oauth-objects

Conversation

@os-sales

Copy link
Copy Markdown
Collaborator

Fixes#14615

Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted every
OAuth object. They now import authIdentityObjects from the plugin's own manifest
instead — the same array auth-plugin.ts registers at runtime and
objectstack.config.ts declares at compile time — so a harness cannot drift from a
real deployment by construction. Test-only diff; two files.

What actually emits the line, measured

The card attributes the ERROR to POST /sign-in/email. That is not the trigger.
The vendor's own source is unambiguous — @better-auth/oauth-provider 1.7.2,
dist/authorize-BmTe2VYG.mjs, prepareBackchannelLogoutPlan is installed as a
databaseHooks.session.delete.before hook (line 4419), not a sign-in hook. It
reads exactly two models, both keyed on sessionId:

const[accessTokens,refreshTokens]=awaitPromise.all([adapter.findMany({model: "oauthAccessToken", where }),adapter.findMany({model: "oauthRefreshToken", where }),]);constaffectedClientIds=newSet();
...
if(affectedClientIds.size===0)returnnull;// returns BEFORE reading oauthClient

So the reads that demanded a registration are sys_oauth_access_token and
sys_oauth_refresh_token, and they are demanded by session revocation, not by
sign-in. oauthClient (sys_oauth_application) is reached only when a token row was
found, which never happens in a harness whose tables are empty, and oauthConsent
(sys_oauth_consent) is not read by this seam at all. That is why the fix is not
"the four OAuth objects from the posture test": two of those four are not demanded by
any read here, and importing the production set is both narrower in intent and wider
in coverage than hand-picking either number.

Before / after — same command, quoted

pnpm --filter @objectstack/plugin-auth exec vitest run --maxWorkers=2 src/SUITE.test.ts

suitephaseback-channel logout planning failedno such table: sys_oauth*ERROR linesresult
scim-deactivation-reconcile-userbefore2610Tests 11 passed (11)
scim-deactivation-reconcile-userafter000Tests 11 passed (11)
scim-transaction-scopebefore002Tests 5 passed (5)
scim-transaction-scopeafter002Tests 5 passed (5)
credential-at-rest-posture (control, untouched)before000Tests 5 passed (5)
credential-at-rest-posture (control, untouched)after000Tests 5 passed (5)

The 2 ERROR lines that remain in scim-transaction-scope are that suite's own
deliberately injected failure ([#14522 test] injected failure on insert sys_scim_user),
unchanged in both phases. A diff of the ERROR lines before vs after found no line
present only in the after phase in either suite: registering the production set
introduced no new noise.

Whole package, on the merged tree: Test Files 91 passed (91) / Tests 1862 passed (1862),
and 0 occurrences of the line package-wide.

Two of the card's premises did not survive measurement

Reported here rather than quietly worked around.

  1. scim-transaction-scope.test.ts never emitted the line. Its before count is 0,
    not because its object list differs — it was byte-identical to the other suite's —
    but because it never deletes a session. Its sign-in in case (c) is not a trigger.
    Its gap was latent, and the change to it is prophylactic with a measured delta
    of 0 to 0. It is in this PR because it is the same harness shape in the card's
    declared surface, and it is now un-driftable rather than accidentally quiet.
  2. The control is not evidence. The card's whole basis for the remedy was that
    credential-at-rest-posture.test.ts registers the OAuth objects and does not emit
    the line. It does not emit the line, but it drives no auth request at all — no
    sign-in, no sign-out, no revocation — so its 0 is not attributable to its
    registration list. The causal evidence for this fix is the vendor source above plus
    the direct 2 to 0 measurement, not the control.

Registering from the manifest rather than from AUTH_OBJECTS

The card named the posture test's AUTH_OBJECTS as the reference. This PR follows the
triage's direction on the card instead (#14615 comment of 2026-09-02): that list is
itself a hand-copied second spelling of authIdentityObjects, and adding four names to
two more hand-lists would give the repo four copies of one truth — while the card's own
strongest observation is that this gap "already was [copied], twice". Importing the
production array is the only version that stops the next copy. AUTH_OBJECTS in the
posture test is deliberately not touched here.

Scope

  • No changeset: test-only, publishes nothing (plugin-auth's files is
    ["dist","README.md","CHANGELOG.md"]). This is pr-automation.yml's route 2,
    "tests-only ... apply the skip-changeset label", which is the label's own preferred
    case. Label applied.
  • No product source touched. auth-manager.ts is held by PR fix(plugin-auth): bind the dev-admin seed's operator-provisioning ticket to more than the seed address (#14373) #14730 and is not in this
    diff; the back-channel planner is the vendor's and was not modified. The card's second
    remedy direction — discriminating an absent table as a benign read — is not
    addressed here and remains a product decision, exactly as the triage ruled.
  • Export surface unchanged: git diff -U0 origin/main...HEAD | grep -E '^[+-].*export'
    returns nothing.

Left alone deliberately

Four more AuthManager harnesses in plugin-auth still hand-write the object list
without the OAuth objects, and are ⛔ not touched here (the population, counted:
7 harnesses construct an AuthManager and register objects — 2 now import the
manifest, 1 hand-list carries the OAuth objects, 4 hand-lists do not):

  • audience-bootstrap-seam.test.ts
  • dev-admin-seed-credential-gate.test.ts
  • sso-register-platform-admin-gate.test.ts
  • walled-owner-operator-stamp.test.ts

None of them emits the line today — the package-wide count above is 0 — because none
deletes a session. They are latent copies of the same shape, for a separate card.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8


Generated by Claude Code

… harnesses
Both SCIM harnesses re-spelled plugin-auth's object set by hand and omitted
every OAuth object, so the oauth-provider's `session.delete.before` hook —
which reads `sys_oauth_access_token` and `sys_oauth_refresh_token` by
`sessionId` on every session revocation — hit tables that were never created
and logged a Better Auth ERROR on a green run.
Import `authIdentityObjects` from the plugin's own manifest instead of
re-spelling it. That is the same array `auth-plugin.ts` registers at runtime
and `objectstack.config.ts` declares at compile time, so the harness cannot
drift from a real deployment by construction.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7a17f3bf1e48e1e88f8e833a794e37bd40230f17packageMentionDocs.

@os-sales
os-sales marked this pull request as ready for review September 2, 2026 23:50
@os-sales
os-sales added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit d2bdab2Sep 3, 2026
39 checks passed
@os-sales
os-sales deleted the claude/issue-14615-scim-harness-oauth-objects branch September 3, 2026 01:59
os-sales pushed a commit that referenced this pull request Sep 3, 2026
… in five harnesses
Five plugin-auth harnesses re-spelled the objects a deployment mounting
plugin-auth registers, instead of importing `authIdentityObjects` from
`src/manifest.ts`. Every hand list had drifted below the manifest, so each
harness booted an engine missing tables the runtime registers.
Follows the import pattern established by #14751 on the two SCIM harnesses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/mskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

2 participants

@os-sales@claude