Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
102 changes: 102 additions & 0 deletions .changeset/getmetaitems-org-read-gate.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
---
"@objectstack/metadata-protocol": patch
---

fix(metadata-protocol): `getMetaItems` applies the registry read gate itself, so a sweep that reads more than one type per request is scoped per type (#14683)

`getMetaItems` applied no organization gate of its own: whatever `organizationId`
arrived was spent on whatever `type` arrived. The scope of a metadata sweep was
therefore decided per type **by the caller** — which a request carrying one
organization can only get right when it sweeps **one** type. It now resolves
`organizationIdForMetaRead(request.type, request.organizationId)` once, after the
canonical type fold, and both the active-overlay read and the `previewDrafts`
read spend that one resolution.

Three live callers sweep more than one type and could not have been right:

- `getMetaDiagnostics` with no `type` — `targetTypes` is the whole registry, the
five `allowOrgOverride: true` types and every other declared type together,
under one request-level organization.
- `findReferencesToMeta` — `request.type` is the **target**; the organization is
spent on `matcher.fromType`, the **sources**, so the target's own registry flag
says nothing about the types actually read.
- the runtime's package export sweep (`assemblePackageManifest`) — every plural
key of `PLURAL_TO_SINGULAR`, with one raw active organization.

**The harm class is resurrection, not concealment**, and which one it is decides
that the registry-gated predicate is the right instrument.
`SysMetadataRepository.history()` filters `organization_id` by strict equality,
so naming the tenant *there* hides an `allowOrgOverride: false` type's rows. On
this path the two `queryByOrg` reads are UNIONed, so naming it can only **add** —
and what it adds are the pre-#6190 phantoms: org-scoped rows of types with no
per-org read channel, which `loadMetaFromDb` walks past and
`reportUnhydratableOrgScopedRows` exists to warn about. Read back, they surface
in the admin "Used by" panel and the Studio governance directory, inside a
clearance rendered before a destructive action — where a resurrected row is worse
than an omission because it reads as evidence.

**Why `patch`, from this change's own lineage.** A published `/meta` read door's
row set changing is not a new class here — it is the class this predicate was
born in, and all three landed instances shipped `patch`:

| commit | what changed | level |
|:--|:--|:--|
| `b6c769019` (#9454 / #9727) | the row set every `/meta` read door returns — org rows **added** | `metadata-core`, `metadata-protocol`, `rest`: all `patch` |
| `26f3588fb` (#10340 / #10519) | which partition two spellings read — rows **moved** | `rest`, `metadata-core`: `patch` |
| `67ceb9aef` (#11553) | the same fold-before-scope repair on the dispatcher door | `runtime`: `patch` |

The first of those is the commit that introduced `organizationIdForMetaRead`
itself. Adding the org partition to every read door was `patch`; moving which
partition two spellings read was `patch`; this change — withholding the org
partition from types that never had a read channel for it — is the same class,
one verb further in, and takes the same level.

⛔ Not `minor`, and in this repo that is a statement rather than a rounding
choice. `scripts/check-changeset-no-major.mjs` refuses `major` outright, so
during the launch window a genuinely breaking change ships as `minor` (pre-1.0,
whole-stack lockstep) — #13925 is exactly that, `"@objectstack/core": minor`
carrying a bolded incompatibility banner and an `adr-0087:` marker for a
narrowed published accept set. But the implication runs ONE WAY ONLY, and the
gate's own header is explicit that it does: during the window `minor` is the
union of ordinary new-functionality bumps and banner-marked breaking ones
(`87ad30c10`, `3c1bbd2a8` are new-export `minor`s carrying no banner at all),
so the bump level "tells a consumer nothing about whether the release breaks
them". The carriers of breaking-ness are the bolded banner in the body and the
ADR-0087 disposition — "during the window they are the only signal there is".

⇒ So `minor` here would not claim an incompatibility; it would claim NOTHING
about compatibility, which is precisely the cost the header names. This change
carries neither carrier because it owes neither — nothing is retired, no accept
set narrows, and `check-adr-0087-registration` reads it as non-breaking. The
level is `patch` because the lineage above is `patch` and no export is added,
not because `patch` rebuts something `minor` would have asserted.

**Nothing here is incompatible, and the reason is what the withheld rows are.**
They are the #6190 phantoms: org-scoped rows of types with no per-org read
channel. The platform has refused to mint them since `ac244ad09` / `6155c3c24`,
boot hydration skips them, `reportUnhydratableOrgScopedRows` audits them, and
**every REST `/meta` read door has already withheld them since `b6c769019`**.
The only doors still serving them were the dispatcher list
(`runtime/src/domains/meta.ts:921`) and the runtime manifest and publish-flip
reads (`packages.ts:1160`, `:603`) — so this change aligns those three with the
published `/meta` surface rather than departing from it. A consumer reading
those rows was reading through a door inconsistent with `/meta`, on data the
platform had already ruled dead.

⛔ Not "only a refactor of where the predicate lives" either: the predicate's new
position does change which rows three doors serve. That is why this is a
behaviour entry rather than an internal note — and, per the lineage above, why
the level for it is `patch`.

**Callers that already gate are unaffected, and that is proved rather than
asserted.** `organizationIdForMetaRead` answers either its argument or
`undefined`, so a second application over the same type is a no-op; the load-
bearing half is that it *is* the same type. The REST `GET /meta/:type` list door
gates on `canonicalMetaUrlType(req.params.type)` and passes the raw segment, which
`canonicalizeMetaRequestType` folds through the identical map — the identical
string. The other four `organizationIdForMetaRead` call sites in `rest-server.ts`
reach `getMetaItemLayered` / `getMetaItem` / `historyMetaItem` / `diffMetaItem`
and never this method. `get-meta-items-org-read-gate.test.ts` §3 measures both
halves over the complete accepted-spelling population (61 spellings, derived from
`META_URL_TO_SINGULAR` unioned with the registry) rather than a hand-listed
sample.
Loading
Loading