Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions scripts/check-adr-anchors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -238,6 +238,47 @@ import { join } from 'node:path';

import { ANCHORS_DIR, assembleAnchors, loadAnchors, shardNameFor } from './adr-anchors.mjs';

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'the base directory audit — collisions, allowlists and unparseable names': 14,
'A tombstone resolves citations but is not anchorable (#7329)': 15,
'Cited numbers resolve (#6634)': 15,
'Cited decision LETTERS resolve (#9592)': 26,
// ⛔ NOT today's count. This battery runs one case per `KNOWN_NUMBER_COLLISIONS`
// row (3 today) on top of 20 structural cases, and entries only ever LEAVE that
// list: a resolved collision is meant to be deleted, and the gate already fails
// a stale entry. A floor at 23 would redden every legitimate removal and train
// the next author to edit the floor, which is the one habit these floors exist
// to prevent. Pinned instead is the part that does not move with the list: the
// 20 structural cases ran AND at least one row was actually audited.
'Live tree: green as shipped, red under ablation': 21,
'the sharded registry\'s assembly (#6957)': 13,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 6;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

const ROOT = process.cwd();
/** Where the registry lives. One shard per anchor — see `scripts/adr-anchors.mjs`. */
const MAP_PATH = ANCHORS_DIR;
Expand DownExpand Up@@ -1130,13 +1171,28 @@ if (ambiguous.length) {
* has failed at its one job.
*/
function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
let checked = 0;
/** @param {string} name @param {boolean} cond @param {string} detail */
const assert = (name, cond, detail) => {
registerCase();
checked++;
if (!cond) failures.push(`${name} — ${detail}`);
};
battery('the base directory audit — collisions, allowlists and unparseable names');
const audit = (files, allowlist = []) => auditAdrDirectory(files, allowlist);
const joined = (errs) => errs.join('\n');

Expand DownExpand Up@@ -1236,6 +1292,7 @@ function selfTest() {
// exactly why one `records` set was not enough — so both are pinned, and a
// test of only the red half would pass on an implementation that broke the
// citation resolution the tombstone exists for.
battery('A tombstone resolves citations but is not anchorable (#7329)');
{
const TOMB = [...BASE, '0003-withdrawn-something.md'];
const { errors: e, records, nonDecisions } = audit(TOMB);
Expand DownExpand Up@@ -1335,6 +1392,7 @@ function selfTest() {
// the tracked tree the real scan reads, so a literal `ADR-` + four digits in
// a fixture would be collected as a genuine citation and fail the gate it is
// testing. `id('0202')` keeps the token out of the source.
battery('Cited numbers resolve (#6634)');
{
const id = (n) => 'ADR-' + n;
const RECORDS = new Set(['0090', '0107']);
Expand DownExpand Up@@ -1446,6 +1504,7 @@ function selfTest() {
// citations (measured: without the sub-decision rule, ADR-0120's lettered
// gates and ADR-0020's numbered steps — 20 live citations — read as bad
// letters); one too loose passes anything. Both halves are asserted.
battery('Cited decision LETTERS resolve (#9592)');
{
const id = (n) => 'ADR-' + n;
const idx = decisionIndexFor;
Expand DownExpand Up@@ -1613,6 +1672,7 @@ function selfTest() {
}

// ── Live tree: green as shipped, red under ablation ──────────────────────
battery('Live tree: green as shipped, red under ablation');
let liveFiles = null;
try {
liveFiles = readdirSync(join(ROOT, ADR_DIR));
Expand DownExpand Up@@ -1825,6 +1885,7 @@ function selfTest() {
// Two of these are the properties the split was adopted for, and they pull in
// OPPOSITE directions — so testing only the happy one would leave a layout
// that merges everything cleanly, including the two edits that must not.
battery('the sharded registry\'s assembly (#6957)');
{
const shard = (file) => [shardNameFor(file), JSON.stringify({ file, adrs: ['ADR-0001'], invariant: 'x' })];
const from = (pairs) => {
Expand DownExpand Up@@ -1917,6 +1978,51 @@ function selfTest() {
failures.push(`self-test threw before finishing — ${e && e.stack ? e.stack : e}`);
}

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length) {
console.error(`✗ check-adr-anchors --self-test — ${failures.length} failure(s) of ${checked} assertion(s)\n`);
for (const f of failures) console.error(' • ' + f + '\n');
Expand Down
111 changes: 111 additions & 0 deletions scripts/check-agent-test-spelling.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -818,25 +818,82 @@ function baseFixtureFiles(extra = {}) {
// handshake is a flag rather than a returned sentinel.
let selfTestReachedVerdict = false;

// ── The self-test's own battery roster and floor (#13489) ──────────────────
//
// `failures.length === 0` used to be this self-test's ONLY success condition, so
// "every case held" and "the cases never ran" printed the same line. Closed the
// way PR #13487 validated on check-doc-authoring: what is pinned is the
// registered NAMES, not a number. Every section opens with `battery('<name>')`,
// every assertion is attributed to the battery most recently opened, and the
// floor requires the OPENED set to equal the DECLARED set with each battery at
// or above its own count.
//
// ⛔ A pinned TOTAL is not the repair: a battery dropping from 9 cases to 3
// keeps a total "right" the moment a sibling grows.
//
// The counts are a FLOOR, not an equality — adding cases is ordinary work and
// must not red. A battery BELOW its floor means cases stopped running; the
// remedy is to find what stopped registering.
const SELF_TEST_BATTERIES = Object.freeze({
'classifier — forms that MUST be refused': 10,
'classifier — forms that MUST be allowed (a false red here is worse than no gate)': 18,
'the multi-line spelling a line-at-a-time reader misses': 2,
'the command word is what pnpm would resolve': 5,
'measured stripper carve-outs, both named': 2,
'the SWEEP over a real temp tree — the walk, not the predicate': 5,
'the escape hatch works — a declared counter-example is not a violation': 2,
'the same tree WITHOUT the plant is green — the red above is the plant, not the fixture': 3,
'anti-vacuity — every way a broken selector could wear a pass is a REFUSAL': 4,
'the declared lists cannot quietly become mute buttons': 4,
'the dispatch-gates declaration — both directions, derived from the scan roots': 8,
'the derivation reads THIS workspace, and reads it non-empty': 4,
});

// DELETING an entry silences that battery's floor exactly as effectively as
// zeroing it, so the roster's own size is pinned too.
const SELF_TEST_BATTERY_FLOOR = 12;

// The key an assertion is filed under when no battery is open. It is not a
// declared battery, so it reds by the same set difference rather than silently
// inflating whichever battery happened to run last.
const UNATTRIBUTED_BATTERY = '(no battery open)';

function selfTest() {
// The battery ledger this self-test's floor is evaluated against (#13489).
// `battery()` opens a battery; every assertion below is attributed to the one
// most recently opened, so a section that stops running stops registering and
// names ITSELF at the floor rather than going quiet.
const seen = new Map();
let openBattery = null;
const battery = (name) => {
openBattery = name;
};
const registerCase = () => {
const b = openBattery ?? UNATTRIBUTED_BATTERY;
seen.set(b, (seen.get(b) ?? 0) + 1);
};
const failures = [];
const t = (name, actual, expected) => {
registerCase();
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (!ok) failures.push(`${name}\n expected ${JSON.stringify(expected)}\n actual ${JSON.stringify(actual)}`);
console.log(` ${ok ? '✓' : '✗'} ${name}`);
};

console.log('classifier — forms that MUST be refused');
battery('classifier — forms that MUST be refused');
for (const line of RED_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length > 0, true);
}

console.log('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
battery('classifier — forms that MUST be allowed (a false red here is worse than no gate)');
for (const line of GREEN_CASES) {
t(line, scanLine(line, VITEST_SCRIPTS).findings.length, 0);
}

console.log('the multi-line spelling a line-at-a-time reader misses');
battery('the multi-line spelling a line-at-a-time reader misses');
t(
'continuation join',
scanLine(logicalLines('pnpm --filter <pkg> test \\\n -- --maxWorkers=2 <file>\n')[0].text, VITEST_SCRIPTS).findings.length,
Expand All@@ -846,17 +903,20 @@ function selfTest() {
t('continuation keeps the FIRST line number', logicalLines('a \\\nb\nc\n').map((l) => l.line), [1, 3, 4]);

console.log('the command word is what pnpm would resolve');
battery('the command word is what pnpm would resolve');
t('--filter consumes its value', commandWord(['pnpm', '--filter', 'test', 'build']), 'build');
t('run keyword is skipped', commandWord(['pnpm', 'run', 'test']), 'test');
t('bare script', commandWord(['pnpm', 'test']), 'test');
t('dev script', commandWord(['pnpm', 'dev:crm']), 'dev:crm');
t('no command word', commandWord(['pnpm']), null);

console.log('measured stripper carve-outs, both named');
battery('measured stripper carve-outs, both named');
t('turbo', judgeRun(['pnpm', 'turbo', 'run', 'test'], VITEST_SCRIPTS).bound, false);
t('npm', judgeRun(['pnpm', 'npm', 'run', 'test'], VITEST_SCRIPTS).bound, false);

console.log('the SWEEP over a real temp tree — the walk, not the predicate');
battery('the SWEEP over a real temp tree — the walk, not the predicate');
const redTree = makeFixtureTree(
baseFixtureFiles({ '.claude/agents/bad.md': 'Run `pnpm --filter @objectstack/spec test -- --maxWorkers=2 <file>`.\n' }),
);
Expand All@@ -870,6 +930,7 @@ function selfTest() {
t('the message names the escape hatch', joined.includes('COUNTER_EXAMPLE_FILES'), true);

console.log('the escape hatch works — a declared counter-example is not a violation');
battery('the escape hatch works — a declared counter-example is not a violation');
const exempted = sweep(redTree, {
counterExamples: [{ path: '.claude/agents/bad.md', reason: 'quotes the broken form as a warning' }],
});
Expand All@@ -880,6 +941,7 @@ function selfTest() {
}

console.log('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
battery('the same tree WITHOUT the plant is green — the red above is the plant, not the fixture');
const greenTree = makeFixtureTree(baseFixtureFiles());
try {
const lines = [];
Expand All@@ -896,6 +958,7 @@ function selfTest() {
}

console.log('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
battery('anti-vacuity — every way a broken selector could wear a pass is a REFUSAL');
const noRoot = makeFixtureTree({ 'AGENTS.md': 'x\n' });
try {
t('a missing declared root refuses', run(noRoot, () => {}), EXIT_REFUSED);
Expand DownExpand Up@@ -946,6 +1009,7 @@ function selfTest() {
}

console.log('the declared lists cannot quietly become mute buttons');
battery('the declared lists cannot quietly become mute buttons');
t('exactly one rule-owning file', RULE_OWNING_FILES.length, 1);
t('and it is this file', RULE_OWNING_FILES[0], 'scripts/check-agent-test-spelling.mjs');
t('every counter-example carries a reason', COUNTER_EXAMPLE_FILES.every((e) => typeof e.reason === 'string' && e.reason.trim().length > 0), true);
Expand All@@ -972,6 +1036,7 @@ function selfTest() {
// The live `hintCovers` results are recorded in the docblock as a
// MEASUREMENT, taken at the command line where it costs nothing.
console.log('the dispatch-gates declaration — both directions, derived from the scan roots');
battery('the dispatch-gates declaration — both directions, derived from the scan roots');
{
const scanRoots = [...INSTRUCTION_ROOTS, ...EXECUTED_ROOTS];
// A root with no separator is refused by the extractor as too generic, so
Expand DownExpand Up@@ -1009,12 +1074,58 @@ function selfTest() {
}

console.log('the derivation reads THIS workspace, and reads it non-empty');
battery('the derivation reads THIS workspace, and reads it non-empty');
const derived = deriveVitestScripts(REPO_ROOT);
t('derives a non-empty script set', derived.names.size > 0, true);
t('derives `test`', derived.names.has('test'), true);
t('does NOT derive `dev` — the documented dev-server spelling is safe by measurement', derived.names.has('dev'), false);
t('does NOT derive `dev:crm`', derived.names.has('dev:crm'), false);

// ── The floor: every declared battery RAN, and ran its cases (#13489) ───
//
// Evaluated after every battery has had its chance and BEFORE the verdict, so
// the success line below can only be printed by a run in which the set of
// batteries that registered assertions EQUALS the set declared. A set
// difference names WHICH battery stopped; a count says only that something did.
const floorFailure = (message) => {
failures.push(message);
};
const declaredBatteries = Object.keys(SELF_TEST_BATTERIES);
let floorBreached = false;
if (declaredBatteries.length < SELF_TEST_BATTERY_FLOOR) {
floorBreached = true;
floorFailure(
`SELF_TEST_BATTERIES declares ${declaredBatteries.length} batteries, below the pinned ` +
`${SELF_TEST_BATTERY_FLOOR} — a battery deleted from the roster takes its own floor with it.`,
);
}
for (const [name, count] of seen) {
if (declaredBatteries.includes(name)) continue;
floorBreached = true;
floorFailure(
`self-test battery "${name}" registered ${count} case(s) but is not declared in ` +
'SELF_TEST_BATTERIES — an assertion attributed to no declared battery is one nothing floors.',
);
}
for (const name of declaredBatteries) {
const count = seen.get(name) ?? 0;
if (count >= SELF_TEST_BATTERIES[name]) continue;
floorBreached = true;
floorFailure(
count === 0
? `self-test battery "${name}" DID NOT RUN — 0 cases registered, ${SELF_TEST_BATTERIES[name]} pinned. ` +
'The verdict below would have claimed those cases hold.'
: `self-test battery "${name}" registered ${count} case(s), below its pinned floor of ` +
`${SELF_TEST_BATTERIES[name]} — cases that used to run no longer do.`,
);
}
if (floorBreached) {
floorFailure(
'A battery at or below its floor means cases STOPPED RUNNING — the battery is the bug, not the ' +
'number. Find what stopped registering (an early return, a deleted block, a guard that now ' +
'skips) and restore it.',
);
}
if (failures.length > 0) {
console.error(`\n✗ check-agent-test-spelling --self-test -- ${failures.length} failure(s)\n`);
for (const failure of failures) console.error(` ${failure}`);
Expand Down
Loading
Loading