test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-project-manager merged 2 commits into from
Sep 3, 2026
+36 −6
Merged

test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03) #14871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fdf971
test(cli): quarantine the never-read-reader hang case behind #14832 (…
claude Sep 3, 2026
edf0095
test(cli): keep the quarantined file strict-clean with a definite-ass…
claude Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 36 additions & 6 deletions packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
built = await runCli(REAL_COMMAND, dir, undefined);
genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
// ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
// the failure message below, as evidence; the ceiling is a constant, so a
// slow sample can no longer size the instrument that judges the next run.
unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
// ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
// feeds is skipped. See the quarantine note on
// `it.skip('gives up and exits instead of waiting forever')` further down:
// this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
// and that one case is its ONLY consumer — `unread` is read nowhere else in
// this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
// and restores these four lines verbatim, in the same change:
//
// // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
// // the failure message below, as evidence; the ceiling is a constant, so a
// // slow sample can no longer size the instrument that judges the next run.
// unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
* this replaces armed no bound at all (`write()` returned true, so an early
* return skipped it) and read as correct in every stalled-reader test.
*/
it('gives up and exits instead of waiting forever', () => {
// ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
// objectstack#14832 — do not un-skip it on its own.
//
// WHY. The `'never-read'` child this case reads HANGS under CI load. The
// defect is in the product — `bin/run-dev.js`, the other half of #14832 —
// and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
// nothing and would only make each failure slower. On `Test Core (1/6)` the
// harness SIGKILLed the child at the 180 s cap and this assertion red, and
// every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
// for hours behind this one case, which is what the ruling weighed.
//
// RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
// this case in the SAME change, and restores the `'never-read'` spawn in
// `beforeAll` (kept there verbatim, commented). The body below and all of its
// comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
// that one spawn line — nothing here has to be reconstructed.
it.skip('gives up and exits instead of waiting forever', () => {
// A child still alive at the cap was SIGKILLed: signal set, code null.
// That is the hang, and it is the whole point of this case.
//
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)#14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-project-manager
merged 2 commits into

from

Sep 3, 2026

+36

−6

 Merged


test(cli): quarantine the never-read-reader hang case behind #14832 (maintainer ruling A, 2026-09-03)
#14871
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
2fdf971

test(cli): quarantine the never-read-reader hang case behind #14832 (…


claude Sep 3, 2026
edf0095

test(cli): keep the quarantined file strict-clean with a definite-ass…


claude Sep 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


42 changes: 36 additions & 6 deletions
packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,13 @@ let unbuilt: Run;
let built: Run;
let genuinelyMissing: Run;
let stalled: Run;
let unread: Lifetime;
// Definite-assignment assertion for the duration of the QUARANTINE below: the
// `'never-read'` spawn in `beforeAll` is commented out, so nothing assigns this
// and `strict` reports TS2454 at each of the three reads inside the skipped
// case. Restoring that spawn makes the `!` redundant again, so it goes when the
// quarantine is lifted. (Measured: the package's own `typecheck` is
// `include: ["src"]`, so it never compiles this file and would not have said.)
let unread!: Lifetime;
let closedEnd: Lifetime;

beforeAll(async () => {
Expand All@@ -300,10 +306,18 @@ beforeAll(async () => {
 built = await runCli(REAL_COMMAND, dir, undefined);
 genuinelyMissing = await runCli(['definitely-not-a-command'], dir, undefined);
 stalled = await runCliWhileParentStalls(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`);
 // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // the failure message below, as evidence; the ceiling is a constant, so a
 // slow sample can no longer size the instrument that judges the next run.
 unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 // ⛔ QUARANTINED — the `'never-read'` child is NOT spawned while the case it
 // feeds is skipped. See the quarantine note on
 // `it.skip('gives up and exits instead of waiting forever')` further down:
 // this spawn is where the 180 s `UNREAD_HARD_CAP_MS` is paid under CI load,
 // and that one case is its ONLY consumer — `unread` is read nowhere else in
 // this file. The PR that fixes the hang in `bin/run-dev.js` un-skips that case
 // and restores these four lines verbatim, in the same change:
 //
 // // ⛔ Nothing measured above is consulted here. Case 1's wall clock is read by
 // // the failure message below, as evidence; the ceiling is a constant, so a
 // // slow sample can no longer size the instrument that judges the next run.
 // unread = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'never-read', UNREAD_HARD_CAP_MS);
 closedEnd = await runCliAgainstDeadReader(REAL_COMMAND, dir, `--import ${UNBUILT_HOOK}`, 'destroy-read-end', UNREAD_HARD_CAP_MS);
}, RUN_TIMEOUT_MS * 6);

Expand DownExpand Up@@ -392,7 +406,23 @@ describe('the mirror direction: a reader that is never coming back', () => {
 * this replaces armed no bound at all (`write()` returned true, so an early
 * return skipped it) and read as correct in every stalled-reader test.
 */
 it('gives up and exits instead of waiting forever', () => {
 // ⛔ QUARANTINED under the maintainer's ruling A of 2026-09-03 on
 // objectstack#14832 — do not un-skip it on its own.
 //
 // WHY. The `'never-read'` child this case reads HANGS under CI load. The
 // defect is in the product — `bin/run-dev.js`, the other half of #14832 —
 // and NOT a cap that is set too low, so raising `UNREAD_HARD_CAP_MS` would buy
 // nothing and would only make each failure slower. On `Test Core (1/6)` the
 // harness SIGKILLed the child at the 180 s cap and this assertion red, and
 // every occurrence EJECTED A WHOLE MERGE-QUEUE BATCH: `main` could not advance
 // for hours behind this one case, which is what the ruling weighed.
 //
 // RE-ENABLE CONDITION. The PR that fixes the hang in `bin/run-dev.js` un-skips
 // this case in the SAME change, and restores the `'never-read'` spawn in
 // `beforeAll` (kept there verbatim, commented). The body below and all of its
 // comments are untouched, so lifting the quarantine is `it.skip` -> `it` plus
 // that one spawn line — nothing here has to be reconstructed.
 it.skip('gives up and exits instead of waiting forever', () => {
 // A child still alive at the cap was SIGKILLed: signal set, code null.
 // That is the hang, and it is the whole point of this case.
 //
Expand Down
Loading