Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
79 changes: 79 additions & 0 deletions .changeset/sharing-reconcile-per-grant-organization-refusal.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
---
"@objectstack/plugin-sharing": minor
---

fix(plugin-sharing): one refused grant no longer aborts a sharing rule's reconcile pass — its stale-row revocations still run (#14754)

After #14484 `sys_record_share` is `tenant-scoped` in the #13491 ledger, so on a
walled install an organization-less system insert on it is refused loudly with
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` (#8844). `SharingService.grant`
resolves the organization on every path that can; a platform-global sharing
rule (`organization_id = null`, its sweep unscoped) materialising a grant onto
an organization-LESS record resolves none, and meets that refusal.

`SharingRuleService.reconcile` / `reconcileForRecord` had no per-grant catch, so
the refusal propagated and **that rule's pass aborted mid-loop**. Two things
were lost, and they are not equally serious:

- the remaining grants — recoverable, the next pass writes them;
- **the stale-row revocations of that pass** — not recoverable by waiting,
because every subsequent pass meets the same organization-less record and
dies in the same place. A stale over-grant of that rule therefore persisted
indefinitely, and the record kept aborting the pass until it was repaired by
hand. That is the security-relevant half.

Measured while pinning this, and it sharpens the point: the engine returns
organization-less rows **last** in a rule's criteria sweep (the driver's
NULL-org compatibility arm is appended to the scoped arm). So a refused grant
is nearly always one of the final attempts of a pass, and what an abort
destroyed was hardly ever "the remaining grants" — it was almost entirely the
revoke loop that runs after the whole upsert loop.

Both loops now attempt each grant individually. A refusal is logged with the
rule, object, record, recipient and the engine's own code, counted, and the
pass **continues** — the remaining grants and, above all, the stale-row
revocations still run.

**The catch is deliberately narrow.** Only
`ERR_SYSTEM_WRITE_ORGANIZATION_REQUIRED` is absorbed; every other error
rethrows unchanged. A catch-all would swallow real defects and report a pass
that "completed" having written nothing. It would also silently retire a
reviewed decision: `record-share-organization-stamp.test.ts` deliberately pins
the abort on the OTHER error a reconcile pass can meet here — the scoped update
half answering `RECORD_NOT_FOUND` for a row stamped with a different
organization — which the 2026-09-02 contract review left standing on "loud
beats a wrong count". Those three pins are unchanged and still green.

**Why `minor` rather than `patch`.** The repair is a bug fix, but it reports
through a new key. `reconcile` / `reconcileForRecord` / `evaluateRule` /
`evaluateAllForRecord` now return `SharingRuleReconcilePassResult` — the spec's
`SharingRuleEvaluationResult` plus `grantsRefused: number` — and that type is
newly exported from the package index. Purely additive: the contract in
`@objectstack/spec` is untouched, its six declared fields are unchanged, and a
consumer typed against `ISharingRuleService` keeps compiling as it did. Same
shape as `fix(runtime): tell an action handler when its caller-scope record load
was refused` (#14143), which shipped `minor` for the same reason.

`grantsRefused > 0` does **not** mean the pass failed. It means the pass met a
record it cannot grant on and carried on — which is the whole point.

**Wire surface — declared, not lifted.** `grantsRefused` reaches the wire.
`POST /api/v1/sharing/rules/:idOrName/evaluate` is a ledgered **SDK** route —
`packages/rest/src/rest-route-ledger.ts:390`, the row carrying
`disposition: 'sdk'` and `client: 'shares.rules.evaluate'` — and its REST handler
passes the service return value through **unfiltered**
(`packages/rest/src/rest-server.ts:11108`–`:11109`:
`const result = await svc.evaluateRule(req.params.idOrName, context ?? {})`
followed by `res.json(result)`). So the seventh key is on the response body every
caller of that route already receives. The SDK method declares
`SharingRuleEvaluationResult` as its resolved type
(`packages/client/src/index.ts:4766`, unwrapped at `:4771` through
`unwrapResponse` parameterised on that same type), and that type is the spec's
six-field contract — so the **declared client type cannot name the seventh key**.
That is a client-type **lag**, not a contract break: the key is additive on the
wire, every declared field is unchanged, and a consumer typed against
`SharingRuleEvaluationResult` keeps compiling exactly as before. Lifting the type
is not this PR's to do — `SharingRuleEvaluationResult` lives in
`@objectstack/spec`, a `domain:spec` single-owner file — so the lag is declared
here and tracked as the follow-up #14969, which lifts `grantsRefused?: number`
(optional) into `SharingRuleEvaluationResult`.
2 changes: 1 addition & 1 deletion content/docs/permissions/system-context.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ The largest single consumer — **17 of the 106 sites**.
| 36 | `sys_record_share` reads are **not** self-scoped | Get: tenant-wide share listing without `manage_sharing` | `sharing-plugin.ts:1088` |
| 37 | Share-link policy `enabled` check bypassed; system callers re-enter under a system context | Get: link **creation** while the policy is off — resolution is **not** bypassed since #14033 (`publicSharing.enabled` is a standing policy held at every redemption): a link minted this way does not resolve until the block is enabled | `plugin-sharing/src/share-link-service.ts:469`, `:523`, `:527`, `:600`, `:630` |
| 38 | Sharing-rule provenance stamp skipped | Lose: the row is not marked as an admin customization — seeder / `defineRule` / boot reconcilers are "the package door" | `sharing-rule-provenance.ts:47` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:165`, `:390` |
| 39 | Sharing-rule service write + delete paths return early | Lose: the manage-rules gate on the service surface, and the platform-global-rule delete guard | `sharing-rule-service.ts:202`, `:427` |

### 4. Approvals, reports, attachments, comments, knowledge

Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/plugin-sharing/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ export {
export {
SharingRuleService,
type SharingRuleServiceOptions,
// [#14754] The spec's `SharingRuleEvaluationResult` plus the pass's
// `grantsRefused` count. Additive: the six declared fields are unchanged, and
// a consumer typed against the spec contract keeps compiling untouched.
type SharingRuleReconcilePassResult,
} from './sharing-rule-service.js';
export {
ShareLinkService,
Expand Down
Loading
Loading