Uh oh!
There was an error while loading. Please reload this page.
fix(objectql): publish the record's organization on every DataEvent - #15220
Conversation
…14970) `DataEventSchema.organizationId` was declared and published by the spec half but populated by nothing, so every `data.record.*` event went out with the key absent — which the contract requires a consumer to read as "this record is behind no organization wall". `publishDataEvent` now resolves it from the row itself: the written record on `created`, the post-state on `updated`, and the by-id branch's already-read pre-image on `deleted`, so no per-event read is bought. The record's organization, never `ExecutionContext.tenantId` — that is the caller's active org, and the two diverge on exactly the system/unscoped write this key most needs to label correctly. Absence keeps one spelling: the key is omitted, never `''` (which the schema refuses outright, dropping the whole event) and never an explicit `undefined` (which survives `parse` as a present key). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ
📓 Docs Drift Check3 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run. What this run could not see
Coarse fallback — 16 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b72cd3f95f66f9f79774593380963082b4e1f026 && git checkout b72cd3f95f66f9f79774593380963082b4e1f026
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 9c1bcda382067e75e2d69f11086d6c986ccb987a 4eaa3b81424a984543170be7d54ef6f6f1f7511a && git checkout -B drift-repro 9c1bcda382067e75e2d69f11086d6c986ccb987a && git merge --no-ff 4eaa3b81424a984543170be7d54ef6f6f1f7511a
node scripts/docs-audit/affected-docs.mjs --json 9c1bcda382067e75e2d69f11086d6c986ccb987a |
…blish-data-event-organization
…ne line shift Mechanical repair by `node scripts/check-system-context-census.mjs --fix`, the only correct writer for this table. Pure line rot: the `eventOrganizationId` helper and its threading shifted every later line in `packages/objectql/src/engine.ts`, so 14 anchors (15 citation sites — one source line is cited twice) pointed at the wrong lines. No population and no classification change: still 106 elevation read sites in 20 packages across 45 files, all anchored; 140 anchors resolve, 27 declared non-read — the same figures as before the shift. `--fix` did not refuse, and the diff is digits and nothing else (12 lines added, 12 removed, identical once digits are stripped). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ
zhuangjianguo
commented
Sep 4, 2026
Interim review note — ⛔ not a verdict. CI has not converged on PM seat ✅ The anchor repair is verified independently, by arithmetic rather than by trustThe
|
Uh oh!
There was an error while loading. Please reload this page.
…15220) * fix(objectql): publish the record's organization on every DataEvent (#14970) `DataEventSchema.organizationId` was declared and published by the spec half but populated by nothing, so every `data.record.*` event went out with the key absent — which the contract requires a consumer to read as "this record is behind no organization wall". `publishDataEvent` now resolves it from the row itself: the written record on `created`, the post-state on `updated`, and the by-id branch's already-read pre-image on `deleted`, so no per-event read is bought. The record's organization, never `ExecutionContext.tenantId` — that is the caller's active org, and the two diverge on exactly the system/unscoped write this key most needs to label correctly. Absence keeps one spelling: the key is omitted, never `''` (which the schema refuses outright, dropping the whole event) and never an explicit `undefined` (which survives `parse` as a present key). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ * docs(permissions): re-anchor the system-context census after the engine line shift Mechanical repair by `node scripts/check-system-context-census.mjs --fix`, the only correct writer for this table. Pure line rot: the `eventOrganizationId` helper and its threading shifted every later line in `packages/objectql/src/engine.ts`, so 14 anchors (15 citation sites — one source line is cited twice) pointed at the wrong lines. No population and no classification change: still 106 elevation read sites in 20 packages across 45 files, all anchored; 140 anchors resolve, 27 declared non-read — the same figures as before the shift. `--fix` did not refuse, and the diff is digits and nothing else (12 lines added, 12 removed, identical once digits are stripped). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ --------- Co-authored-by: Claude <noreply@anthropic.com>
Fixes#14970
DataEventSchema.organizationIdhas been declared and published since the spec half landed (PR #14635, squash2aa8456cf), and its TSDoc states the obligation on the producer's side, verbatim:The engine populated it on no event at all. Every
data.record.created/updated/deletedwent out with the key absent, which the same TSDoc requires a consumer to read as "not behind any organization wall" — so an organization-stamped row was published as an unwalled one, and a tenant-scoped fan-out had nothing to discriminate on. That is the producer half of the confirmed p0 cross-tenant leak; the landed spec term and the ready consumer piece were both inert without it.What changed
publishDataEventresolves the organization from the row itself and conditionally spreads the key into theDataEventSchema.parse({...})call besideuserId/changes/after. A new module-scope helpereventOrganizationId(objectSchema, row)sits with the file's other event helpers (eventRecordId,eventRecordBody,eventUserId) and is the only place the resolution happens, so the three actions cannot drift apart.The row is passed explicitly as a new
input.organizationRowrather than inferred fromafter, because the delete path is the one with noafterand would otherwise silently publish the key absent — the regression this card is most likely to grow later.createdafterupdatedresult)afterdeletedpriorRecord)beforeDeleteever fires⇒ No per-event read is bought anywhere. This is a threading job, not a resolution job: the key exists precisely to keep a per-event lookup off the fan-out path, and triage ruled that read out for the consumer side on 2026-08-31.
Three properties that are load-bearing rather than incidental
ExecutionContext.tenantIdis the caller's active organization — the sensebuildHookUserdeliberately publishes asctx.user.organizationId. The two coincide on an ordinary tenant write and diverge on a system or unscoped one, where substituting it would mislabel an administrator's write into another organization as belonging to the administrator's. The row's own tenant column is the only source consulted.null, not'', not an explicitundefined. Measured against the built spec:''is rejected (too_small), so producing one would have thrown inside the publish site and dropped the event entirely — a silence worse than an absent key; and a key set to an explicitundefinedsurvivesparseas a present key. Hence the conditional spread, and hence the gate living in the resolver rather than in the error handler.resolveTenantFieldName, i.e. thetenancy.enabled: falseopt-out, then a declaredtenancy.tenantField, then the kernel-injectedorganization_id— so the event cannot name an organization for a column the engine does not actually scope by. Note the two spellings differ and are easy to conflate: the column is snake_caseorganization_id, the published key is camelCaseorganizationId.A malformed tenant column is treated as absent, not coerced: a bare
String(value)would turnfalseinto a perfectly validmin(1)string, which is the "never fabricated" clause's exact failure mode. The value passes the write path's owncarriesOrganizationpredicate and then the same coercion laddereventRecordIdalready uses for the other id on this event.Verification
All numbers below are from commit
4eaa3b81—928306e9merged withorigin/mainat9c1bcda3, plus the anchor repair described below.origin/maindid not touchengine.tsbetween the two, so the only line shift in that file is this PR's.8 new pins in⚠️ A green suite proves nothing on its own here — the failure mode is "the key is absent on every event", and a pin that only asserts absent when there is no organization passes happily against it. So every positive pin writes a row into an organization the caller is not standing in (
packages/objectql/src/engine-data-events.test.ts, covering all three actions.isSystemcaller withtenantId: 'org_platform', row stampedorg_acme), and asserts both spellings on the same event; absence is asserted ashasOwnProperty === false, never as=== undefined.Two ablations prove the pins discriminate. Both were run from the committed state, each leg proven on disk by an occurrence count before the run, with an absolute-path
traprestore verified by blob hash. The suite imports./engine.jsrelative tosrc/, andpackages/objectql/distdid not exist for these runs — so no build step stood between the mutation and the measurement.input.context.tenantId, the caller's orgAblation 1 is the important reading: the 5 reds are exactly the positive pins, and the 3 absence pins stayed green. A suite that had only asserted absence would have reported 25/25 green against the live p0 defect. Ablation 2 turns all 8 red, including the absence pins (
expected true to be false— the caller's org stamped onto a row that has none), so ruling 3 is pinned in both directions. Restore verified: blob back to860d4962,git diff HEADempty.Suites and gates, all at
928306e9:pnpm --filter @objectstack/objectql exec vitest run— 269 files / 4626 tests passedpnpm --filter @objectstack/objectql typecheck— pass, includingcheck:test-typecheck(44 files, 69 pinned signatures held; no new debt). Both edited files confirmed present in a real tsc program via--listFiles, so the green is a measurement rather than an empty one.pnpm --filter @objectstack/plugin-webhooks exec vitest run— 11 files / 131 tests passed (the fan-out consumer this card unblocks)pnpm lint— the full repo scan, exit 0 in 55s; no narrowing claimednode scripts/pm/dispatch-gates.mjswith no path arguments (its git-derived change set — 4 paths vs merge base9c1bcda38— is authoritative): 59 pass, 3 unmeasurable in this container, none of them touching this diff — see belownode scripts/check-system-context-census.mjs— clean: 106 elevation read sites in 20 packages across 45 files, all anchored; 140 anchors resolve, 27 declared non-readNot measured, and why
Three derived gates could not be measured here, and none of them is a red on this change:
check:dual-build-cjs-loadsandcheck:published-readme-exportsboth need a fullpnpm build. Both print their own cause. For the second, every finding is "type entry ... does not exist. Build first", and the count falls monotonically as packages are built — 96 of 96 initially, then 27 of 27 oncespec,objectqland theclient-reactclosure were built, with zero namingobjectql. Building@objectstack/objectqlalone dropped its own findings 10 to 0. So the cause is unambiguously build state, not this diff, which adds zero README lines and zero exports.check:dual-build-cjs-loadsreproduces the identicalPREREQUISITE NOT METon a tree without this change.check:react-declaration-parityneeds an objectuisdui.manifest.jsonand a browser dump.CI builds fresh and runs the farm exactly once, which is where all three get their real reading.
Anchor re-derivation (patch round)
content/docs/permissions/system-context.mdxis a generated line-anchor table intopackages/objectql/src/engine.ts. InsertingeventOrganizationIdand its threading shifted every later line, rotting 14 anchors (15 citation sites — one source line is cited from two rows) and reddeningcheck-system-context-censuswith 28 problems.Repaired mechanically, by the tool's own writer:
node scripts/check-system-context-census.mjs --fix. It did not refuse, and this is pure line rot with no population or classification change — three independent readings say so:site-without-a-rowplus 4ledger-row-unusedequals the 14anchor-is-not-a-read-site, the signature of a shift rather than a population change;⛔ The file was not hand-edited, and nothing about the elevation surface moved.
Scope
Out of scope, deliberately: #13566 (the
domain:servicesfan-out filter, which consumes the key this PR produces) andBulkDataEventSchema, which still carries no organization term —publishBulkDataEventis untouched, and the bulk fan-out path stays as it is. That is a separate spec-shape decision and nothing new was learned about it here.packages/spec/**is untouched. No schema, no accepted shape and no public export moves: the key was already declared, already validated and already part of what consumers parse. Only the implementation changed, from omitting a declared key to populating it — which is why this carries apatchchangeset.Generated by Claude Code